|author||Qiyu Hu <email@example.com>||Thu Nov 01 17:08:54 2018|
|committer||Benjamin Gordon <firstname.lastname@example.org>||Fri Dec 07 18:31:59 2018|
system_api: Add EIR property in bluetooth_device This was added in crrev.com/c/1308457 BUG=chromium:887029,b:118334521 TEST=CQ Change-Id: If80d8fc275e485f4f1db5d3c26e804b28aeaba5a Reviewed-on: https://chromium-review.googlesource.com/1312382 Commit-Ready: ChromeOS CL Exonerator Bot <email@example.com> Tested-by: Qiyu Hu <firstname.lastname@example.org> Reviewed-by: Mike Frysinger <email@example.com> (cherry picked from commit f7ec755ab30a72b8edb751703422f145b86549b0) Reviewed-on: https://chromium-review.googlesource.com/c/1361651 Reviewed-by: Miao-chen Chou <firstname.lastname@example.org> Commit-Queue: Benjamin Gordon <email@example.com> Tested-by: Benjamin Gordon <firstname.lastname@example.org>
This directory (
platform2/system_api) contains constants and definitions like D-Bus service names that are shared between Chromium and Chromium OS.
This directory is only for things like headers and .proto files. No implementation should be added.
When writting a .proto file make sure to use:
option optimize_for = LITE_RUNTIME;
This will force usage of a lite protobuf instead of a full/heavy weight protobuf. The browser only links against the light version, so you will get cryptic link errors about missing parts of Message if you define a protobuf here and then try to use it in Chrome. Currently CrOS links against the full protobuffer library, but that might change in the future.
When declaring a protobuf, avoid use of required unless it is exactly what you mean. “Required is Forever” and very rarely should actually be used. Consult Protocol Buffer Basics: C++ for a detailed of this issue.