tree c954bb024a7eb5f87102d78f118f8e2a56fd3d97
parent 6763452a7925973c7d7514806a18ad8812a1acc1
author Robert Tarasov <tutankhamen@google.com> 1605405880 -0800
committer Commit Bot <commit-bot@chromium.org> 1605440458 +0000

Merged apitrace changes from upstream into cros/master

Squashed commit of the following:

commit 1aa83915bfc310ba5901136013dcd2b6ee641e00
Author: Jose Fonseca <jfonseca@vmware.com>
Date:   Fri Sep 18 14:11:32 2020 +0100

    inject: Fix MinGW cross-compilation errors on Ubuntu 20.04.

commit 88c8ce04bd34f4230306bef182d3ae280abecd6e
Author: Jose Fonseca <jfonseca@vmware.com>
Date:   Fri Sep 18 14:11:07 2020 +0100

    ci: Improve Ubuntu 16.04 dockerfile.

commit b979e41dd57703dc040cf98895dc245937dbb197
Author: Jose Fonseca <jfonseca@vmware.com>
Date:   Mon Sep 14 16:34:21 2020 +0100

    cmake: Avoid MinGW ld segfault on Ubuntu 20.04.

commit f1779aa2ae18af1b3a262b878f5cfd60a21d4227
Author: Jose Fonseca <jfonseca@vmware.com>
Date:   Mon Jul 13 13:15:14 2020 +0100

    inject: Improve GetProcAddress logging.

commit dad6340a92ce4086444e9ac661adf1c49d0ebd5e
Author: Biswapriyo Nath <nathbappai@gmail.com>
Date:   Thu Aug 13 01:15:28 2020 +0530

    thirdparty/dxerr: cast xaudio2 error codes to HRESULT type

    Changes:
    * thirdparty/dxerr/dxerr.cpp: cast XAUDIO2_E_ defines to HRESULT
    which is the result type of the parameter of both DXGetErrorStringA
    and DXGetErrorDescriptionA function.

    Otherwise, gcc shows error narrowing conversion from int to long.
    This casting also matches with WinSDK xaudio2.h file.

commit a112ac39bab602700e879062e5d42f985b2f684b
Author: Jose Fonseca <jfonseca@vmware.com>
Date:   Thu Jul 30 17:24:37 2020 +0100

    appveyor: Always use RelWithDebInfo configuration.

    Now that we take nightly builds from AppVeyor, we shouldn't be using
    MSVC debug runtime.

    Fixes https://github.com/apitrace/apitrace/issues/677

commit 935d10a46dd35b878daeb272c92b6100d3dfd916
Author: Jose Fonseca <jfonseca@vmware.com>
Date:   Fri Jun 12 08:17:19 2020 +0100

    d3dretrace: Further cleanup the adapter logging.

commit 16271a01e3ffd6028b433ddd4e232ee8c2c5c241
Author: Jose Fonseca <jfonseca@vmware.com>
Date:   Thu Jun 4 16:30:12 2020 +0100

    d3dretrace: Cleanup.

commit 42fcc3fee44811fe5409be7c2ff8d42fab9a460d
Author: Jose Fonseca <jfonseca@vmware.com>
Date:   Wed Jun 3 18:50:41 2020 +0100

    specs: Better GL_ARB_shader_storage_buffer_object support.

commit ae2bd5560f94a036a1eb8427a5b46241468e39f4
Author: Jose Fonseca <jfonseca@vmware.com>
Date:   Fri May 29 18:41:46 2020 +0100

    d3dretrace: More complete igpu/dgpu selection.

commit 380e0667724777145cc9e019f2fb98e55fa79795
Author: Jose Fonseca <jfonseca@vmware.com>
Date:   Fri May 22 20:51:24 2020 +0100

    d3dretrace: Partial implementation of igpu/dgpu selection for DXGI.

commit a28033af2884d4f2a6e3a41ecc953acfe0d27d07
Author: Jose Fonseca <jfonseca@vmware.com>
Date:   Fri May 22 20:39:01 2020 +0100

    specs: Add DXGI interfaces added on Windows 10.0.18362 SDK.

commit 2bfcc45aa10966da928a5b6e81872e04d0c48fda
Author: velorums <velorums@gmail.com>
Date:   Sat May 23 21:57:30 2020 +0200

    gui: preserve main window size and layout between restarts

commit 1904c56caa434ae3fa9980e4b9ad4afad2cb14c2
Author: velorums <velorums@gmail.com>
Date:   Sat May 23 20:39:10 2020 +0200

    gui: fix PixelWidget hotkeys

commit a17c0bbcd361ab0f983f4fa6a7e1413e50c67381
Author: velorums <velorums@gmail.com>
Date:   Sat May 23 20:38:52 2020 +0200

    gui: make PixelWidget pass keypresses through so they reach scrollbars

commit 5d936aaf5d013e4b1e24eacd1bd46cd336f068a6
Author: Jose Fonseca <jfonseca@vmware.com>
Date:   Thu May 21 09:16:48 2020 +0100

    specs: Support DXGI 1.6.

commit b3ea7e44f37365bcdb9707ca2301186e876e6fea
Author: Jose Fonseca <jfonseca@vmware.com>
Date:   Thu May 21 09:14:00 2020 +0100

    specs: Port cxx2api script back to Python 2.

    Unfortunately pygccxml seems abandoned and was never ported to Python3.

commit 4abdb4c77fb4fd488d84c9ea141352f05d40b095
Author: Jose Fonseca <jfonseca@vmware.com>
Date:   Tue May 19 15:29:35 2020 +0100

    guids: Add a few missing GUIDs.

commit 1fd8b5acc4065b7587aa7767cf3e6c65aa2f148d
Author: Danylo Piliaiev <danylo.piliaiev@globallogic.com>
Date:   Fri Feb 7 16:28:53 2020 +0200

    gltrace: Commit all writes to coherent buffers before syncing them back

    Otherwise these writes would be lost. Deus Ex: Mankind Divided renders
    incorrectly without this.

    Signed-off-by: Danylo Piliaiev <danylo.piliaiev@globallogic.com>

commit 29dd3d8a4f4898fcac7acd4c6eb62f4992b5110b
Author: Danylo Piliaiev <danylo.piliaiev@globallogic.com>
Date:   Wed Jan 22 12:07:10 2020 +0200

    glws_glx: Allow pixel buffers in GlxDrawable::swapBuffers

    Pixel buffers are allowed to be used in glXSwapBuffers.

    glx 1.4 spec, 3.3.5 "Off Screen Rendering", "glXCreatePbuffer":

     "The resulting pbuffer will contain color buffers and ancillary
      buffers as specified by config. It is possible to create
      a pbuffer with back buffers and to swap the front and back
      buffers by calling glXSwapBuffers."

    Fixes replaying of Blender traces.

    Signed-off-by: Danylo Piliaiev <danylo.piliaiev@globallogic.com>

commit b9e4b73ced4e9547bb1edd1d4f452fffcd350630
Author: Jose Fonseca <jfonseca@vmware.com>
Date:   Sun May 17 09:39:02 2020 +0100

    glretrace: Exit early when state dumping is not possible.

commit 80e37c7fcc5e3e867fa7ec0dea48bc0c7ecfeb1d
Author: Martin Sherburn <martin.sherburn@datapath.co.uk>
Date:   Mon Apr 10 17:06:23 2017 +0100

    glretrace: Fixed issue where state could be dumped before the requested call had been executed in a multithreaded trace.

    For example when getting state for a particular Draw call, the
    framebuffer could contain the contents prior to the Draw call.

commit 894d44d26a93a971535f9cce264a0a8d5b6c5370
Author: Alex Smith <asmith@feralinteractive.com>
Date:   Tue Oct 25 10:31:16 2016 +0100

    glretrace: Show current frame number in window title

    I find this can be useful to roughly identify which frames I want to be
    looking at for a specific issue in a large trace, by replaying the trace
    and looking at the current frame number when the issue occurs.

commit c893b14d24bef0f8cbb0ca714d1cf2125c2dca94
Author: Robert Tarasov <tutankhamen@chromium.org>
Date:   Thu Jan 30 14:26:37 2020 +0000

    Add the new client application 'info'

    The new 'info' client prints the provided trace file information. The
    first version of the client shows the container version, api type and
    the total amount of frames in the trace file. The information can be
    printed in JSON format.

commit 1b3c83371ae34a894cff6168e765098f91c6620a
Author: Jose Fonseca <jfonseca@vmware.com>
Date:   Fri May 8 15:26:27 2020 +0100

    docs: Update build instructions for VS 2019.

commit 6e4caa545d181da3a6b459feb86cd57be2e2aca8
Author: Jose Fonseca <jfonseca@vmware.com>
Date:   Sat May 9 15:33:14 2020 +0100

    cmake: Get CPACK_PACKAGE_VERSION from git tag.

commit d6aae9212ba9d7bbcaa9b94185c398eabb31deeb
Author: Jose Fonseca <jfonseca@vmware.com>
Date:   Sat May 9 14:45:12 2020 +0100

    appveyor: Set shorter job names.

commit 22bd101397e32879dfcb24539b0d6cf7807d671f
Author: Jose Fonseca <jfonseca@vmware.com>
Date:   Fri May 8 09:31:56 2020 +0100

    appveyor: Upgrade to VS 2019.

commit 8aed3c3451240d513c65b28ddf39b3d8c50ef948
Author: Jose Fonseca <jfonseca@vmware.com>
Date:   Fri May 8 09:23:24 2020 +0100

    dxgitrace: Hack ability to hide away host D3D11.x features.

commit 54748eb7ae5f2405a606c185ab55620fbdff82de
Author: Convery <convery10122@gmail.com>
Date:   Fri Jun 14 20:11:35 2019 +0200

    mhook: Compilation-fix for VS 2019.

    Windows assumes default alignment in their SDKs, so pacing needs to be done after `#include <windows.h>` or defining `WINDOWS_IGNORE_PACKING_MISMATCH`.

    https://github.com/apriorit/mhook/commit/5ccb00a9c89280bfff7ce595873a9923415172a7

commit 95ce617ac74dad22ce6584fec0c6f6b75b9457d8
Author: Jose Fonseca <jfonseca@vmware.com>
Date:   Wed Apr 29 19:49:21 2020 +0100

    d3dretrace: Handle GPU counter queries gracefully.

    This are unlikely to exist across multiple systems.

commit 418fdee41a027d02d5e1eeb7106868f65b9dbe9a
Author: Jose Fonseca <jfonseca@vmware.com>
Date:   Wed Apr 29 19:48:15 2020 +0100

    dxgiretrace: Handle multiple outputs gracefully.

    The same number of outputs that was present when recording might
    not be present when replaying.

commit 6b55ceff1b00962e0f6afe45548714d6b53ad6cc
Author: Jose Fonseca <jfonseca@vmware.com>
Date:   Fri Apr 24 08:13:50 2020 +0100

    d3dretrace: Ignore incomplete SetClipPlane calls.

    For a time, only one of the 4 components of the pPlane parameter were
    recorded in the traces.  Such traces still are in use, and currently we
    end up using unrelated/random data for the missing coefficients.

    With this change we use a zero plane equation, which allows the calls to
    go through and reach the drivers, but guarantees the plane will never
    clip anything, even when the respective plane is enabled in
    D3DRS_CLIPPLANEENABLE, so one has reproducible rendering.

commit b5ab54dcf43edce92f1e0630092308addc3e35ac
Author: Jose Fonseca <jfonseca@vmware.com>
Date:   Wed Apr 15 15:39:35 2020 +0100

    inject: Intercept CreateProcessWithTokenW and CreateProcessWithLogonW.

commit 9e9afe7190c2a6a488d968b172ef9a6e78263cd4
Author: Jose Fonseca <jfonseca@vmware.com>
Date:   Wed Apr 15 15:38:43 2020 +0100

    guids: Recognize IID_IDXGIOutput6.

commit d1a98b6fc6d15934ae57e845940d7d6a80a05cc3
Author: Jose Fonseca <jfonseca@vmware.com>
Date:   Tue Apr 7 16:02:59 2020 +0100

    gltrace: Match opengl32.dll export ordinals.

    Some applications import DLL symbols by ordinal, so it's important the
    wrapper DLL ordinals match the original Windows DLL ordinals.

    Fixes https://github.com/apitrace/apitrace/issues/652

commit 6313c2cf7b94b4621c9185bcf25f1483c122c2b0
Author: Jose Fonseca <jfonseca@vmware.com>
Date:   Thu Mar 5 14:26:51 2020 +0000

    d3dretrace: Ignore IDXGIDevice2::EnqueueSetEvent calls.

commit e4f17e99da1314fa15c98107a642635ad8bfa68c
Author: Jose Fonseca <jfonseca@vmware.com>
Date:   Fri Feb 14 16:30:44 2020 +0000

    scripts: Fix bold off escape code.

commit ffe58eee216a5ccadb314502e5595e0db2222da7
Author: Jose Fonseca <jfonseca@vmware.com>
Date:   Thu Jan 30 14:26:37 2020 +0000

    gltrace: Fix `passing NULL to non-pointer argument` warning.

commit ddb32e0d1f00b78727464f2abb8c0fe766b401ca
Author: Jose Fonseca <jfonseca@vmware.com>
Date:   Thu Jan 30 14:24:03 2020 +0000

    docs: Update requirements to mention Python 3.6 instead of 2.6.

    As pointed out by Adam Mizerski.

commit 433f99b4e75920fc14816012834bd88998203105
Author: Jose Fonseca <jfonseca@vmware.com>
Date:   Mon Jan 27 11:07:13 2020 +0000

    d3dretrace: Drop NvOptimusEnablement.

    It doesn't seem to do what's documented.  In particular,
    NvOptimusEnablement = 0x00000000 seems to trigger NVIDIA no matter what,
    overriding the default system setting.

commit 88dd70de25e30c33d68c00188f6974e9a99ae69b
Author: Jose Fonseca <jfonseca@vmware.com>
Date:   Mon Jan 27 11:03:57 2020 +0000

    d3dretrace: Log adapter description for more methods.

commit 0f9eb7933d5531609771e55e5b65bc78581dc65c
Author: Jose Fonseca <jfonseca@vmware.com>
Date:   Mon Jan 20 12:29:16 2020 +0000

    gui: Fix conditional with identical branches.

    Fixes https://github.com/apitrace/apitrace/issues/647

commit 039e4abc0bbe4551952edf1759465c83b6611db5
Author: Ruslan Kabatsayev <b7.10110111@gmail.com>
Date:   Tue Dec 31 21:37:43 2019 +0300

    Show depth for textures that have depth>1

commit f207e43ec27c3829f9e07833f8a502aae02d9ca9
Author: Ruslan Kabatsayev <b7.10110111@gmail.com>
Date:   Tue Dec 31 21:14:53 2019 +0300

    Use unicode multiplication sign instead of Latin letter 'x'

commit 2d31d49eac9bcc01046e00df256a04ae13175c4e
Author: Gleb Mazovetskiy <glex.spb@gmail.com>
Date:   Fri Dec 13 13:39:19 2019 +0000

    Support libc that don't have RTLD_DEEPBIND

commit 725b69e123ad733e9e016a5e281f0c6a19b1261c
Author: Rémi Verschelde <rverschelde@gmail.com>
Date:   Sun Jan 19 12:55:56 2020 +0100

    Remove executable permission from .cpp files

    It's not harmful per se but also not necessary, and triggers warnings
    e.g. when building RPM packages.

commit ffb366c1c79ea7540802fa4803aa26330fd4d140
Author: Mark Janes <markjanes@swizzler.org>
Date:   Thu Jan 2 20:47:44 2020 -0800

    glretrace: Support traces which query uniform block names by index

    Apitrace supports titles which query the index for a given uniform
    block name.  Alternatively, titles may iterate active uniform block
    indices and retrieve the name at each index.

    To support this method of identifying uniform block bindings,
    glGetActiveUniformBlockName must be checked against the return value
    that was traced.

    Enables retracing of Bioshock6, which queries names by index.  Without
    this patch, a trace made on Linux will not retrace on Windows.

commit d359a24a5b28881ccfa5d942c09e9bc134c7ec8a
Author: Mark Janes <markjanes@swizzler.org>
Date:   Fri Dec 20 17:01:56 2019 -0800

    glretrace: Support traces which use GL_ARB_program_interface_query

    During retrace, the driver may choose a different uniform location
    than was recorded at trace time.  If the traced program looks up
    uniforms by name with glGetUniformLocation or similar apis, Apitrace
    correctly remaps locations at retrace time.

    However, GL_ARB_program_interface_query allows programs to iterate
    over program resources querying program names.  This reverse-lookup is
    not supported by glretrace, and any change to uniform bindings will
    result in a crash.

    Programs looking up names for each index will:

     - iterate the resources attached to the program, calling
       glGetProgramResourceName to record the name at each index.

     - iterate the resources attached to the program, calling
       glGetProgramResourceiv to get the uniform location for each index.

    This patch tracks the name at each program index, and then call into
    GL to determined current bindings for the named resource whenever
    glGetProgramResourceiv is encountered.

    Fixes GFXBench Aztec Ruins traces, which crashed when retraced on
    various drivers.  A trace made on Mesa would work on Intel and AMD
    Linux platforms, but would crash on Windows
    platforms (AMD/Intel/Nvidia).

commit d5861c63e070d88ccd2fecaa440cc9cace1c48b6
Author: Andrii Simiklit <andrii.simiklit@globallogic.com>
Date:   Tue Nov 26 18:49:39 2019 +0200

    gltrace: don't destroy GLMemoryShadow-s which are still in use

    This fixes shared coherent buffers behavior
    which causes a freeze in "Deus Ex: Mankind Divided".

    Here is an example of the problem, for instance
    we have two shared contexts `CA` and `CB` and we do something like:
    1. Create buffer `BA` in `CB`
    2. Map it in `CB`
    3. Destroy `CB`
    4. Use mapped `BA` memory  <<< This step will cause the freeze
                                   because on the step `3.` we destroyed `CB`.

    Destruction of the `CB` leads to `GLMemoryShadow` destruction which destroys
    the memory allocated for the `BA` and then it leads to the freeze in
    `PageGuardExceptionHandler` with SIGSEGV/SEGV_MAPERR becuase
    the client is trying to use the memory received from opengl

    Here is a spec OpenGL 4.6 "5.1 Object Deletion Behavior":
    "... If a shared object
     is not explicitly deleted, then destruction of any individual context has no effect
     on that object unless it is the only remaining context in the share list. Once the
     last context on the share list is destroyed, all shared objects, and all other resources
     allocated for that context or share list, will be deleted and reclaimed by the imple-
     mentation as soon as possible."

    So we shouldn't destroy resources shared
    between several contexts until all of them are destroyed.

    v2: fix Xcode compilation error

    Signed-off-by: Andrii Simiklit <andrii.simiklit@globallogic.com>

commit 189a3b8397c61ba262a2221885e38dc514c59d94
Author: Paul Cercueil <paul@crapouillou.net>
Date:   Sat Dec 7 00:00:57 2019 +0100

    dlsym: Fix build under uClibc

    uClibc defines the __GLIBC__ macro too (I know, right?), so verify that
    __UCLIBC__ is not defined before we can use glibc-specific internal
    functions.

    Signed-off-by: Paul Cercueil <paul@crapouillou.net>

commit 620399d3d704caf05b4f5aa67665004f2ed2427f
Author: Mark Janes <markjanes@swizzler.org>
Date:   Tue Nov 26 15:22:57 2019 -0800

    retrace: when looping on last frame, re-use Call objects

    Call objects are unnecessarily parsed when looping on the last frame.
    Parsing incurs significant CPU overhead, often limiting performance
    and making Apitrace unusable for benchmarking.

    https://github.com/apitrace/apitrace/issues/142

commit 5db09f40d65c9b1ab34ed2edcbd9e0e77a439cc0
Author: Jose Fonseca <jfonseca@vmware.com>
Date:   Wed Nov 27 12:49:45 2019 +0000

    gltrace: Fix __glPathGetCodePointUTF8 logic.

    Fixes https://github.com/apitrace/apitrace/issues/640

commit cae55f54c53449fd07f8a917dcd0874db2c15032
Author: Joshua Ashton <joshua@froggi.es>
Date:   Tue Nov 19 04:03:12 2019 +0000

    dlltrace: Implement dll path override.

    Implement env var APITRACE_FORCE_MODULE_PATH which allows the user to
    force override the directory to the dirs we want to trace against.This
    is useful for tracing against reimplementations (ie. d9vk/dxvk) on their
    native platforms.

commit ac7104852ca7b9e03328433cb75c09dfd2f85b1d
Author: Jose Fonseca <jfonseca@vmware.com>
Date:   Tue Nov 26 13:13:50 2019 +0000

    retrace: Make Waffle 1.6 a soft dependency.

commit 35f8bdecb5a6d5cfdd53d6e88d66c4ea64d054ad
Author: Jose Fonseca <jfonseca@vmware.com>
Date:   Tue Nov 26 12:12:33 2019 +0000

    travis: Upgrade to Xcode 11.2.

commit 6057b988a7074a0c7dcc344bc07aa39d2480e63f
Author: Jose Fonseca <jfonseca@vmware.com>
Date:   Tue Nov 26 12:10:55 2019 +0000

    retrace: Fix macOS build.

commit 47fd41ec7e5419dec205297153a668fc8d3669a7
Author: Jose Fonseca <jfonseca@vmware.com>
Date:   Sun Nov 24 22:22:28 2019 +0000

    dispatch: Add missing stdint.h include

commit f2c45ae8b8c5dc5de59facb04ea062bd8ae69337
Author: Gleb Mazovetskiy <glex.spb@gmail.com>
Date:   Fri Nov 15 18:26:20 2019 +0000

    cmake: Allow building without X11.

commit a737f865afb7290ba74cc5d7ac888dd3c0eeaf13
Author: Jose Fonseca <jfonseca@vmware.com>
Date:   Sun Nov 24 21:27:09 2019 +0000

    khronos: Update headers.

commit 4734a4252b1910bbd2908ff2e2d36949b99b91b8
Author: Emil Velikov <emil.velikov@collabora.com>
Date:   Fri Oct 11 11:52:06 2019 +0100

    glws_waffle: Add egl surfaceless support

    Bump the waffle version requirement to 1.6 and handle the new platform
    token.

    Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
    Signed-off-by: Alexandros Frantzis <alexandros.frantzis@collabora.com>

commit 15b80ffc265539208364f54fe69f9d18b1603f20
Author: Jose Fonseca <jfonseca@vmware.com>
Date:   Mon Nov 18 11:51:01 2019 +0000

    inject: Ignore LoadLibrary calls with data flags.

commit 8466187855091f902a900718b8807f6376c6ef84
Author: Jose Fonseca <jfonseca@vmware.com>
Date:   Mon Nov 18 11:45:45 2019 +0000

    inject: Recognise a few more API sets.

commit dfe37e3d4dcf43e118128f3febd9fe5dcced280d
Author: Jose Fonseca <jfonseca@vmware.com>
Date:   Mon Nov 18 11:45:06 2019 +0000

    inject: Be resilient against DLLs loaded as data/resource-only.

commit ae250e4f825ac1d068f421830729e9fd75001c64
Author: Jose Fonseca <jfonseca@vmware.com>
Date:   Mon Nov 18 11:05:12 2019 +0000

    travis: Fix ubuntu64-clang build.

commit 75b604862707f37af7cefd522ca547a029a091e3
Author: Jose Fonseca <jfonseca@vmware.com>
Date:   Thu Nov 14 14:03:08 2019 +0000

    travis: Upgrade to bionic.

commit 66bd8555bbe7ba9a18fab20eaf8a04d0588a01e0
Author: Jose Fonseca <jfonseca@vmware.com>
Date:   Thu Nov 14 12:03:49 2019 +0000

    lib/trace: Mark a few more D3D11 calls as verbose.

commit 78078e9025efa898f6e5402e306abdd205c7b2c0
Author: Jose Fonseca <jfonseca@vmware.com>
Date:   Mon Nov 11 11:19:55 2019 +0000

    travis: Explicitly set Python3_EXECUTABLE.

    Somehow auto-detection is not working on Travis builder images.

commit 4b97675fdf5137874d92b8af18c574a388c4d1cd
Author: Jeff Gilbert <jdashg@gmail.com>
Date:   Thu Jun 20 13:27:00 2019 -0700

    Use Python3_EXECUTABLE in cmake.

    v2: Keep old behavior for older CMake; plus tie a few loose-ends -- Jose

commit 8d00c5e9321b3261334d4f12377a6e018a45bf2c
Author: Charlie Birks <charlie@daftgames.net>
Date:   Sun Oct 13 14:19:07 2019 +0100

    Support tracing PBOs on GLES 3.0

commit c1cf5c0b342c83daed507b4d41e1372a4da93309
Author: Jose Fonseca <jfonseca@vmware.com>
Date:   Fri Oct 18 09:43:31 2019 +0100

    dxgiretrace: Handle D3D11CreateDevice with null parameters.

    D3D11CreateDevice can return E_FALSE when pointers are null.  Apps seem
    to use this to check supported feature level.  This change makes
    d3dretrace more robust against that.

commit 34394026d081050a3c1dd1d93a8ad2ae889ad031
Author: Jose Fonseca <jfonseca@vmware.com>
Date:   Wed Sep 25 13:20:19 2019 +0100

    specs: Fix Create/Get methods.

BUG=b:173260779
TEST=apitrace replay glxgears.trace

Change-Id: Iad1c2de0f95834f9bc7a507d620696a96014eaa4
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/apitrace/+/2538970
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Commit-Queue: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Ilja H. Friedel <ihf@chromium.org>