commit | 2eaa7ae986afea881f3d9e54e5509f93effaffec | [log] [tgz] |
---|---|---|
author | Amin Hassani <ahassani@google.com> | Mon Sep 11 21:37:38 2017 |
committer | chrome-bot <chrome-bot@chromium.org> | Tue Sep 12 11:19:33 2017 |
tree | 28eb272fda90353d8bc582f2bf164d3782e47f2b | |
parent | 2bdf4d6b2deb64398ac9c1850210bf9fee662153 [diff] |
p2p_ShareFiles: Fix file write race condition. Somewhere at the end of this test, a 10 byte files is created and assumed the p2p-server shares the file (with correct size) back to the simulator. But on some boards this may flake when the p2p-server shares the file info before its content is written to disk. This causes the test fail because the expected file on the DUT was not found. This patch wraps the call to get_peer_files() in another function to check for the correctness of the file name and size before complaining. However, if the file is never shared (due to some unknown problem), the simulator does not raise an exception on timeout. This additional problem is outside the scope of this bug. BUG=chromium:762579 TEST=test_that --board=nyan_kitty chromeos4-row13-rack1-host3.cros p2p_ShareFiles Change-Id: I3ea8bb5ba3f19f0ba5bb863ee4d67b7bf3fbc939 Reviewed-on: https://chromium-review.googlesource.com/660783 Commit-Ready: Shyh-In Hwang <josephsih@chromium.org> Tested-by: Amin Hassani <ahassani@chromium.org> Reviewed-by: Shuqian Zhao <shuqianz@chromium.org>
Autotest is a framework for fully automated testing. It was originally designed to test the Linux kernel, and expanded by the Chrome OS team to validate complete system images of Chrome OS and Android.
Autotest is composed of a number of modules that will help you to do stand alone tests or setup a fully automated test grid, depending on what you are up to. A non extensive list of functionality is:
A body of code to run tests on the device under test. In this setup, test logic executes on the machine being tested, and results are written to files for later collection from a development machine or lab infrastructure.
A body of code to run tests against a remote device under test. In this setup, test logic executes on a development machine or piece of lab infrastructure, and the device under test is controlled remotely via SSH/adb/some combination of the above.
Developer tools to execute one or more tests. test_that
for Chrome OS and test_droid
for Android allow developers to run tests against a device connected to their development machine on their desk. These tools are written so that the same test logic that runs in the lab will run at their desk, reducing the number of configurations under which tests are run.
Lab infrastructure to automate the running of tests. This infrastructure is capable of managing and running tests against thousands of devices in various lab environments. This includes code for both synchronous and asynchronous scheduling of tests. Tests are run against this hardware daily to validate every build of Chrome OS.
Infrastructure to set up miniature replicas of a full lab. A full lab does entail a certain amount of administrative work which isn't appropriate for a work group interested in automated tests against a small set of devices. Since this scale is common during device bringup, a special setup, called Moblab, allows a natural progressing from desk -> mini lab -> full lab.
See the guides to test_that
and test_droid
:
See the best practices guide, existing tests, and comments in the code.
git clone https://chromium.googlesource.com/chromiumos/third_party/autotest
See the coding style guide for guidance on submitting patches.