| commit | 01d4fc123b3631b1628bc86f9271e278b0e34634 | [log] [tgz] |
|---|---|---|
| author | Tim Van Patten <timvp@google.com> | Fri Sep 16 17:04:39 2022 |
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Sep 23 17:10:04 2022 |
| tree | c0c663b809f2677dd18231c92a2e037fb2af65fa | |
| parent | ac21c515c624a026b56b3e8128e9d6efc7950e82 [diff] |
daisydog: Convert all prints to printf() Daisydog is currently using a mix of printf, fprintf, puts and putchar. This CL converts everything to printf for consistency. It's suspected this also reduces the chance that buffered writes aren't being flushed (e.g., putchar), which helps developers when debugging. BUG=b:223617872 TEST=tast run <IP> crash.WatchdogCrash TEST=test_that <IP> platform_HWwatchdog Change-Id: I83145fc92e5303f46a423420beff962a20aa5df5 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/daisydog/+/3902245 Tested-by: Tim Van Patten <timvp@google.com> Reviewed-by: Grant Grundler <grundler@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Raul Rangel <rrangel@chromium.org>
GPL Code is copied with explicit permission from Daniel Widyanto:
http://embeddedfreak.wordpress.com/2010/08/23/howto-use-linux-watchdog/
The project name is based on Samsung's “daisy” reference board design and I liked this quote from the daisy dog FAQ:
Daisy Dogs are not persnickety little ankle biters
When this daisydog doesn't run, the machine should reset. :)
An alternative code to start with would have been:
https://dev.openwrt.org/ticket/2270
The watchdog project is alot more complicated than what the Chromium OS project needs.