| commit | 30425dbef56bc29836aac9a31fdc119d373d2642 | [log] [tgz] |
|---|---|---|
| author | mukesh agrawal <quiche@chromium.org> | Tue Apr 15 00:55:50 2014 |
| committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | Wed Apr 16 11:14:34 2014 |
| tree | 44d656bf2b782c3b711738dd16edd9b68f6cbc85 | |
| parent | 88d6d481f413e996206ee8fba06ed27292481495 [diff] |
dhcpcd: be more permissive on NAKs Previously, we'd reject NAKs that did not include a server ID. Since we'd only check that a server ID was present, but did not validate it against any stored state, the test is merely pedantic. Moreover, some DHCP servers (e.g. OpenBSD 4.6) send NAK messages without a server ID. [1] To improve compatibility with real-world DHCP servers, drop the check for the presence of a server ID. BUG=chrome-os-partner:27930 TEST=network_DhcpNak [1] http://openbsd.7691.n7.nabble.com/dhcpd-omits-server-id-option-54-in-NAK-to-a-RENEW-request-td41044.html Change-Id: I35c2f6141b08f2760798abc121da140787228a3a Reviewed-on: https://chromium-review.googlesource.com/194972 Tested-by: mukesh agrawal <quiche@chromium.org> Reviewed-by: Paul Stewart <pstew@chromium.org> Commit-Queue: mukesh agrawal <quiche@chromium.org>