Google Git
Sign in
chromium / chromiumos / third_party / flashrom / 1118a580327d4e415b7604af3ac16c3d61d87286
commit1118a580327d4e415b7604af3ac16c3d61d87286[log] [tgz]
authorBrian J. Nemec <bnemec@chromium.org>Wed Feb 05 02:26:02 2020
committerCommit Bot <commit-bot@chromium.org>Thu Feb 06 22:38:01 2020
treeab528866421a7c1dedb3fc2a7f4e0f014b94491d
parentda496dc933855cde1fa518eafddf0b34afbf7b34 [diff]
raid_debug_spi.c: USB SPI Protocol Retry Mechanism

Adds support for a retry mechanism in Flashrom. This overcomes a problem
with the ServoMicro where USB packets can be ack'd by the device without
triggering interrupts or loading data into the USB endpoints. The retry
mechanism attempts the USB read 3 times before reattempting the write call
to avoid performing multiple SPI transfers due to a USB problem. This
process repeats 3 times before we return the last error code. Intermediary
problems are reported in the status code.

BUG=chromium:952494
BRANCH=none
TEST=Manual testing of ServoMicro and Flashrom when performing
reads, writes, and verifications of the EC firmware on Nami.
* sudo emerge sys-apps/flashrom
* sudo flashrom --programmer raiden_debug_spi -v bios_good.bin
Tests of the retry mechanism were performed with a modified USB
cable with data lines exposed for probing and tampering.

Change-Id: I1a883661a1a1c299582da612c7f24cc6481c16da
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/flashrom/+/2038271
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Commit-Queue: Brian Nemec <bnemec@chromium.org>
Commit-Queue: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
Tested-by: Brian Nemec <bnemec@chromium.org>
1 file changed
tree: ab528866421a7c1dedb3fc2a7f4e0f014b94491d
  1. Documentation/
  2. tests/
  3. util/
  4. .gitattributes
  5. .gitignore
  6. 82802ab.c
  7. action_descriptor.c
  8. action_descriptor.h
  9. amd_imc.c
  10. archtest.c
  11. at45db.c
  12. atahpt.c
  13. big_lock.c
  14. big_lock.h
  15. bitbang_spi.c
  16. board_enable.c
  17. buspirate_spi.c
  18. cbtable.c
  19. chipdrivers.h
  20. chipset_enable.c
  21. cli_classic.c
  22. cli_common.c
  23. cli_output.c
  24. COPYING
  25. coreboot_tables.h
  26. cros_ec.c
  27. cros_ec.h
  28. cros_ec_commands.h
  29. cros_ec_dev.c
  30. cros_ec_dev.h
  31. cros_ec_i2c.c
  32. cros_ec_lock.c
  33. cros_ec_lock.h
  34. cros_ec_lpc.c
  35. custom_baud.c
  36. custom_baud.h
  37. dediprog.c
  38. dmi.c
  39. drkaiser.c
  40. dummyflasher.c
  41. edi.c
  42. edi.h
  43. ene.h
  44. ene_lpc.c
  45. fdtmap.c
  46. fdtmap.h
  47. file.c
  48. file.h
  49. file_lock.c
  50. flash.h
  51. flashchips.c
  52. flashchips.h
  53. flashchips_hwseq.c
  54. flashrom.8.tmpl
  55. flashrom.c
  56. fmap.c
  57. fmap.h
  58. ft2232_spi.c
  59. gfxnvidia.c
  60. helpers.c
  61. hwaccess.c
  62. hwaccess.h
  63. ich_descriptors.c
  64. ich_descriptors.h
  65. ichspi.c
  66. internal.c
  67. ipc_lock.h
  68. it85spi.c
  69. it87spi.c
  70. jedec.c
  71. layout.c
  72. layout.h
  73. libflashrom.h
  74. linux_i2c.c
  75. linux_mtd.c
  76. linux_spi.c
  77. locks.h
  78. m29f400bt.c
  79. Makefile
  80. mcp6x_spi.c
  81. mec1308.c
  82. nic3com.c
  83. nicintel.c
  84. nicintel_spi.c
  85. nicnatsemi.c
  86. nicrealtek.c
  87. ogp_spi.c
  88. opaque.c
  89. os.h
  90. OWNERS
  91. pcidev.c
  92. physmap.c
  93. platform.h
  94. power.c
  95. power.h
  96. PRESUBMIT.cfg
  97. print.c
  98. print_wiki.c
  99. processor_enable.c
  100. programmer.c
  101. programmer.h
  102. raiden_debug_spi.c
  103. rayer_spi.c
  104. README.chromiumos
  105. s25f.c
  106. satamv.c
  107. satasii.c
  108. sb600spi.c
  109. search.c
  110. search.h
  111. serial.c
  112. serprog.c
  113. serprog.h
  114. sharplhf00l04.c
  115. spi.c
  116. spi.h
  117. spi25.c
  118. spi25_statusreg.c
  119. spi4ba.c
  120. spi4ba.h
  121. sst28sf040.c
  122. sst49lfxxxc.c
  123. sst_fwhub.c
  124. stm50flw0x0x.c
  125. udelay.c
  126. usb_device.c
  127. usb_device.h
  128. usbdev.c
  129. w29ee011.c
  130. w39.c
  131. wbsio_spi.c
  132. wpce775x.c
  133. writeprotect.c
  134. writeprotect.h