BACKPORT: cli_classic: Tidy up some repeated handling patterns into funcs
Introduce cli_classic_single_operation() to consolidate the repeating
pattern of multiple CLI operations at once. Also modify
cli_classic_abort_usage() to take an optional error abort string and
print it to stderr, this allows for trimming a few more lines off the
V.2: A few fixes upon review:
- Trim off some unnecessary braces for single line branches.
- Pass 'operation_specified' by reference.
- Rename a function.
V.3: Fix print order of cli_classic_abort_usage().
Original-Signed-off-by: Edward O'Callaghan <firstname.lastname@example.org>
Original-Tested-by: build bot (Jenkins) <email@example.com>
Original-Reviewed-by: Nico Huber <firstname.lastname@example.org>
(cherry picked from commit 8b60fc7a5bac409f8a4e0648f1fba51aa3497afb)
This brings over cli_classic_single_operation() and the changes
to cli_classic_abort_usage() from the upstream patch. However
cli_classic.c has significantly diverged from upstream, so not
all changes to their call sites correspond to the original patch.
Tested-by: Nikolai Artemiev <email@example.com>
Signed-off-by: Nikolai Artemiev <firstname.lastname@example.org>
Reviewed-by: Edward O'Callaghan <email@example.com>
Tested-by: Edward O'Callaghan <firstname.lastname@example.org>
Commit-Queue: Edward O'Callaghan <email@example.com>
1 file changed