Google Git
Sign in
chromium / chromiumos / third_party / flashrom / refs/heads/release-R30-4537.B
commit4169bc889b25f695c48de8379fd44785c486661d[log] [tgz]
authorVadim Bendebury <vbendeb@chromium.org>Thu Sep 19 20:56:32 2013
committerchrome-internal-fetch <chrome-internal-fetch@google.com>Sat Sep 21 02:17:24 2013
tree2b3eb2ff79e543bdb733bada8a0dd4a2ecb8778f
parent2c221a4c641351bea84c7ae1eed9701a2905904b [diff]
Fix use of uninitialized local variable in gec_jump_copy()

The code in get_jump_copy() uses a local structure variable, which is
never initialized - a leftover of a previous fix/clean up. This causes
interesting side effects depending on the stack contents at the moment
the function is invoked. In particular enabling verbose mode makes
programming succeed, while it always fails when verbose debug is
disabled.

A bigger question is why this package tolerates warnings when
building, this will have to be fixed separately.

BRANCH=r30
BUG=chromium:295082
TEST=manual

   . running the following command on pit does not fail anymore:

   $ ./flashrom -p ec -w ec.25.bin && ./flashrom -p ec -w ec.52.bin

   before this fix it would always fail on the very first attempt.

Change-Id: If77b0c166045adeee0779572260776eec832403f
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Previous-Reviewed-on: https://chromium-review.googlesource.com/170029
(cherry picked from commit 9fa26e8e144e8e9fdfc707ec5e765551dd5f8393)
Reviewed-on: https://chromium-review.googlesource.com/170109
Reviewed-by: David Hendrix <dhendrix@chromium.org>
1 file changed
tree: 2b3eb2ff79e543bdb733bada8a0dd4a2ecb8778f
  1. Documentation/
  2. tests/
  3. util/
  4. .gitignore
  5. 82802ab.c
  6. a25.c
  7. arch.h
  8. at25.c
  9. atahpt.c
  10. big_lock.c
  11. big_lock.h
  12. bitbang_spi.c
  13. board_enable.c
  14. buspirate_spi.c
  15. cbtable.c
  16. chipdrivers.h
  17. chipset_enable.c
  18. cli_classic.c
  19. cli_mfg.c
  20. cli_output.c
  21. COPYING
  22. coreboot_tables.h
  23. csem.c
  24. csem.h
  25. dediprog.c
  26. dmi.c
  27. drkaiser.c
  28. dummyflasher.c
  29. ene_lpc.c
  30. fdtmap.c
  31. fdtmap.h
  32. file.c
  33. file.h
  34. flash.h
  35. flashchips.c
  36. flashchips.h
  37. flashrom.8
  38. flashrom.c
  39. fmap.c
  40. fmap.h
  41. ft2232_spi.c
  42. gec.c
  43. gec.h
  44. gec_dev.c
  45. gec_dev.h
  46. gec_ec_commands.h
  47. gec_i2c.c
  48. gec_lock.c
  49. gec_lock.h
  50. gec_lpc.c
  51. gfxnvidia.c
  52. hwaccess.c
  53. hwaccess.h
  54. ich_descriptors.c
  55. ich_descriptors.h
  56. ichspi.c
  57. internal.c
  58. ipc_lock.c
  59. ipc_lock.h
  60. it85spi.c
  61. it87spi.c
  62. jedec.c
  63. layout.c
  64. layout.h
  65. linux_i2c.c
  66. linux_spi.c
  67. locks.h
  68. m29f400bt.c
  69. Makefile
  70. mcp6x_spi.c
  71. mec1308.c
  72. nic3com.c
  73. nicintel.c
  74. nicintel_spi.c
  75. nicnatsemi.c
  76. nicrealtek.c
  77. ogp_spi.c
  78. opaque.c
  79. pcidev.c
  80. physmap.c
  81. pm49fl00x.c
  82. power.c
  83. power.h
  84. PRESUBMIT.cfg
  85. print.c
  86. print_wiki.c
  87. processor_enable.c
  88. programmer.c
  89. programmer.h
  90. rayer_spi.c
  91. README
  92. README.chromiumos
  93. satamv.c
  94. satasii.c
  95. sb600spi.c
  96. search.c
  97. search.h
  98. serial.c
  99. serprog.c
  100. sharplhf00l04.c
  101. spi.c
  102. spi.h
  103. spi25.c
  104. sst28sf040.c
  105. sst49lfxxxc.c
  106. sst_fwhub.c
  107. stm50flw0x0x.c
  108. udelay.c
  109. w29ee011.c
  110. w39.c
  111. wbsio_spi.c
  112. wpce775x.c
  113. writeprotect.c
  114. writeprotect.h