commit 0da35b451529936b6ca8344177dbcfe5b9c5539f
author hscham <hscham@chromium.org> Tue Apr 05 02:53:16 2022
committer Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Apr 06 08:04:00 2022
tree faf17261fcf328a898e89b8ce79d648333087e07
parent ef31fc0592da44084f53ccde05b7ec2b14639b27

huddly-updater: replace FALLTHROUGH by C++17 attribute [[fallthrough]]

The deprecated macro will be removed from libchrome r958576.

BUG=b:211560276
TEST=FEATURES=test emerge-endeavour huddly-updater

Change-Id: I0d0443f7ae09b1511f14b93e5643609256519ae2
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/huddly-updater/+/3571143
Tested-by: Grace Cham <hscham@chromium.org>
Reviewed-by: Kyle Williams <kdgwill@chromium.org>
Commit-Queue: Grace Cham <hscham@chromium.org>

src/common/messagepack/messagepack.cc

diff --git a/src/common/messagepack/messagepack.cc b/src/common/messagepack/messagepack.cc
index a619c93..3b16b29 100644
--- a/src/common/messagepack/messagepack.cc
+++ b/src/common/messagepack/messagepack.cc
@@ -3,7 +3,6 @@
 // found in the LICENSE file.
 #include "messagepack.h"
 
-#include <base/compiler_specific.h>
 #include <base/logging.h>
 
 // Macro for telling -Wimplicit-fallthrough that a fallthrough is intentional.
@@ -149,21 +148,21 @@
       *out = object_.via.i64;
       return true;
     case MSGPACK_OBJECT_FLOAT32:
-      FALLTHROUGH;
+      [[fallthrough]];
     case MSGPACK_OBJECT_FLOAT:
-      FALLTHROUGH;
+      [[fallthrough]];
     case MSGPACK_OBJECT_BOOLEAN:
-      FALLTHROUGH;
+      [[fallthrough]];
     case MSGPACK_OBJECT_NIL:
-      FALLTHROUGH;
+      [[fallthrough]];
     case MSGPACK_OBJECT_STR:
-      FALLTHROUGH;
+      [[fallthrough]];
     case MSGPACK_OBJECT_ARRAY:
-      FALLTHROUGH;
+      [[fallthrough]];
     case MSGPACK_OBJECT_MAP:
-      FALLTHROUGH;
+      [[fallthrough]];
     case MSGPACK_OBJECT_BIN:
-      FALLTHROUGH;
+      [[fallthrough]];
     case MSGPACK_OBJECT_EXT:
       return false;
   }
@@ -179,21 +178,21 @@
       *out = static_cast<uint64_t>(object_.via.i64);
       return true;
     case MSGPACK_OBJECT_FLOAT32:
-      FALLTHROUGH;
+      [[fallthrough]];
     case MSGPACK_OBJECT_FLOAT:
-      FALLTHROUGH;
+      [[fallthrough]];
     case MSGPACK_OBJECT_BOOLEAN:
-      FALLTHROUGH;
+      [[fallthrough]];
     case MSGPACK_OBJECT_NIL:
-      FALLTHROUGH;
+      [[fallthrough]];
     case MSGPACK_OBJECT_STR:
-      FALLTHROUGH;
+      [[fallthrough]];
     case MSGPACK_OBJECT_ARRAY:
-      FALLTHROUGH;
+      [[fallthrough]];
     case MSGPACK_OBJECT_MAP:
-      FALLTHROUGH;
+      [[fallthrough]];
     case MSGPACK_OBJECT_BIN:
-      FALLTHROUGH;
+      [[fallthrough]];
     case MSGPACK_OBJECT_EXT:
       return false;
   }
@@ -209,22 +208,22 @@
       *out = static_cast<double>(object_.via.i64);
       return true;
     case MSGPACK_OBJECT_FLOAT32:
-      FALLTHROUGH;
+      [[fallthrough]];
     case MSGPACK_OBJECT_FLOAT:
       *out = object_.via.f64;
       return true;
     case MSGPACK_OBJECT_BOOLEAN:
-      FALLTHROUGH;
+      [[fallthrough]];
     case MSGPACK_OBJECT_NIL:
-      FALLTHROUGH;
+      [[fallthrough]];
     case MSGPACK_OBJECT_STR:
-      FALLTHROUGH;
+      [[fallthrough]];
     case MSGPACK_OBJECT_ARRAY:
-      FALLTHROUGH;
+      [[fallthrough]];
     case MSGPACK_OBJECT_MAP:
-      FALLTHROUGH;
+      [[fallthrough]];
     case MSGPACK_OBJECT_BIN:
-      FALLTHROUGH;
+      [[fallthrough]];
     case MSGPACK_OBJECT_EXT:
       return false;
   }