)]}' { "commit": "cc6db7c33b3cbdb0a147edb4bf0bbcdf87e94557", "tree": "277785f0e0a964de65b8d7b5df4bf6e5dd22b625", "parents": [ "66cdcb8c9632394207d4cd32e191d87d75184931" ], "author": { "name": "Brian Norris", "email": "briannorris@chromium.org", "time": "Thu Dec 05 21:18:27 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Dec 05 22:09:00 2019" }, "message": "PRESUBMIT: exclude binaries from license check\n\nThe license check isn\u0027t going to find much of any valid text in these,\nlet alone text that matches our expected license headers. We keep a\nLICENSE file in here instead. Disable the license check for the bin/\ndirectory.\n\nFun fact: being fruitless doesn\u0027t stop pre-upload.py from spending a ton\nof time doing regex comparisons on these binaries. For example, I had to\nleave for lunch while Python was churning on a regex search over the 52\nMB file in https://crrev.com/c/1954430 !\n\nBUG\u003dnone\nTEST\u003d.../src/repohooks/pre-upload.py\n\nChange-Id: If37c8f8e245dd987032302338eb0a492d52af143\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/intel-wifi-fw-dump/+/1954435\nTested-by: Brian Norris \u003cbriannorris@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Brian Norris \u003cbriannorris@chromium.org\u003e\n", "tree_diff": [ { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "026a692f0d1541a1bd2067c631ba2319b2d0ea23", "new_mode": 33188, "new_path": "PRESUBMIT.cfg" } ] }