BACKPORT: wifi: cfg80211: fix BSS refcounting bugs
There are multiple refcounting bugs related to multi-BSSID:
- In bss_ref_get(), if the BSS has a hidden_beacon_bss, then
the bss pointer is overwritten before checking for the
transmitted BSS, which is clearly wrong. Fix this by using
the bss_from_pub() macro.
- In cfg80211_bss_update() we copy the transmitted_bss pointer
from tmp into new, but then if we release new, we'll unref
it erroneously. We already set the pointer and ref it, but
need to NULL it since it was copied from the tmp data.
- In cfg80211_inform_single_bss_data(), if adding to the non-
transmitted list fails, we unlink the BSS and yet still we
return it, but this results in returning an entry without
a reference. We shouldn't return it anyway if it was broken
enough to not get added there.
This fixes CVE-2022-42720.
TEST=Basic Wifi sanity like bringing up AP, mesh and STA mode and connect a STA, mesh and connect to AP and verified the ping.
(cherry picked from commit 0b7808818cb9df6680f98996b8e9a439fa7bcc2f)
Reported-by: Sönke Huster <email@example.com>
Tested-by: Sönke Huster <firstname.lastname@example.org>
Fixes: a3584f56de1c ("cfg80211: Properly track transmitting and non-transmitting BSS")
Signed-off-by: Johannes Berg <email@example.com>
Signed-off-by: Ganesh Babu Jothiram <firstname.lastname@example.org>
Signed-off-by: Maharaja Kennadyrajan <email@example.com>
Tested-by: Julan Hsu <firstname.lastname@example.org>
Reviewed-by: Julan Hsu <email@example.com>
Commit-Queue: Julan Hsu <firstname.lastname@example.org>
1 file changed