commit | 1cba48fc41f6e23c63608b9f38ff698754c70d20 | [log] [tgz] |
---|---|---|
author | Eizan Miyamoto <eizan@chromium.org> | Tue Jun 29 04:20:27 2021 |
committer | Google Cont Rebase <goog-rebase-dev@semihalf.com> | Wed Aug 25 10:50:49 2021 |
tree | 5b4358c889cfe3ad7216d557beb28ca447699891 | |
parent | 6a344158eae0389c4b5dfa87165711ccc2119e65 [diff] |
CHROMIUM: kernelconfig sets CROSS_COMPILE Without this, when rebuilding kernel config for aarch64 in chromeos-kernel-upstream, as-version.sh is run with the following args: as-version.sh aarch64-cros-linux-gnu-clang -no-integrated-as \ --prefix=/usr/bin/ -Werror=unknown-warning-option and the following line fails: set -- $(LC_ALL=C "$@" -Wa,--version -c -x assembler /dev/null \ -o /dev/null 2>/dev/null) causing this error: "... unknown assembler invoked" This is because /usr/bin/as is invoked (instead of the cross compile version) because --prefix=/usr/bin is specified (as opposed to the correct "--prefix=/usr/bin/${CROSS_COMPILE}") This all started in commit ba64beb17493a ("kbuild: check the minimum assembler version in Kconfig") which landed in 5.12 Note: this was submitted as https://crrev.com/c/2993714 by accident wihout running style checks. BUG=b:190342046 TEST=run chromeos/scripts/kernelconfig olddefconfig Signed-off-by: Eizan Miyamoto <eizan@chromium.org> Change-Id: Ib09150dd8239bd8d139956b9ed0806a940ee1120 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/3026231 Reviewed-by: Lukasz Majczak <lmajczak@google.com> Reviewed-by: Sonny Rao <sonnyrao@chromium.org>
BEST: Make all of your changes to upstream Linux. If appropriate, backport to the stable releases. These patches will be merged automatically in the corresponding common kernels. If the patch is already in upstream Linux, post a backport of the patch that conforms to the patch requirements below.
EXPORT_SYMBOL_GPL()
require an in-tree modular driver that uses the symbol -- so include the new driver or changes to an existing driver in the same patchset as the export.LESS GOOD: Develop your patches out-of-tree (from an upstream Linux point-of-view). Unless these are fixing an Android-specific bug, these are very unlikely to be accepted unless they have been coordinated with kernel-team@android.com. If you want to proceed, post a patch that conforms to the patch requirements below.
scripts/checkpatch.pl
UPSTREAM:
, BACKPORT:
, FROMGIT:
, FROMLIST:
, or ANDROID:
.Change-Id:
tag (see https://gerrit-review.googlesource.com/Documentation/user-changeid.html)Bug:
tag.Signed-off-by:
tag by the author and the submitterAdditional requirements are listed below based on patch type
UPSTREAM:
, BACKPORT:
UPSTREAM:
.(cherry picked from commit ...)
lineimportant patch from upstream This is the detailed description of the important patch Signed-off-by: Fred Jones <fred.jones@foo.org>
- then Joe Smith would upload the patch for the common kernel as
UPSTREAM: important patch from upstream This is the detailed description of the important patch Signed-off-by: Fred Jones <fred.jones@foo.org> Bug: 135791357 Change-Id: I4caaaa566ea080fa148c5e768bb1a0b6f7201c01 (cherry picked from commit c31e73121f4c1ec41143423ac6ce3ce6dafdcec1) Signed-off-by: Joe Smith <joe.smith@foo.org>
BACKPORT:
instead of UPSTREAM:
.UPSTREAM:
(cherry picked from commit ...)
lineBACKPORT: important patch from upstream This is the detailed description of the important patch Signed-off-by: Fred Jones <fred.jones@foo.org> Bug: 135791357 Change-Id: I4caaaa566ea080fa148c5e768bb1a0b6f7201c01 (cherry picked from commit c31e73121f4c1ec41143423ac6ce3ce6dafdcec1) [joe: Resolved minor conflict in drivers/foo/bar.c ] Signed-off-by: Joe Smith <joe.smith@foo.org>
FROMGIT:
, FROMLIST:
,FROMGIT:
(cherry picked from commit <sha1> <repo> <branch>)
. This must be a stable maintainer branch (not rebased, so don't use linux-next
for example).BACKPORT: FROMGIT:
important patch from upstream This is the detailed description of the important patch Signed-off-by: Fred Jones <fred.jones@foo.org>
- then Joe Smith would upload the patch for the common kernel as
FROMGIT: important patch from upstream This is the detailed description of the important patch Signed-off-by: Fred Jones <fred.jones@foo.org> Bug: 135791357 (cherry picked from commit 878a2fd9de10b03d11d2f622250285c7e63deace https://git.kernel.org/pub/scm/linux/kernel/git/foo/bar.git test-branch) Change-Id: I4caaaa566ea080fa148c5e768bb1a0b6f7201c01 Signed-off-by: Joe Smith <joe.smith@foo.org>
FROMLIST:
Link:
tag with a link to the submittal on lore.kernel.orgBug:
tag with the Android bug (required for patches not accepted into a maintainer tree)BACKPORT: FROMLIST:
FROMLIST: important patch from upstream This is the detailed description of the important patch Signed-off-by: Fred Jones <fred.jones@foo.org> Bug: 135791357 Link: https://lore.kernel.org/lkml/20190619171517.GA17557@someone.com/ Change-Id: I4caaaa566ea080fa148c5e768bb1a0b6f7201c01 Signed-off-by: Joe Smith <joe.smith@foo.org>
ANDROID:
ANDROID:
Fixes:
tag that cites the patch with the bugANDROID: fix android-specific bug in foobar.c This is the detailed description of the important fix Fixes: 1234abcd2468 ("foobar: add cool feature") Change-Id: I4caaaa566ea080fa148c5e768bb1a0b6f7201c01 Signed-off-by: Joe Smith <joe.smith@foo.org>
ANDROID:
Bug:
tag with the Android bug (required for android-specific features)