Revert iwl_trans_sync_nmi definition and usage
This reverts iwl_trans_sync_nmi introduction and usage that crept
in during a manul merge.
Reason for revert: b/130651313
iwl_trans_sync_nmi assumes that MSI-X is enabled and tries to read a
register that is not part of iomem (CSR_MSIX_HW_INT_CAUSES_AD).
MSI-X is not enabled on StP2 and WP2 devices.
BUG=b:130651313, chromium:951645
TEST=build, boot on falco_li, run wifi_matfunc for sanity check,
manually test NIC removal and rescanning via pcie sysfs paths works,
and try the following sequence from briannorris@google.com that triggers
a ramoops with the faulty MSI-X reading code:
$ cd /sys
$ nmi_file_name=`find . -name "fw_nmi"`
$ nmi_dir=`dirname ${nmi_file_name}`
$ cd nmi_dir && while true; do echo 1 > fw_nmi; sleep 5; done
With $CL applied, the driver still hangs, but there is no system crash or
reboot.
Signed-off-by: Kirtika Ruchandani <kirtika@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1570549
Reviewed-by: Brian Norris <briannorris@chromium.org>
(cherry picked with manual edits from commit 975e2628101b2dacd77be4f9e4119639954522c8)
Change-Id: I77d602a8b08081d72e4cd355ab296e943a7a67f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1595946
5 files changed
