commit | ab4c5d2a84017709cbf4ad690445ffc45ad82625 | [log] [tgz] |
---|---|---|
author | Bartłomiej Grzesik <bag@semihalf.com> | Fri Jan 21 12:17:59 2022 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Jan 28 18:38:19 2022 |
tree | 8b465703337a6076c90ed4082508912e7426ea42 | |
parent | df1b8f1ab2fe61012ccc336a3d7371ac274bb570 [diff] |
CHROMIUM: media: virtio: return EINVAL if buffer type passed to S/G_FMT is not multiplanar virtio-video driver at the moment only supports multiplanar buffer types. In VIDIOC_S_FMT and VIDIOC_G_FMT, V4L2_TYPE_IS_OUTPUT macro is used to distinguish OUTPUT and CAPTURE buffers. This leads to those ioctls treating V4L2_BUF_TYPE_VIDEO_CAPTURE the same as V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE (same problem applies for OUTPUT types). This is incorrect and causes v4l2-compliance to fail. This patch returns EINVAL if passed buffer type is not multiplanar. Signed-off-by: Bartłomiej Grzesik <bag@semihalf.com> BUG=b:160440787 TEST=v4l2-compliance -d /dev/video0 TEST=v4l2-compliance -d /dev/video1 TEST=tast run eve arc.Video* Change-Id: I3fd19908cb615e218d1edb3ac229b2fdf9fb36a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/3401973 Reviewed-by: Alexandre Courbot <acourbot@chromium.org> Tested-by: Bartłomiej Grzesik <bag@semihalf.com> Commit-Queue: Marcin Wojtas <mwojtas@google.com>
BEST: Make all of your changes to upstream Linux. If appropriate, backport to the stable releases. These patches will be merged automatically in the corresponding common kernels. If the patch is already in upstream Linux, post a backport of the patch that conforms to the patch requirements below.
EXPORT_SYMBOL_GPL()
require an in-tree modular driver that uses the symbol -- so include the new driver or changes to an existing driver in the same patchset as the export.LESS GOOD: Develop your patches out-of-tree (from an upstream Linux point-of-view). Unless these are fixing an Android-specific bug, these are very unlikely to be accepted unless they have been coordinated with kernel-team@android.com. If you want to proceed, post a patch that conforms to the patch requirements below.
script/checkpatch.pl
UPSTREAM:
, BACKPORT:
, FROMGIT:
, FROMLIST:
, or ANDROID:
.Change-Id:
tag (see https://gerrit-review.googlesource.com/Documentation/user-changeid.html)Bug:
tag.Signed-off-by:
tag by the author and the submitterAdditional requirements are listed below based on patch type
UPSTREAM:
, BACKPORT:
UPSTREAM:
.(cherry picked from commit ...)
lineimportant patch from upstream This is the detailed description of the important patch Signed-off-by: Fred Jones <fred.jones@foo.org>
- then Joe Smith would upload the patch for the common kernel as
UPSTREAM: important patch from upstream This is the detailed description of the important patch Signed-off-by: Fred Jones <fred.jones@foo.org> Bug: 135791357 Change-Id: I4caaaa566ea080fa148c5e768bb1a0b6f7201c01 (cherry picked from commit c31e73121f4c1ec41143423ac6ce3ce6dafdcec1) Signed-off-by: Joe Smith <joe.smith@foo.org>
BACKPORT:
instead of UPSTREAM:
.UPSTREAM:
(cherry picked from commit ...)
lineBACKPORT: important patch from upstream This is the detailed description of the important patch Signed-off-by: Fred Jones <fred.jones@foo.org> Bug: 135791357 Change-Id: I4caaaa566ea080fa148c5e768bb1a0b6f7201c01 (cherry picked from commit c31e73121f4c1ec41143423ac6ce3ce6dafdcec1) [joe: Resolved minor conflict in drivers/foo/bar.c ] Signed-off-by: Joe Smith <joe.smith@foo.org>
FROMGIT:
, FROMLIST:
,FROMGIT:
(cherry picked from commit <sha1> <repo> <branch>)
. This must be a stable maintainer branch (not rebased, so don't use linux-next
for example).BACKPORT: FROMGIT:
important patch from upstream This is the detailed description of the important patch Signed-off-by: Fred Jones <fred.jones@foo.org>
- then Joe Smith would upload the patch for the common kernel as
FROMGIT: important patch from upstream This is the detailed description of the important patch Signed-off-by: Fred Jones <fred.jones@foo.org> Bug: 135791357 (cherry picked from commit 878a2fd9de10b03d11d2f622250285c7e63deace https://git.kernel.org/pub/scm/linux/kernel/git/foo/bar.git test-branch) Change-Id: I4caaaa566ea080fa148c5e768bb1a0b6f7201c01 Signed-off-by: Joe Smith <joe.smith@foo.org>
FROMLIST:
Link:
tag with a link to the submittal on lore.kernel.orgBug:
tag with the Android bug (required for patches not accepted into a maintainer tree)BACKPORT: FROMLIST:
FROMLIST: important patch from upstream This is the detailed description of the important patch Signed-off-by: Fred Jones <fred.jones@foo.org> Bug: 135791357 Link: https://lore.kernel.org/lkml/20190619171517.GA17557@someone.com/ Change-Id: I4caaaa566ea080fa148c5e768bb1a0b6f7201c01 Signed-off-by: Joe Smith <joe.smith@foo.org>
ANDROID:
ANDROID:
Fixes:
tag that cites the patch with the bugANDROID: fix android-specific bug in foobar.c This is the detailed description of the important fix Fixes: 1234abcd2468 ("foobar: add cool feature") Change-Id: I4caaaa566ea080fa148c5e768bb1a0b6f7201c01 Signed-off-by: Joe Smith <joe.smith@foo.org>
ANDROID:
Bug:
tag with the Android bug (required for android-specific features)