| commit | 12d6850827f5d20121293354e968fa0443b86d32 | [log] [tgz] |
|---|---|---|
| author | Guenter Roeck <linux@roeck-us.net> | Wed Apr 06 15:08:03 2022 |
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Apr 15 21:14:01 2022 |
| tree | b3c34c7e9546b9c0fe038d21f34e979bb6852cc2 | |
| parent | 9eb2eaaba2def6617b1e9b55cc98b41fa9c1ed50 [diff] |
CHROMIUM: iwl7000: iwl-dbg: Use del_timer_sync() before freeing
In Chrome OS, a large number of crashes is observed due to corrupted timer
lists. Steven Rostedt pointed out that this usually happens when a timer
is freed while still active, and that the problem is often triggered
by code calling del_timer() instead of del_timer_sync() just before
freeing.
Steven also identified the iwlwifi driver as one of the possible culprits
since it does exactly that.
Reported-by: Steven Rostedt <rostedt@goodmis.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Johannes Berg <johannes.berg@intel.com>
Cc: Gregory Greenman <gregory.greenman@intel.com>
Fixes: 60e8abd9d3e91 ("iwlwifi: dbg_ini: add periodic trigger new API support")
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
(am from https://patchwork.kernel.org/project/linux-wireless/patch/20220411154210.1870008-1-linux@roeck-us.net/)
(also found at https://lore.kernel.org/r/20220411154210.1870008-1-linux@roeck-us.net)
[CHROMIUM: iwl7000 instead of iwlwifi]
BUG=b:222168464
TEST=Repeatedly instantiate wireless adapter
Change-Id: I707e2796d5fe3e3b5aeedc237ba5b903aa2bc981
Disallow-Recycled-Builds: test-failures
Signed-off-by: Guenter Roeck <groeck@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/3576002
Reviewed-by: Martin Faltesek <mfaltesek@google.com>
Commit-Queue: Martin Faltesek <mfaltesek@google.com>
(cherry picked from commit f42d34719acb9d00faf79973c916f5a74fd42785)
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/3587266