Revert "CHROMIUM: ASoC: Intel: Fixed audio noise after resume"
This reverts commit d1cca28b92f24ca912d8a1bdd389ba89062d4ac4.
In commit d1cca28b (Fixed audio noise after resume), the hw_ptr
was effectively reset to 0 on S3 resume in byt_pcm_pointer which
causes the queued restore_stream_context work to always set the
stream offset to 0. This implicit detail is what eradicated the
annoying white audio noise on S3 resume.
However, commit d1cca28b essentially undoes what commit 522dfe4983
(Sample Baytrail DSP DMA pointer only after each period) was trying
to avoid. Additionally, both byt_pcm_pointer and byt_notify_pointer
were now both sampling the DSP DMA pointer. As a result, the hw_ptr
would occasionally drop-back a period and cause repeated audio when
recording.
To fix the repeated audio while recording, revert this commit so we
don't sample the DSP DMA pointer in byt_pcm_pointer, too. The
white noise on resume is fixed in a following commit (Reset hw_ptr
on resume trigger).
BUG=chrome-os-partner:29906,chrome-os-partner:36453
TEST=No serious white noise on resume during audio playback.
TEST=No repeated audio when recording.
Change-Id: I076d691a660f205777944b808cb31986a768a3a4
Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
Reviewed-on: https://chromium-review.googlesource.com/252663
Reviewed-by: Dylan Reid <dgreid@chromium.org>
Tested-by: Matthew E Hiltner <matthew.e.hiltner@intel.com>
(cherry picked from commit dbe25965b15cefcf11760182902f6496b3ed67e1)
Reviewed-on: https://chromium-review.googlesource.com/254792
Reviewed-by: Bernie Thompson <bhthompson@chromium.org>
Commit-Queue: Bernie Thompson <bhthompson@chromium.org>
Tested-by: Bernie Thompson <bhthompson@chromium.org>
1 file changed
