CHROMIUM: mmc: dw_mmc: don't queue up a card detect at slot startup
The MMC subsystem handles looking for a card at probe time. Queuing
up our own can race with the rest of the MMC subsystem and cause
problems if we get unlucky with timing. Just remove our own
detection.
Specifically, I found that with just the right set of printouts in my
system that one of the three SD/MMC devices in my system was having
trouble probing. It would get an err -123 (-ENOMEDIUM) during probe.
I found that the source of the error was in
dw_mci_work_routine_card(). Adding more printouts to the code
sometimes made this error go away, so it's a little touchy.
You can see a snippet with my printouts in it (printouts were in
set_ios() on an exynos5420 board with some of our local patches):
[ 4.216595] dwmmc_exynos 12210000.dwmmc1: Using internal DMA controller.
[ 4.395935] dwmmc_exynos 12210000.dwmmc1: Version ID is 250a
[ 4.401948] dwmmc_exynos 12210000.dwmmc1: DW MMC controller at irq 108, 64 bit host data width, 64 deep fifo
[ 4.424430] dwmmc_exynos 12210000.dwmmc1: sdr0 mode (irq=108, width=0)
[ 4.453975] dwmmc_exynos 12210000.dwmmc1: sdr0 mode (irq=108, width=0)
[ 4.459592] mmc_host mmc1: Bus speed (slot 0) = 100000000Hz (slot req 400000Hz, actual 400000HZ div = 125)
[ 4.484258] dwmmc_exynos 12210000.dwmmc1: 1 slots initialized
[ 4.485406] dwmmc_exynos 12210000.dwmmc1: sdr0 mode (irq=108, width=0)
[ 4.487606] dwmmc_exynos 12210000.dwmmc1: sdr0 mode (irq=108, width=0)
[ 4.489794] dwmmc_exynos 12210000.dwmmc1: sdr0 mode (irq=108, width=0)
[ 4.509757] mmc1: error -123 whilst initialising SDIO card
While digging I found that doing our own card detection at init time
didn't appear to be necessary. If I remove this code then cards that
are in the system at bootup are still detected just fine.
Signed-off-by: Doug Anderson <dianders@chromium.org>
Acked-by: Seungwon Jeon <tgih.jun@samsung.com>
[ This change has landed in kernel-next chromeos-3.8 branch:
https://gerrit.chromium.org/gerrit/#/c/59499/
]
BUG=chrome-os-partner:16073
TEST=build/boot on snow and spring.
./run_remote_tests.sh --board=$B --remote=$IP power_SuspendStress/control.bareDaily
Change-Id: I948140d0c9da6508bc0a73e55fa7785f83b8df4d
Signed-off-by: Grant Grundler <grundler@chromium.org>
Previous-Reviewed-on: https://gerrit.chromium.org/gerrit/60827
(cherry picked from commit ed7900943dc4d5881fb809dcba169d2b9d7aaf5a)
Previous-Reviewed-on: https://gerrit.chromium.org/gerrit/60956
(cherry picked from commit fad8f2598eaf08e89469062131e318fa040f104e)
Reviewed-on: https://gerrit.chromium.org/gerrit/61621
Reviewed-by: Doug Anderson <dianders@chromium.org>
1 file changed
