Uprev new code and remove C++17 workarounds.

These changes have undergone internal review prior to open-sourcing.

This CL was created by running the export_to_chromeos.sh export script, with manual updates to BUILD.gn. The upstream libtextclassifier code in google3 is current as of
cl/351124900. Changes to the export script since the previous uprev can
be seen in cl/348401862.

This CL contains only refactoring changes. It is not expected to
introduce any functional/feature changes.

BUG=b:174953443
TEST=chromeos: (in conjunction with minor libtextclassifier ebuild
TEST=changes) ML Service unit tests for tclib pass.
TEST=Manual testing of Quick Answers on DUT (e.g. QA popup visible
TEST=on right-clicking non-English words).

Cq-Depend: 2627533
Change-Id: Ie560e5c10c0169fa55792572371adb0c49478a12
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/libtextclassifier/+/2628507
Tested-by: Amanda Deacon <amandadeacon@chromium.org>
Commit-Queue: Amanda Deacon <amandadeacon@chromium.org>
Reviewed-by: Honglin Yu <honglinyu@chromium.org>
Reviewed-by: Andrew Moylan <amoylan@chromium.org>
95 files changed
tree: 4fa2be0611424952390eb570106ed5944e294b46
  1. annotator/
  2. lang_id/
  3. utils/
  4. BUILD.gn
  5. CONTRIBUTING.md
  6. LICENSE
  7. OWNERS
  8. README.md
README.md

libtextclassifier

A library for on-device text classification (address, telephone number, emails etc.).

Usage in Chrome OS

To use libtextclassifier, one also needs to install a flatbuffer model defined in “model.fbs”. For simplicity, this model file will be installed in the ebuild of ml-service.

And libtextclassifier currently depends on the chrome-icu package which requires explicitly initializing the icu data, just like chrome.

The ml-service is currently the only user of this library. If another library in Chrome OS also wants to use it, please let the owners of ml-service and libtextclassifier know because then,

  1. we need to make libtextclassifier into a shared library to save space;
  2. we may also need to move the installation of libtextclassifier‘s model file into libtextclassifier’s ebuild.