tree 118611688966d42d43f271c4187a75d9af148316
parent 6d60e9d7adf88a879662bcfae3b9b1a1b4c4e4e7
author Matthew Blecker <matthewb@google.com> 1576218821 -0800
committer Commit Bot <commit-bot@chromium.org> 1576285133 +0000

novatek-tcon-fw-update-tool: Fix all compilation warnings and remove -w.

This effectively enables -Wall, which common.mk sets by default.

This adds return value checking to more file operations than required by
compiler warnings, which only required some.  Otherwise all changes were
required to avoid warnings.

In general, the least intrusive possible change to avoid warnings was made,
plus error messages when appropriate.  For example, instead of replacing
sprintf() with snprintf(), buffer overflow is avoided by adjusting buffer
sizes.  Any further cleanup is outside the scope of this change.

BUG=b:112485400
TEST=build_packages and direct make invocation both continue to succeed.

Change-Id: I962aa299ff079aa4f9e5b50934469e1f0978287d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/novatek-tcon-fw-update-tool/+/1965838
Commit-Queue: Matthew Blecker <matthewb@chromium.org>
Tested-by: Matthew Blecker <matthewb@chromium.org>
Reviewed-by: Nick Sanders <nsanders@chromium.org>
Reviewed-by: Grant Grundler <grundler@chromium.org>