)]}' { "commit": "81eee0ad7b54385f9598a90cbe5e722d6ca77da9", "tree": "a6e1c7ecf22a71a73edc80b6bfc86f9fe4b786fd", "parents": [ "69b538525e1676dbdb57fbfaba31f58b19863572" ], "author": { "name": "Dominik Behr", "email": "dbehr@chromium.org", "time": "Tue Oct 01 21:37:33 2013" }, "committer": { "name": "chrome-internal-fetch", "email": "chrome-internal-fetch@google.com", "time": "Wed Oct 02 01:24:46 2013" }, "message": "fix segfault when setting gamma table\n\nply-image assumes that CRTC 1 (hardcoded in kInternalPanel const )is the\ninternal panel. it is not true when running under QEMU since there is\nonly one CRTC under QEMU and count_crtcs in resources struct is 1, so\nusing index 1 uses bad array location. I added a check that will use\nindex 0 instead of kInternalPanel if kInternalPanel is out of bounds.\n\nTEST\u003drun ply-image --gamma /usr/share/color/bin/internal_display.bin \\\n--clear 0xfefefe\n\nChange-Id: I600f8cafcc99a25c126398fc9aaa986077101f8b\nSigned-off-by: Dominik Behr \u003cdbehr@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/171445\nReviewed-by: Stéphane Marchesin \u003cmarcheu@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "be47e9a37e0390729d9826a04aab38215f566538", "old_mode": 33188, "old_path": "src/ply-gamma.c", "new_id": "1f138d0ac5907b2948f2c5b83f22ef05dd5d923e", "new_mode": 33188, "new_path": "src/ply-gamma.c" } ] }