commit 6b59f8f698802191e2115b2f06ba2f104e9e1b8f
author Pan Xiuli <xiuli.pan@linux.intel.com> Wed Dec 20 14:10:19 2017
committer Liam Girdwood <liam.r.girdwood@linux.intel.com> Wed Dec 20 14:16:15 2017
tree bef3fd2f0e9f69ba39bd9bb05d2ebeb7ed0d9d78
parent 0866b2a13e3327abaed89764de7406ca7fa22537

rimage: Fix some memory leak error

Handle pointers and memory when error happens.

Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>

rimage/rimage.c

diff --git a/rimage/rimage.c b/rimage/rimage.c
index af57f5a..af4a7d0 100644
--- a/rimage/rimage.c
+++ b/rimage/rimage.c
@@ -208,10 +208,11 @@
 		goto out;
 	}
 
-	free(image->prg);
-	free(image->section);
-
 out:
+	if (image->prg)
+		free(image->prg);
+	if (image->section)
+		free(image->section);
 	return ret;
 }
 
@@ -283,6 +284,8 @@
 	if (image.in_fd == NULL) {
 		fprintf(stderr, "error: unable to open %s for reading %d\n",
 			image.in_file, errno);
+		ret = -EINVAL;
+		goto out;
 	}
 
 	/* open outfile for writing */
@@ -291,14 +294,19 @@
 	if (image.out_fd == NULL) {
 		fprintf(stderr, "error: unable to open %s for writing %d\n",
 			image.out_file, errno);
+		ret = -EINVAL;
+		goto out;
 	}
 
 	/* write data */
 	ret = write_elf_data(&image);
 
+out:
 	/* close files */
-	fclose(image.out_fd);
-	fclose(image.in_fd);
+	if (image.in_fd)
+		fclose(image.in_fd);
+	if (image.out_fd)
+		fclose(image.out_fd);
 
 	return ret;
 }