Google Git
Sign in
chromium / chromiumos / third_party / usb / um_ppm / a9b9466165e9c1c761d56eba838bfbe800bab44c
commita9b9466165e9c1c761d56eba838bfbe800bab44c[log] [tgz]
authorPavan Holla <pholla@chromium.org>Mon Jan 22 20:53:30 2024
committerPavan Holla <pholla@chromium.org>Thu Jan 25 22:50:20 2024
treeb58b3351e4328209b4d5e9b72c95b399254cb812
parent74ee13f8a9fc8e8ea9c9703b02975ec87e47e45a [diff]
ppm_common: Skip processing invalid acks

We choose to ignore processing invalid ACK commands before beginning
command processing. This guarantees that an ACK command is valid once
command processing actually begins.

BUG=b:319124643
TEST=make local_tests

Change-Id: If78d41e651d9b075399b4c826723f3bd1026200f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/usb/um_ppm/+/5219091
Tested-by: Pavan Holla <pholla@google.com>
Commit-Queue: Pavan Holla <pholla@google.com>
Reviewed-by: Abhishek Pandit-Subedi <abhishekpandit@google.com>
2 files changed
tree: b58b3351e4328209b4d5e9b72c95b399254cb812
  1. include/
  2. test/
  3. .gitignore
  4. LICENSE
  5. main.c
  6. Makefile
  7. platform_usermode.c
  8. ppm_common.c
  9. ppm_common.h
  10. README.md
  11. rts5453.c
  12. rts5453.h
  13. rts5453_usermode.c
  14. smbus_usermode.c
  15. smbus_usermode.h
  16. um_ppm_chardev.c
  17. um_ppm_chardev.h
README.md

Usermode PPM implementation

Usermode UCSI PPM implementation for evaluation and testing usage. Try using this with the ucsi_um_test kernel driver.

Setup

For usermode implementations, we use libi2c and libgpiod to provide an smbus implementation. You will need the right libraries to build:

sudo apt-get install libi2c-dev libgpiod-dev

Architecture

┌─────────┐
│OPM      │
│kernel or│
│cli      │
└────┬────┘
     │
     │
     ▼          ┌───────────┐
 ┌────────┐     │ PD Driver │
 │        ├────►│           │
 │  PPM   │     ├───────────┤
 │        │     │           │
 └────────┘     │ I2C Driver│
                └───────────┘

The usermode ppm implementation consists of the PPM task, the PD driver and the I2C driver backing it. The OPM will either be a CLI (for locally triggering some functionality) or the ucsi_um_test kernel module.