Google Git
Sign in
chromium / chromiumos / third_party / webrtc-apm / af7028556a5374f9aaf4983105c4cebdfbfe2eea
commitaf7028556a5374f9aaf4983105c4cebdfbfe2eea[log] [tgz]
authorHsin-Yu Chao <hychao@chromium.org>Tue May 18 09:47:54 2021
committerCommit Bot <commit-bot@chromium.org>Tue May 18 18:28:20 2021
tree716bf9ba2ea463504d94ce16c3587ef761d170f5
parentb3dfb0e9330bbfdf92fe6506f11e5f867214de50 [diff]
Non-tuned APM: activate playout stereo processing by default

This is a Chromium OS specific change. For APM use cases without
tuned apm.ini config file, all settings default value are defined
in source code.
Before tuned settings are applied, we override the config by
setting playout stereo processing to be active by default.

This change also reverts commit d694dd242 to make the tuned
settings default values stay aligned with source code default
values.  Moving forward we should place all Chrome OS specific
generic settings override in webrtc_apm.cc

BUG=b:177830918
TEST=Manual test on octopus device.

Change-Id: I84125d30fc983679ab90dad100fc502b2a1dd475
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/webrtc-apm/+/2902987
Reviewed-by: Per Åhgren <peah@google.com>
Reviewed-by: Hsinyu Chao <hychao@chromium.org>
Reviewed-by: Per Åhgren <peah@chromium.org>
Tested-by: Per Åhgren <peah@google.com>
Tested-by: Hsinyu Chao <hychao@chromium.org>
Tested-by: Per Åhgren <peah@chromium.org>
Commit-Queue: Hsinyu Chao <hychao@chromium.org>
2 files changed
tree: 716bf9ba2ea463504d94ce16c3587ef761d170f5
  1. absl/
  2. api/
  3. audio/
  4. common_audio/
  5. cras-config/
  6. modules/
  7. rtc_base/
  8. script/
  9. system_wrappers/
  10. third_party/
  11. common.mk
  12. common_types.h
  13. libwebrtc_apm.pc.template
  14. Makefile
  15. OWNERS
  16. pc_utils.mk
  17. README.md
  18. typedefs.h
  19. webrtc_apm.cc
  20. webrtc_apm.h
README.md

WebRTC APM

APM is the audio processing module of WebRTC project in charge of effects like echo cancellation, noise suppression, etc. The purpose of this project is to build a standalone library for Chrome OS system side audio processing.

Files content

  • scripts to copy over folders and files from upstream WebRTC project for APM and its dependencies.
  • Copied files from upstream WebRTC project. For example: common_audio, modules, rtc_base and system_wrappers.
  • webrtc_apm.cc/h C wrappers to access APM functions.
  • common-mk based makefiles to build shared library libwebrtc_apm.so

Update

To update this package to latest upstream WebRC:

  • Run ./script/sync-apm.sh path/to/webrtc-checkout/src .
  • emerge webrtc-apm to see if anything breaks.
  • If emerge success, then we're good.
  • Otherwise look into the emerge failure, and then possibly:
    • Update sync-apm.sh to copy more files if upstream directory structure changes.
    • Update makefiles if upstream build files has changed.
    • Update webrtc-apm ebuild file if dependencies changed.
  • Create a new commit