Google Git
Sign in
chromium / chromiumos / third_party / webrtc-apm / refs/heads/stabilize-15610.B
commit80cb6629d10be6d6600db7c25883d9c24afd07ed[log] [tgz]
authorLi-Yu Yu <aaronyu@google.com>Thu Sep 07 11:51:52 2023
committerChromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Sep 08 03:38:02 2023
treec0d7cb48710406bcc5c3446316e5e4267946404f
parent0cff7a2df1a8c5aa942c039f3dc14b4831f966b3 [diff]
Fix up for webrtc importer on current revision

There are some build target name changes caused by using the importer
and also some utility function changes required by the importer.

Those issues are addressed as a separate commit to make it easier to
review.

BUG=b:299043094
TEST=CQ

Change-Id: Ie6b1f9cc8981576b11b04512e27774fccc3484a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/webrtc-apm/+/4846432
Reviewed-by: Chih-Yang Hsia <paulhsia@chromium.org>
Commit-Queue: Li-Yu Yu <aaronyu@google.com>
Tested-by: Li-Yu Yu <aaronyu@google.com>
6 files changed
tree: c0d7cb48710406bcc5c3446316e5e4267946404f
  1. api/
  2. audio/
  3. common_audio/
  4. cras-config/
  5. modules/
  6. repositories/
  7. rtc_base/
  8. script/
  9. system_wrappers/
  10. third_party/
  11. .bazelrc
  12. .gitignore
  13. BUILD.bazel
  14. BUILD.iniparser.bazel
  15. defs.bzl
  16. deps.bzl
  17. DIR_METADATA
  18. OWNERS
  19. PRESUBMIT.cfg
  20. README.md
  21. unblocked_terms.txt
  22. webrtc_apm.cc
  23. webrtc_apm.h
  24. webrtc_apm_test.cc
  25. WORKSPACE.bazel
README.md

WebRTC APM

APM is the audio processing module of WebRTC project in charge of effects like echo cancellation, noise suppression, etc. The purpose of this project is to build a standalone library for Chrome OS system side audio processing.

Files content

  • scripts to copy over folders and files from upstream WebRTC project for APM and its dependencies.
  • Copied files from upstream WebRTC project. For example: common_audio, modules, rtc_base and system_wrappers.
  • webrtc_apm.cc/h C wrappers to access APM functions.
  • common-mk based makefiles to build shared library libwebrtc_apm.so

Update

To update this package to latest upstream WebRC:

  • Run ./script/sync-apm.sh path/to/webrtc-checkout/src .
  • emerge-${BOARD} adhd to see if anything breaks.
  • If emerge success, then we're good.
  • Otherwise look into the emerge failure, and then possibly:
    • Update sync-apm.sh to copy more files if upstream directory structure changes.
    • Update BUILD.bazel files if upstream build files has changed.
    • Update the adhd ebuild file if dependencies changed.
  • Create a new commit

Build

There are three ways to build/test this package:

  1. Build webrtc-apm alone
  2. Build webrtc-apm with cras
  3. Build webrtc-apm inside a ChromiumOS SDK

The first one is the easiest to iterate with, and the last one is closest to the way ChromiumOS infra actually use to build OS images. The second one is somewhere in-between.

Build webrtc-apm alone

In the directory same as this README file, run:

bazel test //:tests

If you see pkg-config errors you are missing some system dependencies. (Googlers: follow go/cras-dev#prerequisites to install dependencies on gLinux)

Build webrtc-apm with cras

  1. Clone https://chromium.googlesource.com/chromiumos/third_party/adhd/ to the directory adjacent to this directory, so that adhd and webrtc-apm (this repository) are in the same directory.

    NOTE: If you use repo to set up a ChromiumOS checkout, the directory tree is already set up this way.

  2. In the adhd directory, run:

    bazel test //... @webrtc_apm//:tests

    There are some configs you can use, such as --config=local-clang and --config=asan. Refer to adhd's bazelrc for details.

    If you see pkg-config errors you are missing some system dependencies. (Googlers: follow go/cras-dev#prerequisites to install dependencies on gLinux)

Build webrtc-apm inside a ChromiumOS SDK

Example:

FEATURES=test USE=asan emerge-${BOARD} adhd