Google Git
Sign in
chromium / chromiumos / third_party / webrtc-apm / refs/heads/stabilize-15662.88.B
commit54c9d62447257ab60f7e49b3be230732c9e01158[log] [tgz]
authorLi-Yu Yu <aaronyu@google.com>Tue Oct 17 21:21:38 2023
committerChromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Oct 18 01:34:27 2023
tree3f8f2658139953b1197fc3d329b3f6c8eb95266f
parentb940248c64c0dacdd04154b7261e1916adcbb826 [diff]
Allow channel counts of 1 and 2 only in webrtc_apm_create

We relied on webrtc_apm_create before webrtc-apm uprev,
so let's keep it this way until we actually need more channels:
https://crrev.com/c/4846427/8/webrtc_apm/webrtc_apm.cc

BUG=b:305847459
TEST=bazel test //...

Change-Id: Ib00512f6166ecbeeeb47431a1e9d58cfe0011e9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/webrtc-apm/+/4950650
Commit-Queue: Li-Yu Yu <aaronyu@google.com>
Commit-Queue: Curtis Malainey <cujomalainey@chromium.org>
Tested-by: Li-Yu Yu <aaronyu@google.com>
Reviewed-by: Curtis Malainey <cujomalainey@chromium.org>
1 file changed
tree: 3f8f2658139953b1197fc3d329b3f6c8eb95266f
  1. api/
  2. audio/
  3. common_audio/
  4. experiments/
  5. modules/
  6. repositories/
  7. rtc_base/
  8. rtc_tools/
  9. system_wrappers/
  10. third_party/
  11. webrtc_apm/
  12. .bazelrc
  13. .gitignore
  14. BUILD.bazel
  15. BUILD.iniparser.bazel
  16. defs.bzl
  17. deps.bzl
  18. DIR_METADATA
  19. OWNERS
  20. PRESUBMIT.cfg
  21. README.md
  22. unblocked_terms.txt
  23. WORKSPACE.bazel
README.md

WebRTC APM

APM is the audio processing module of WebRTC project in charge of effects like echo cancellation, noise suppression, etc. The purpose of this project is to build a standalone library for Chrome OS system side audio processing.

Files content

  • scripts to copy over folders and files from upstream WebRTC project for APM and its dependencies.
  • Copied files from upstream WebRTC project. For example: common_audio, modules, rtc_base and system_wrappers.
  • webrtc_apm.cc/h C wrappers to access APM functions.
  • common-mk based makefiles to build shared library libwebrtc_apm.so

Update

To update this package to latest upstream WebRC:

  • Run ./script/sync-apm.sh path/to/webrtc-checkout/src .
  • emerge-${BOARD} adhd to see if anything breaks.
  • If emerge success, then we're good.
  • Otherwise look into the emerge failure, and then possibly:
    • Update sync-apm.sh to copy more files if upstream directory structure changes.
    • Update BUILD.bazel files if upstream build files has changed.
    • Update the adhd ebuild file if dependencies changed.
  • Create a new commit

Build

There are three ways to build/test this package:

  1. Build webrtc-apm alone
  2. Build webrtc-apm with cras
  3. Build webrtc-apm inside a ChromiumOS SDK

The first one is the easiest to iterate with, and the last one is closest to the way ChromiumOS infra actually use to build OS images. The second one is somewhere in-between.

Build webrtc-apm alone

In the directory same as this README file, run:

bazel test //:tests

If you see pkg-config errors you are missing some system dependencies. (Googlers: follow go/cras-dev#prerequisites to install dependencies on gLinux)

Build webrtc-apm with cras

  1. Clone https://chromium.googlesource.com/chromiumos/third_party/adhd/ to the directory adjacent to this directory, so that adhd and webrtc-apm (this repository) are in the same directory.

    NOTE: If you use repo to set up a ChromiumOS checkout, the directory tree is already set up this way.

  2. In the adhd directory, run:

    bazel test //... @webrtc_apm//:tests

    There are some configs you can use, such as --config=local-clang and --config=asan. Refer to adhd's bazelrc for details.

    If you see pkg-config errors you are missing some system dependencies. (Googlers: follow go/cras-dev#prerequisites to install dependencies on gLinux)

Build webrtc-apm inside a ChromiumOS SDK

Example:

FEATURES=test USE=asan emerge-${BOARD} adhd