Google Git
Sign in
chromium / codesearch / chromium / src / 0e076b80191980e8d457b9e7fbb021c63ae655d9
commit0e076b80191980e8d457b9e7fbb021c63ae655d9[log] [tgz]
authorRyo Hashimoto <hashimoto@chromium.org>Mon Feb 01 19:46:23 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Feb 01 19:46:23 2021
tree8ee20a226cad3bc743b59254281d5113db97be3b
parent8df30fd7b8445afc4ba11d86407129104e7b5b9e [diff]
Revert "Fix jank on first show of holding space welcome banner."

This reverts commit f5df79ecd7ee7780d0a0c6103fe9d1874ead0cdb.

Reason for revert: Breaks filemanager.DragDrop tast and blocks chrome uprev.

Original change's description:
> Fix jank on first show of holding space welcome banner.
>
> Because holding space welcome banner styles are dynamically loaded,
> there was some jank when the banner was shown before the dynamic styles
> had finished loading.
>
> This CL adds inline styles to hide the welcome banner until they are
> removed following load completion of dynamic styles.
>
> Bug: 1170470
> Change-Id: I32aa65c5c17505d1e2c2bee61a4e27468c6f881d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2649110
> Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
> Commit-Queue: David Black <dmblack@google.com>
> Cr-Commit-Position: refs/heads/master@{#847408}

TBR=dmblack@google.com,lucmult@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com

# Not skipping CQ checks because original CL landed > 1 day ago.

(cherry picked from commit 0f4a28aa469ddc5150e8a80aae45fa206100d77a)

Bug: 1171875
Bug: 1170470
Change-Id: Ie71d01fcf37776d8fe0c66b66e465aa690050eb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2663348
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#849091}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2665667
Auto-Submit: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/branch-heads/4405@{#3}
Cr-Branched-From: 6da2191b7f3ed8aa28c0707c693ce79be8ba508c-refs/heads/master@{#848977}
3 files changed
tree: 8ee20a226cad3bc743b59254281d5113db97be3b
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.