commit | 3d92bf74af2cc8b18d8529b57b04d1d26aecf73e | [log] [tgz] |
---|---|---|
author | Matt Falkenhagen <falken@chromium.org> | Mon May 20 07:25:14 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Mon May 20 07:25:14 2019 |
tree | 143fc9f76dbcc5c93b59d809827f8bb6432951d7 | |
parent | f4a2c40eea222931f18ac9aa01b71496b0e0e04b [diff] |
service worker: Simplify deletion states on ServiceWorkerRegistration. Before this CL, ServiceWorkerRegistration had three states: - is_deleted - is_uninstalling - is_uninstalled It's difficult to understand the differences. The tension that caused the states seems to be that |is_deleted| was controlled by the lower-level storage layer, and |is_uninstall{ing,ed}| by the higher-level API layer like the implementation of unregister(). This CL aims to simplify things by removing the is_deleted flag. The layers get a bit more blurry but the benefit is fewer states. There are likely further cleanups and renamings possible to make this nicer. Change-Id: Iee1102da0a865f571bc8906e184dd16551541c1e Bug: 964201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616870 Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#661282}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .