commit | 591a0f30c5eac93b6a3d981c2714ffa4db28dbcb | [log] [tgz] |
---|---|---|
author | Adrian Taylor <adetaylor@chromium.org> | Fri Apr 15 23:29:40 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Apr 15 23:29:40 2022 |
tree | 467b5951f6fc665e0c8f51a781d73c1a3fd2d650 | |
parent | 0a591057818f05d0af55e087cdf89ff9c175f29d [diff] |
[rust] autocxx 0.17.1 -> 0.20.1 This revises autocxx and its various subsidiary crates from 0.17.1 to 0.20.1. The main purpose of this roll is to fix these issues reported by Chromium: * crbug/1313552 - autocxx does not generate a .d file so ninja can't know when to rebuild Rust code that depends on C++ code * https://github.com/google/autocxx/issues/977 - autocxx's error messages are bad. * Too much is printed to stderr (https://github.com/google/autocxx/issues/978) * There's no way to refer to an external type definition (https://github.com/google/autocxx/issues/967) though various other autocxx improvements have occurred too. These problems were fixed in autocxx partly through the use of additional third-party dependencies (pathdiff for the second issue; miette and thiserror for the first). So most of this CL involves adding those additional transitive dependencies into Chromium. Specifically this CL contains: * Updated autocxx code * An additional version of the textwrap crate, which is required by miette. (The need for two different versions of textwrap is unfortunate and is being worked on in https://github.com/google/autocxx/pull/834). * miette and all its new dependencies. * pathdiff. * A patch to the 'backtrace' crate which previously relied on the C++ preprocessor to look up Android versions. As it happens, chromium does not support old enough Android versions for this to matter, so we just disable this dynamic build. * Adjustments to our first-party Chromium test code that uses autocxx, to move off some autocxx APIs which are now deprecated. autocxx changes are best viewed here: https://github.com/google/autocxx/compare/v0.17.1..v0.20.1 Release notes: https://github.com/google/autocxx/releases/tag/v0.17.2 https://github.com/google/autocxx/releases/tag/v0.17.3 https://github.com/google/autocxx/releases/tag/v0.17.4 https://github.com/google/autocxx/releases/tag/v0.17.5 https://github.com/google/autocxx/releases/tag/v0.18.0 https://github.com/google/autocxx/releases/tag/v0.19.0 https://github.com/google/autocxx/releases/tag/v0.19.1 https://github.com/google/autocxx/releases/tag/v0.20.0 https://github.com/google/autocxx/releases/tag/v0.20.1 moveit has also rolled from 0.4.0 to 0.5.0: https://github.com/google/moveit/compare/43d3ad0c2386dc33892eec9ebfad1bb290f873fc..2ccb9c5b5d4d7db0360ce28e67d7568d4d1d16f2 (changes there have been through full code review by mcy@ on github) textwrap has rolled from 0.11 to 0.15: https://github.com/mgeisler/textwrap/compare/abcd618beae3f74841032aa5b53c1086b0a57ca2..559e07a53bdf7de6bed5c48aacfc0ec8c8bb0c05 Additional crates: Ssecurity review is documented here: https://docs.google.com/document/d/1Y07x0VSuquaFG7bAzqYzD6zJiNGHxDJd6xHUcdcAsxY/edit# Bug: 1296155, 1313552 Change-Id: I50894acfd87d72536de2ca7658f99afb84c309a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3576923 Reviewed-by: Alex Gough <ajgo@chromium.org> Reviewed-by: Eric Foo <efoo@chromium.org> Commit-Queue: Adrian Taylor <adetaylor@chromium.org> Cr-Commit-Position: refs/heads/main@{#993107}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.