commit | 4d09c7c555d6e938969321069737f8f228888782 | [log] [tgz] |
---|---|---|
author | Mohammad Refaat <mrefaat@chromium.org> | Fri Sep 13 17:22:58 2019 |
committer | Mohammad Refaat <mrefaat@chromium.org> | Fri Sep 13 17:22:58 2019 |
tree | f60f4c0c17b5e89c4d068b1ef79d24daf59d1b9b | |
parent | c73f02ad97bc4493790c1b8c1ff00991354faaf6 [diff] |
[Merge 77] Stop disabling WebUsage before clearing browsing data for iOS 13 This should fix the problem of cookies not clearing consistently on iOS 13. More details are on the crbug comments. Also Change onViewUpdated on web_frames_manager_impl to remove all messages instead of looking for specific messages. This is needed as removing specific messages DCHECKs if the message is not registered. and during the Purge which happens in clear browsing data the message router is destroyed so there will be no messages in the registered with the webview. TEST= I tested manually on ipad, iphone for both iOS 12 & 13 on devices , a test on the simulator is meaningless as the simulator doesn't use the same cookie storage that the device use. There exist unit tests but they will not fail in the case that i'm fixing because in these tests we set cookies manually and this current case happen when cookies are set by the web view. I'll discuss further creating EG tests to test the failed scenario using a browsing test page that can set/get cookies. (cherry picked from commit d03761396d4e85f8d42ffa571377acff9ba3b6f8) Bug: 997172, 956516 Change-Id: I3befee1bf38ac1d3d86c33e50bbbbd4fb9e75ec9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791629 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Mike Dougherty <michaeldo@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#695709} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802438 Reviewed-by: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/branch-heads/3865@{#793} Cr-Branched-From: 0cdcc6158160790658d1f033d3db873603250124-refs/heads/master@{#681094}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .