commit | c8d5d5b1bdce313aad24e98bd957266becd12631 | [log] [tgz] |
---|---|---|
author | Austin Sullivan <asully@chromium.org> | Wed May 05 19:18:18 2021 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed May 05 19:18:18 2021 |
tree | 4fb653bb1dd37340315a32a6348de90e0c884830 | |
parent | b44f236a249d9c1ccf59fe3a6efd4c904b74ae95 [diff] |
[Code Health] Remove uses of Value::Equals() These changes have been run against the trybots, but please double-check that the conversions have been done appropriately (in case any of these changes are not covered by tests). In particular, make sure (1) non-equality is retained and that (2) Values are being compared, not their pointers. (1) !a.Equals(&b) -> a != b (2) a->Equals(b) -> *a == *b Thank you! This CL was uploaded by git cl split. R=stevenjb@chromium.org Bug: 1187018 Change-Id: I0f682a32094a349c82e9941eb4d899a669adb673 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2874973 Auto-Submit: Austin Sullivan <asully@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Austin Sullivan <asully@chromium.org> Cr-Commit-Position: refs/heads/master@{#879484}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.