commit | d67a00b1dcfc46eccbd505b346b06785d3c321ad | [log] [tgz] |
---|---|---|
author | Hajime Hoshi <hajimehoshi@chromium.org> | Wed Sep 22 18:35:29 2021 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Sep 22 18:35:29 2021 |
tree | d545289ed6bf8a1e116bc509236c296f5463eaaa | |
parent | 569d156ac000f54722dcfd946a3a9d35a729bc15 [diff] |
[M95] BackForwardCache: Reland: Disable when MediaSession's service is used This is reland of crrev.com/c/3121727 with disabling the test on the ASAN bot (crbug.com/1243159). We are addressing on this issue soon later. After this change, back-forward cache is blocked when MediaSession's service exists, i.e., a MediaSession action handler is registered and a audio or media plays. It is risky to put a page with a MediaSession service into the back-forward cache, since the page's state can affect a media control UI. This change adds this blocking behind a flag (supported_features) for future experiments. This change adds feature flags. We think that changing the playback state without a MediaSession service should not be harmful for back- forward cache. By adding the flags, we will be able to do experiments. After this change, we have two new features: * BackForwardCacheMediaSessionPlaybackStateChange * BackForwardCacheMediaSessionService These are independent and can take these pairs: * (false, false): MediaSession's playback state change doesn't allow BFcache (default) * (true, false): MediaSession's playback state change w/o a MediaSession service allows BFcache * (true, true): MediaSession's playback state change w and w/o a MediaSession service allows BFcache In theory there is a pair (false, true) but this doesn't make sense, as a MediaSession service does nothing if the playback state is not changed. (cherry picked from commit 568bc4acd1bcfbb506741c66f09ea9c9b9cda535) Bug: 1243599 Change-Id: I01f1498aaf3796ade1c5a4520834eab434229902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3151103 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: Tommy Steimel <steimel@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#923248} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3174617 Auto-Submit: Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/branch-heads/4638@{#252} Cr-Branched-From: 159257cab5585bc8421abf347984bb32fdfe9eb9-refs/heads/main@{#920003}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.