commit | f2df2933e7f31b8769d6b4d971d90047a09c4781 | [log] [tgz] |
---|---|---|
author | Eugene But <eugenebut@chromium.org> | Mon Dec 10 23:28:36 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Dec 10 23:28:36 2018 |
tree | 3225bc8c863a12f11eb97493b8d6777f4fa957ce | |
parent | 5d500ddae3b6f9997854f9234c4848ed34949884 [diff] |
Allow using #import directive for C++ headers in ios/ directory. The following text was added to Chromium Objective-C and Objective-C++ style guide: all source code in ios/ directory. This differs from Google Objective-C Style Guide, which requires using #include directive for C++ headers. The usage of #include and #import is inconsistent for the same headers and cause a lot of frictions during the code reviews. The proposal to run PRESUBMIT script which fixes #include/#import usage was rejected due to performance reasosn, so relaxing style guide is the only option to simplify codereview process. Original attempt to add presubmit script was here: https://codereview.chromium.org/2598173002/patch/80001/90001 Bug: None Change-Id: I670f7318bcef60c89a3697787d1f5b4104a6ef76 Reviewed-on: https://chromium-review.googlesource.com/c/1340956 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#615312}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .