| commit | dc20e09b39b12af7642011c2d71d4fa70259d0c4 | [log] [tgz] |
|---|---|---|
| author | apacible <apacible@chromium.org> | Sun Feb 07 22:55:13 2016 |
| committer | Commit bot <commit-bot@chromium.org> | Sun Feb 07 22:56:41 2016 |
| tree | 9b80f56851495b2a969eeff70cacebf3033e4e4d | |
| parent | c86eb118c56fa06ddc0f57985352e0083ceabbe8 [diff] |
Revert of [Reland] Enable AutoResize for Constrained Web Dialogs for Mac. (patchset #9 id:440001 of https://codereview.chromium.org/1446623003/ ) Reason for revert: Flaky on Mac 10.9 again. See: https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29 Original issue's description: > [Reland] Enable AutoResize for Constrained Web Dialogs for Mac. > > Currently only constrained web dialogs for views (Linux/Windows) are able to > autoresize. This change implements the option to pass in minimum and maximum > sizes and enabling autoresizing functionality for OSX. > > This change adds two static functions for options on whether to create a > ConstrainedWindowsMac that autoresizes or is of fixed size. > > The initial patch was reverted because of flaky tests in Mac 10.9. Upon further investigation, the ConstrainedWebDialogBrowserTest tests were also flaky on other Mac versions, such as 10.10. At the time, the test would fail once every 4-5,000 runs. After picking up this patch again, I was unable to repro the failing test after ~20,000 runs. > > The original patch can be found at: https://codereview.chromium.org/1430023002 > > BUG=217034 > > Committed: https://crrev.com/c47b9b44157a34aa5df0acebe357dc0164f49887 > Cr-Commit-Position: refs/heads/master@{#374039} TBR=thakis@chromium.org,erikchen@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=217034 Review URL: https://codereview.chromium.org/1674063002 Cr-Commit-Position: refs/heads/master@{#374072}