Use the correct comment format for the Kythe metadata.

Previously I saw that the metadata reader supported C++-style comments,
and also supported line wrapping, so I figured it supported both. Turns
out it doesn't. For C++-style comments it just takes the first line.

The new output matches that of the Kythe verifier test for this feature:
https://github.com/kythe/kythe/blob/master/kythe/cxx/indexer/cxx/testdata/metadata/metadata_inline_cstyle.cc

We make sure to support both the new and old format when stripping
existing metadata from the file. This has been tested locally on files
containing both styles.

Bug: 615202
Change-Id: I5497c770f051d9f69feeac106126eede816f3d41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/1614981
Reviewed-by: Dean Berris <dberris@chromium.org>
Commit-Queue: Owen Rodley <orodley@chromium.org>
2 files changed
tree: d1fc203d6f23f441fd93dfd70c408b7d05390d84
  1. .gitattributes
  2. .gitignore
  3. .vpython
  4. DEPS
  5. LICENSE
  6. OWNERS
  7. PRESUBMIT.py
  8. README.md
  9. WATCHLISTS
  10. codereview.settings
  11. environment.cfg.py
  12. infra/
  13. masters/
  14. scripts/
  15. site_config/
  16. slave/
  17. tests/
  18. third_party/
README.md

build

Hi build contributor! If you do any change in scripts/master/ or touching any master's html/ directories, you must restart master.chromium.fyi first and ensure that it still works before restarting other masters.

Recipes

If you're here to make a change to ‘recipes’ (the code located in scripts/slave/recipes*), please take a look at the README for more information pertaining to recipes.