Update Skylab lease- and release-dut commands to allow any lease to be cancelled by hostname.

Tested by creating leases by both hostname and model, then cancelling them successfully:

$ cd src/infra/cmd/skylab
$ go build
$ ./skylab lease-dut -model garg
Created lease for model garg: https://ci.chromium.org/p/chromeos/builders/test_runner/dut_leaser/b8862707897656800912
chromeos6-row18-rack15-host18.cros.corp.google.com
DUT leased until Tue, 24 Nov 2020 17:22:27 MST
$ ./skylab release-duts chromeos6-row18-rack15-host18
Canceling lease task for host: chromeos6-row18-rack15-host18
Successfully killed task 501561fdadda0b10, DUT chromeos6-row18-rack15-host18 is released
$ ./skylab lease-dut chromeos6-row18-rack15-host18
inferred model (garg)
Created lease for host chromeos6-row18-rack15-host18: https://ci.chromium.org/p/chromeos/builders/test_runner/dut_leaser/b8862707837486126944
Waiting for task to start; lease isn't active yet
chromeos6-row18-rack15-host18.cros.corp.google.com
DUT leased until Tue, 24 Nov 2020 17:23:14 MST
$ ./skylab release-duts chromeos6-row18-rack15-host18
Canceling lease task for host: chromeos6-row18-rack15-host18
Successfully killed task 501562dd38130510, DUT chromeos6-row18-rack15-host18 is released

Bug: b:170998289
Change-Id: Ida4483ef36e308ed41d7714c6e79c951e50a8b58
Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2559019
Commit-Queue: Jared Loucks <jaredloucks@google.com>
Reviewed-by: Sean Abraham <seanabraham@chromium.org>
Reviewed-by: Gregory Nisbet <gregorynisbet@google.com>
Reviewed-by: Otabek Kasimov <otabek@google.com>
Cr-Commit-Position: refs/heads/master@{#36706}
4 files changed
tree: 1ec00064d808c448667c33bfd57ccb834294ffe1
  1. 3pp/
  2. appengine/
  3. appengine_module/
  4. bootstrap/
  5. build/
  6. chromeperf/
  7. cipd/
  8. crdx/
  9. doc/
  10. docker/
  11. glyco/
  12. go/
  13. infra/
  14. node/
  15. packages/
  16. python_pb2/
  17. recipes/
  18. test/
  19. utils/
  20. .gitattributes
  21. .gitignore
  22. .style.yapf
  23. .yapfignore
  24. codereview.settings
  25. CONTRIBUTING.md
  26. DEPS
  27. LICENSE
  28. navbar.md
  29. OWNERS
  30. PRESUBMIT.py
  31. README.md
  32. run.py
  33. test.py
  34. WATCHLISTS
  35. WHITESPACE
README.md

infra.git repository

Testing Welcome to the Chrome Infra repository!

Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.

Entry points

  • run.py: wrapper script to run programs contained in subdirectories without having to deal with sys.path modifications.
  • test.py: multi-purpose script to run tests.
  • packages/infra_libs/: generally useful functions and classes
  • infra/services/: standalone programs intended to be run as daemons.
  • infra/tools: command-line tools, intended to be run by developers.
  • appengine/: many Chrome-infra-managed AppEngine applications
  • infra/experimental: for, well, experimental stuff. Once they are stabilized and reviewed, they should be moved in a more permanent place.

Miscellaneous technical stuff

  • bootstrap/: utilities to set up a proper Python virtual environment.
  • infra/path_hacks: submodules of this modules give access to modules in the build/ repository. from infra.path_hacks.common import <stg> is actually getting <stg> from build/scripts/common.
  • utils/: purpose? utils?
  • Need to bump infra/deployed to pick up changes?
    • git push origin <updated hash>:deployed
    • mail chrome-troopers@, include:
      • previously deployed hash (for quick rollback)
      • the hash you just pushed
      • the list of CLs that made this push necessary
      • the output of the git push command

Integrating tests with test.py

If you've added a new module, run your tests with test.py:

  1. Create a .coveragerc file in the root directory of the module you want to test. Take a look at another .coveragerc to see what to include in that.
  2. Create a “test” directory in the root directory of the module you want to test. Move your *_test.py files to this directory.

Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>.

Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py files in each directory of your module so Python recognizes it as a package.

Style

The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores. Use yapf (git cl format) to autoformat new code.