commit | 0fc36124d5239bc7a67a4f39e839e5e55d1f2c4d | [log] [tgz] |
---|---|---|
author | Jared Loucks <jaredloucks@google.com> | Wed Nov 25 15:57:42 2020 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Nov 25 15:57:42 2020 |
tree | 1ec00064d808c448667c33bfd57ccb834294ffe1 | |
parent | 27338b8cb172b025fcaa9bea40a847390be1ef13 [diff] |
Update Skylab lease- and release-dut commands to allow any lease to be cancelled by hostname. Tested by creating leases by both hostname and model, then cancelling them successfully: $ cd src/infra/cmd/skylab $ go build $ ./skylab lease-dut -model garg Created lease for model garg: https://ci.chromium.org/p/chromeos/builders/test_runner/dut_leaser/b8862707897656800912 chromeos6-row18-rack15-host18.cros.corp.google.com DUT leased until Tue, 24 Nov 2020 17:22:27 MST $ ./skylab release-duts chromeos6-row18-rack15-host18 Canceling lease task for host: chromeos6-row18-rack15-host18 Successfully killed task 501561fdadda0b10, DUT chromeos6-row18-rack15-host18 is released $ ./skylab lease-dut chromeos6-row18-rack15-host18 inferred model (garg) Created lease for host chromeos6-row18-rack15-host18: https://ci.chromium.org/p/chromeos/builders/test_runner/dut_leaser/b8862707837486126944 Waiting for task to start; lease isn't active yet chromeos6-row18-rack15-host18.cros.corp.google.com DUT leased until Tue, 24 Nov 2020 17:23:14 MST $ ./skylab release-duts chromeos6-row18-rack15-host18 Canceling lease task for host: chromeos6-row18-rack15-host18 Successfully killed task 501562dd38130510, DUT chromeos6-row18-rack15-host18 is released Bug: b:170998289 Change-Id: Ida4483ef36e308ed41d7714c6e79c951e50a8b58 Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2559019 Commit-Queue: Jared Loucks <jaredloucks@google.com> Reviewed-by: Sean Abraham <seanabraham@chromium.org> Reviewed-by: Gregory Nisbet <gregorynisbet@google.com> Reviewed-by: Otabek Kasimov <otabek@google.com> Cr-Commit-Position: refs/heads/master@{#36706}
Testing Welcome to the Chrome Infra repository!
Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.
sys.path
modifications.from infra.path_hacks.common import <stg>
is actually getting <stg>
from build/scripts/common.git push origin <updated hash>:deployed
git push
commandIf you've added a new module, run your tests with test.py:
*_test.py
files to this directory.Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>
.
Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py
files in each directory of your module so Python recognizes it as a package.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores
. Use yapf (git cl format
) to autoformat new code.