commit | 50942856d7773d6e0fcdef16f4b6eb48a1a85bee | [log] [tgz] |
---|---|---|
author | Xinyu Yang <xinyuoffline@google.com> | Wed Nov 25 00:46:01 2020 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Nov 25 00:46:01 2020 |
tree | d5346470b8c0b694a35ab23c377ecc72adf4b108 | |
parent | 5230b7a2d6a82cfd3a051070757033851e63d50e [diff] |
[rubber-stamper] Remove reviewer & comment after reviewing an invalid CL. Bug: 1092603 Change-Id: I6b299f906916677c1e92eadd661c1d3d46e489f8 Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2556493 Commit-Queue: Xinyu Yang <xinyuoffline@google.com> Reviewed-by: Yulan Lin <yulanlin@google.com> Reviewed-by: Jason Clinton <jclinton@chromium.org> Cr-Commit-Position: refs/heads/master@{#36690}
Testing Welcome to the Chrome Infra repository!
Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.
sys.path
modifications.from infra.path_hacks.common import <stg>
is actually getting <stg>
from build/scripts/common.git push origin <updated hash>:deployed
git push
commandIf you've added a new module, run your tests with test.py:
*_test.py
files to this directory.Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>
.
Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py
files in each directory of your module so Python recognizes it as a package.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores
. Use yapf (git cl format
) to autoformat new code.