Google Git
Sign in
chromium / codesearch / infra / infra / bc42ddc035859d9c1b316ee7d20de0b4da54d01f
commitbc42ddc035859d9c1b316ee7d20de0b4da54d01f[log] [tgz]
authorDean Michael Berris <dberris@google.com>Thu Nov 26 03:11:49 2020
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Nov 26 03:11:49 2020
tree62df58405d293803808c2603bb0bde9823b57f46
parent987acccd410ebbea7b321f37a55713665c570166 [diff]
chromeperf: Handle responses from legacy service

This change makes the server handle the HTTP result codes from the
legacy service, and propagates the issue to the client. This code is
only useful in the interim because we're proxying requests to the legacy
service. In the future these error messages will not make it to the
client, as we'll have a better logging and debugging strategy in
production for this gRPC service.

R=abennetts@google.com, fancl@chromium.org

Bug: chromium:1059667
Change-Id: I2b245420687538bdc3418c7244dba1224603ed99
Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2560425
Commit-Queue: Dean Berris <dberris@chromium.org>
Commit-Queue: Andrew Bennetts <abennetts@google.com>
Auto-Submit: Dean Berris <dberris@chromium.org>
Reviewed-by: Andrew Bennetts <abennetts@google.com>
Cr-Commit-Position: refs/heads/master@{#36735}
1 file changed
tree: 62df58405d293803808c2603bb0bde9823b57f46
  1. 3pp/
  2. appengine/
  3. appengine_module/
  4. bootstrap/
  5. build/
  6. chromeperf/
  7. cipd/
  8. crdx/
  9. doc/
  10. docker/
  11. glyco/
  12. go/
  13. infra/
  14. node/
  15. packages/
  16. python_pb2/
  17. recipes/
  18. test/
  19. utils/
  20. .gitattributes
  21. .gitignore
  22. .style.yapf
  23. .yapfignore
  24. codereview.settings
  25. CONTRIBUTING.md
  26. DEPS
  27. LICENSE
  28. navbar.md
  29. OWNERS
  30. PRESUBMIT.py
  31. README.md
  32. run.py
  33. test.py
  34. WATCHLISTS
  35. WHITESPACE
README.md

infra.git repository

Testing Welcome to the Chrome Infra repository!

Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.

Entry points

  • run.py: wrapper script to run programs contained in subdirectories without having to deal with sys.path modifications.
  • test.py: multi-purpose script to run tests.
  • packages/infra_libs/: generally useful functions and classes
  • infra/services/: standalone programs intended to be run as daemons.
  • infra/tools: command-line tools, intended to be run by developers.
  • appengine/: many Chrome-infra-managed AppEngine applications
  • infra/experimental: for, well, experimental stuff. Once they are stabilized and reviewed, they should be moved in a more permanent place.

Miscellaneous technical stuff

  • bootstrap/: utilities to set up a proper Python virtual environment.
  • infra/path_hacks: submodules of this modules give access to modules in the build/ repository. from infra.path_hacks.common import <stg> is actually getting <stg> from build/scripts/common.
  • utils/: purpose? utils?
  • Need to bump infra/deployed to pick up changes?
    • git push origin <updated hash>:deployed
    • mail chrome-troopers@, include:
      • previously deployed hash (for quick rollback)
      • the hash you just pushed
      • the list of CLs that made this push necessary
      • the output of the git push command

Integrating tests with test.py

If you've added a new module, run your tests with test.py:

  1. Create a .coveragerc file in the root directory of the module you want to test. Take a look at another .coveragerc to see what to include in that.
  2. Create a “test” directory in the root directory of the module you want to test. Move your *_test.py files to this directory.

Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>.

Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py files in each directory of your module so Python recognizes it as a package.

Style

The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores. Use yapf (git cl format) to autoformat new code.