Google Git
Sign in
chromium / codesearch / infra / infra / e6a83db9ad07972f75a6111cbc96acacf6c9a139
commite6a83db9ad07972f75a6111cbc96acacf6c9a139[log] [tgz]
authorJason Robbins <jrobbins@chromium.org>Wed May 15 17:32:07 2019
committerCommit Bot <commit-bot@chromium.org>Wed May 15 17:32:07 2019
treed29d9cc09892c48d991907bdcaccd8b89ad89955
parent04e5427fc408870d19aa64e4989a39a450b919df [diff]
[Monorail] Fix profile page viewing.

Also in this CL: Make the form handler check EDIT_OTHER_USERS which is
a more precise permission than ADMINSTER_SITE.  And, fix the unit tests
that say that a reglar user is viewing another user's profile page to
actually use regular user permissions.

R=ehmaldonado@chromium.org

Bug: monorail:5554
Change-Id: Ib4dc1514086ac1c6d889a94cad93b89265ca92ff
Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/1612510
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Jason Robbins <jrobbins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#22976}
4 files changed
tree: d29d9cc09892c48d991907bdcaccd8b89ad89955
  1. 3pp/
  2. appengine/
  3. appengine_module/
  4. bootstrap/
  5. build/
  6. cipd/
  7. crdx/
  8. data/
  9. doc/
  10. docker/
  11. glyco/
  12. go/
  13. infra/
  14. node/
  15. packages/
  16. recipes/
  17. test/
  18. utils/
  19. .gitattributes
  20. .gitignore
  21. codereview.settings
  22. CONTRIBUTING.md
  23. DEPS
  24. LICENSE
  25. navbar.md
  26. OWNERS
  27. PRESUBMIT.py
  28. README.md
  29. run.py
  30. test.py
  31. WATCHLISTS
  32. WHITESPACE
README.md

infra.git repository

Welcome to the Chrome Infra repository!

Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.

Entry points

  • run.py: wrapper script to run programs contained in subdirectories without having to deal with sys.path modifications.
  • test.py: multi-purpose script to run tests.
  • packages/infra_libs/: generally useful functions and classes
  • infra/services/: standalone programs intended to be run as daemons.
  • infra/tools: command-line tools, intended to be run by developers.
  • appengine/: many Chrome-infra-managed AppEngine applications
  • infra/experimental: for, well, experimental stuff. Once they are stabilized and reviewed, they should be moved in a more permanent place.

Miscellaneous technical stuff

  • bootstrap/: utilities to set up a proper Python virtual environment.
  • infra/path_hacks: submodules of this modules give access to modules in the build/ repository. from infra.path_hacks.common import <stg> is actually getting <stg> from build/scripts/common.
  • utils/: purpose? utils?
  • Need to bump infra/deployed to pick up changes?
    • git push origin <updated hash>:deployed
    • mail chrome-troopers@, include:
      • previously deployed hash (for quick rollback)
      • the hash you just pushed
      • the list of CLs that made this push necessary
      • the output of the git push command

Integrating tests with test.py

If you've added a new module, integrate your tests with test.py:

  1. Create a .coveragerc file in the root directory of the module you want to test. Take a look at another .coveragerc to see what to include in that.
  2. Create a “test” directory in the root directory of the module you want to test. More your *_test.py files to this directory.

Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>.

Tests still not getting picked up by test.py? Double-check to make sure you have init.py files in each directory of your module so Python recognizes it as a package.