| commit | 3cd7b5bf7f6ce32dd785161c25f04af05131b8d8 | [log] [tgz] |
|---|---|---|
| author | Justin Cohen <justincohen@google.com> | Mon Mar 13 17:13:40 2023 |
| committer | Crashpad LUCI CQ <crashpad-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Mar 15 00:49:36 2023 |
| tree | fd64e97f49b000dc786aa356b7da4a5e8bad23b8 | |
| parent | 322eaa585019f3a16b9951667a6e38ff7f8cd05d [diff] |
ios: Fix crash in ObjcExceptionPreprocessor. ObjcExceptionPreprocessor is a 'reasonable effort' attempt to catch an NSException minidump at time the exception is thrown as opposed to when the application terminates due to the exception. If multiple exceptions are thrown at the same time, Crashpad should correctly report the final uncaught exception, but the minidump may not represent the full `caught-at-thrown` minidump. - Don't assume ObjcExceptionPreprocessor throws an NSException. - Don't retain/release the exception. Instead of calling isEqual, just use a simple pointer comparison. - Make last_exception atomic. Bug: crashpad: 445, 446 Change-Id: I9f2f2041e96aa9818c63937025e507487ae9d03d Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4317110 Reviewed-by: Ben Hamilton <benhamilton@google.com> Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org>
Crashpad is a crash-reporting system.
Crashpad’s source code is hosted in a Git repository at https://chromium.googlesource.com/crashpad/crashpad.