commit | 5b83e58771e25f7e7c8c84e854defa8f464457a2 | [log] [tgz] |
---|---|---|
author | Scott Graham <scottmg@chromium.org> | Wed Dec 07 19:35:07 2016 |
committer | Scott Graham <scottmg@chromium.org> | Wed Dec 07 20:03:45 2016 |
tree | 2a07bc925e7b19e6e8b74193b1c3308ef5a6c771 | |
parent | 777634b1ebad7149d0af41686f1f36126b4ea984 [diff] |
win: Remove use of rpcrt4 and advapi32 from some util code ConvertStringSecurityDescriptorToSecurityDescriptor() is used when creating the initial connection pipe. Because this is done from inside DllMain(), we cannot use advapi32 (where this function is). Instead, save the binary representation of the self-relative SECURITY_DESCRIPTOR. It is conceivable that this could change, but unlikely as this is the same blob that would be stored on a file in NTFS. Another potential approach would be to not make the pipe available to all integrity levels here, and instead modify the Chromium sandbox code to allow a specific pipe name prefix that would have to correspond with the pipe name that Crashpad creates. Similarly, UuidCreate() (used when initializing the database) is in a DLL that can't be loaded early, so use the Linux/Android implementation on Windows too. R=mark@chromium.org BUG=chromium:655788,chromium:656800 Change-Id: I434f8e96fc275fc30d0a31208b025bfc08595ff9 Reviewed-on: https://chromium-review.googlesource.com/417223 Reviewed-by: Mark Mentovai <mark@chromium.org>
Crashpad is a crash-reporting system.
Crashpad’s source code is hosted in a Git repository at https://chromium.googlesource.com/crashpad/crashpad.