|author||Nico Weber <email@example.com>||Fri Feb 07 20:46:11 2020|
|committer||Commit Bot <firstname.lastname@example.org>||Fri Feb 07 23:42:19 2020|
arm: Properly mark _ZN8crashpad14CaptureContextEP10ucontext_t as %function lld wants to remove bl/blx substitution for non-function symbols (https://reviews.llvm.org/D73542). GNU ld apparently already doesn't do it. Since _ZN8crashpad14CaptureContextEP10ucontext_t wasn't marked as a function, chromium's thumb code would then branch without mode transition into crashpads non-thumb assembly (in arm32). So mark the symbol as function, so that things work even if that patch relands. This should also make things work with GNU ld, though I haven't verified that it was broken before and works now. I also did this for aarch64 since it seems like The Right Thing To Do (assuming the assembler accepts it, which I also haven't checked -- the CQ will hopefully check that). Bug: chromium:1049649 Change-Id: I3452c16f0d52a2dc0397fd3d60d06b5c39a4b524 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2044144 Reviewed-by: Mark Mentovai <email@example.com> Commit-Queue: Nico Weber <firstname.lastname@example.org>
Crashpad is a crash-reporting system.
Crashpad’s source code is hosted in a Git repository at https://chromium.googlesource.com/crashpad/crashpad.