|author||Peter Kasting <email@example.com>||Wed Jun 09 14:01:18 2021|
|committer||Crashpad LUCI CQ <firstname.lastname@example.org>||Wed Jun 09 14:55:50 2021|
Fix -Wc++11-narrowing in crashpad. timeval's first member's type is __kernel_old_time_t on at least Windows; this is a 32-bit type as opposed to time_t, which is a 64-bit type. As a result, casting directly to time_t results in a truncation, triggering the warning. It's not possible to cast directly to __kernel_old_time_t, since that type is not exposed here. Instead, cast to the underlying type, long, which should work correctly on all platforms. This has Year 2038 problems (which is why time_t is switching to 64-bit), which I suspect would be best fixed by a larger change like moving away from using timeval anywhere (?). I'm not really certain what all would be involved in trying to make this whole pipeline Y2038-safe, so I haven't attempted to tackle this. Bug: chromium:1216696 Change-Id: Ia335a488175b1d8e851c94b56705530bb4e421af Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2949650 Commit-Queue: Peter Kasting <email@example.com> Commit-Queue: Mark Mentovai <firstname.lastname@example.org> Reviewed-by: Mark Mentovai <email@example.com>
Crashpad is a crash-reporting system.
Crashpad’s source code is hosted in a Git repository at https://chromium.googlesource.com/crashpad/crashpad.