| commit | 94e4459eda6ec1ae5667077978a00a162796fdb6 | [log] [tgz] |
|---|---|---|
| author | Jesse McKenna <jessemckenna@google.com> | Sat Oct 18 00:10:52 2025 |
| committer | Crashpad LUCI CQ <crashpad-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Oct 20 17:39:47 2025 |
| tree | 083a6948df91a64e4e2c716be47c3133e3e7404d | |
| parent | 578db64c9d65eea122a16a623ffbf5f3f0186ccd [diff] |
Inline kBackwardsClockTolerance in header kBackwardsClockTolerance is in a header file, so it should be inlined to ensure it's not duplicated across translation units. This fixes the following Chromium presubmit warning: Consider inlining constexpr variable definitions in headers outside of classes to avoid unnecessary copies of the constant. See https://abseil.io/tips/168 for more details. third_party\crashpad\crashpad\handler\crash_report_upload_rate_limit.h: 29 constexpr int kBackwardsClockTolerance = 60 * 60 * 24; // 1 day Bug: 42310127 Change-Id: Ie37ec72f62f5e3ee8c8080e5e1dd951a575e248a Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/7056627 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Jesse McKenna <jessemckenna@google.com>
Crashpad is a crash-reporting system.
Crashpad’s source code is hosted in a Git repository at https://chromium.googlesource.com/crashpad/crashpad.