| commit | 6dadd492b890f11f236d71b493a084e30e78f358 | [log] [tgz] |
|---|---|---|
| author | Joshua Peraza <jperaza@chromium.org> | Wed Nov 06 18:00:13 2019 |
| committer | Commit Bot <commit-bot@chromium.org> | Thu Nov 07 16:54:17 2019 |
| tree | 88a9defb6d9e112b5e10f57c29dd95aaa1643527 | |
| parent | 27322abb7ec40f46020f93b3814c19f77ea2ccfb [diff] |
linux: fix proc stat reader flakiness ProcStatReader.Threads is flaky because it relies on an internal, imprecise measurement of boot time. The flaky test asserts that a thread started after the main thread should have a start time >= the main thread. The start time is returned in a timeval, with microsecond precision, but the measurement of boot time requires two system calls and the time between those system calls can be approximately a microsecond. An unlucky event such as a change in system time could make this imprecision arbitrarily bad. This patch lets the caller of ProcStatReader.StartTime() inject the boot time, allowing ProcStatReader to guarantee that threads have correctly ordered time, given the same input boot time. Bug: 1016765 Change-Id: I6e4a944a1d58c3916090bab6a4b99573e71a89fc Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1891588 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Crashpad is a crash-reporting system.
Crashpad’s source code is hosted in a Git repository at https://chromium.googlesource.com/crashpad/crashpad.