|author||Scott Graham <firstname.lastname@example.org>||Fri Mar 22 20:59:56 2019|
|committer||Commit Bot <email@example.com>||Fri Mar 22 21:45:00 2019|
fuchsia: Suspend process before manipulating it This was broken by yours truly in https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1057833/, probably because I couldn't decide whether to do it in HandleException() or HandleExceptionHandles() (or possibly I'm just a dope). In any case, suspending in HandleExceptionHandles() is fine, the thread for the exception will be suspended on entry, so suspending other threads after the initial excepting thread's koid to handle lookup is OK. This avoids a bunch of logspam like: zx_thread_read_state(ZX_THREAD_STATE_GENERAL_REGS): ZX_ERR_BAD_STATE (-20) and presumably will fix non-excepting-thread stacks being completely broken? Bug: fuchsia:DX-1190 Test: run `crasher write0_mt` on device Change-Id: I029537aba2955d4f055471bf36a4e9a0f8ef2d5e Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1536268 Reviewed-by: Francois Rousseau <firstname.lastname@example.org> Reviewed-by: Joshua Peraza <email@example.com> Reviewed-by: Mark Mentovai <firstname.lastname@example.org> Commit-Queue: Scott Graham <email@example.com>
Crashpad is a crash-reporting system.
Crashpad’s source code is hosted in a Git repository at https://chromium.googlesource.com/crashpad/crashpad.