|author||Ben Hamilton <firstname.lastname@example.org>||Tue May 24 16:26:22 2022|
|committer||Crashpad LUCI CQ <email@example.com>||Tue May 24 18:15:58 2022|
[ios] Fix two shutdown races There were two shutdown races in the iOS Crashpad client: 1) MachMessageServer::Run can return either MACH_RCV_PORT_CHANGED *or* MACH_RCV_INVALID_NAME based on the timing of when the port is closed, for example: https://github.com/mattgallagher/CwlPreconditionTesting/blob/c21f7bab5ca8eee0a9998bbd17ca1d0eb45d4688/Sources/CwlPreconditionTesting/CwlCatchBadInstruction.swift#L131 2) The iOS crashpad::CrashHandler thread could read from its member variable mach_handler_running_ while another thread wrote to it Change-Id: I696ece8575d9b88cbd0593e7c479bd4c7f863f45 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3651395 Reviewed-by: Justin Cohen <firstname.lastname@example.org> Reviewed-by: Mark Mentovai <email@example.com> Commit-Queue: Justin Cohen <firstname.lastname@example.org>
Crashpad is a crash-reporting system.
Crashpad’s source code is hosted in a Git repository at https://chromium.googlesource.com/crashpad/crashpad.