commit | 6bf5e1b5c5038eaefd812f0027ff011153ae30c9 | [log] [tgz] |
---|---|---|
author | André Kempe <andre.kempe@arm.com> | Tue Mar 05 08:38:47 2024 |
committer | Crashpad LUCI CQ <crashpad-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Mar 15 14:10:46 2024 |
tree | 2c773e69667dd3015a718b0af160b72cd2e0d0d7 | |
parent | dea283a7ebf80632298b334397fedd7e70244c9e [diff] |
Fix invalid check for valid key of Pointer Authentication Arm's Pointer Authentication uses two keys for signing pointers, A-key and B-key. Although by default Clang uses the A-key if PAC support is enabled at compile time, this behaviour might be overridden via compiler command line. This CL fixes the check for the B-key being enabled. The key that shall be used for Pointer Authentication is denoted by bits 0 (A-key) or 1 (B-key) of __ARM_FEATURE_PAC_DEFAULT. Hence, the previous way of checking by using bits 0 and 2 does not correctly identify the B-key. Bug: 40608466 Change-Id: Ib2f226baa12a7145fa0b6e486e49d36e6b0a3cd7 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5341090 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org>
Crashpad is a crash-reporting system.
Crashpad’s source code is hosted in a Git repository at https://chromium.googlesource.com/crashpad/crashpad.