)]}' { "log": [ { "commit": "bcf0907dce93effa6c7dafaa1c0f5ce38f3592a9", "tree": "2eed1dfdb7dd7c1f6c3deaf424b435d2e26fb7e0", "parents": [ "1504959fd717557a13e20ac7da360e166d6e6a13" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Tue Sep 20 18:52:42 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Sep 20 20:46:05 2022" }, "message": "Update vboot_reference to resolve kernel munging issue\n\nFutility does some munging of the kernel data if the arch is x86 or\namd64, and this breaks booting through the kernel\u0027s EFI boot\nstub. Futility has now been updated to not do that munging if the kernel\nhas the EFI boot stub enabled, so in gen_disk we can now pass in\narch\u003damd64, resolving a long-standing todo.\n\nBUG\u003db:238316304\nTEST\u003dcargo xtask setup \u003cimage\u003e\nTEST\u003dcargo xtask check\nTEST\u003dcargo xtask update-disk\nTEST\u003dcargo xtask qemu\nTEST\u003dcargo xtask qemu --ia32\n\nChange-Id: I87de9dd20432e2f6c88265f3f891156996311122\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3908289\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nReviewed-by: Jeffery Miller \u003cjefferymiller@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Jeffery Miller \u003cjefferymiller@google.com\u003e\n" }, { "commit": "1504959fd717557a13e20ac7da360e166d6e6a13", "tree": "f2cb8eb5c4217bb737ead2f029823482bf301d05", "parents": [ "ed1f1124093eae9f14500f95e60dd706493312bc" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Tue Sep 13 14:45:58 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Sep 20 16:15:41 2022" }, "message": "libcrdy: Use explicit page allocation for big buffers\n\nAdd `ScopedPageAllocation`, which uses the UEFI page allocator to\nallocate memory, and use it to allocate the workbuf and kernel buffer\nthat are passed to vboot.\n\nBackground:\n\nThe vboot fwlib entrypoint requires two big buffers: one for the workbuf\nfrom which it makes smaller allocations, and one for the kernel\ndata. Prior to this commit we used a `Vec` for both. The Rust allocator\nwe are using to allocate the memory for `Vec` is provided by uefi-rs,\nwhich allocates this memory using the UEFI pool allocator, and requests\na memory type of LOADER_DATA.\n\nUsing LOADER_DATA is fine for the workbuf, but we should use LOADER_CODE\nfor the kernel data since it\u0027s executable. It\u0027s not possible to specify\nthat through the Rust allocator interface, so we need to directly call\nUEFI allocation methods. Technically we could use either the pool\nallocator or the page allocator, but since the size of the buffers we\nwant to allocate are page-aligned anyway, we might as well use the page\nallocator.\n\nThis commit implements `ScopedPageAllocation` which uses the UEFI page\nallocator internally rather than the pool allocator, and allows the\ncaller to specify details of how the memory is allocated.\n\nBUG\u003db:246550243\nTEST\u003dcargo xtask check \u0026\u0026 cargo xtask update-disk\nTEST\u003dcargo xtask qemu\nTEST\u003dcargo xtask qemu --ia32\n\nChange-Id: Iafd2e4b19dca0dd88256fe0ed2a82c0472a6b0b7\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3899155\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nReviewed-by: Jeffery Miller \u003cjefferymiller@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Jeffery Miller \u003cjefferymiller@google.com\u003e\n" }, { "commit": "ed1f1124093eae9f14500f95e60dd706493312bc", "tree": "1ffcfbb95c3f7caa02bf65a8362e19c0c6ed2728", "parents": [ "68027c6e6784eebedc2d95ce89ff1586d09fe929" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Tue Sep 13 15:07:59 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Sep 15 17:06:29 2022" }, "message": "Move workbuf and kernel allocations up to libcrdy\n\nChange vboot to take slices for the workbuf and kernel buffer instead of\nallocating them itself. The allocation is now done in libcrdy.\n\nThis is a precursor to changing how these buffers are allocated, using\nUEFI-specific methods that are available in libcrdy but not in the vboot\npackage.\n\nNote that vboot still has a dependency on `alloc` because a few internal\nfunctions call `malloc`, which we are supplying through a bridge that\nuses the Rust allocator.\n\nBUG\u003db:246550243\nTEST\u003dcargo xtask check \u0026\u0026 cargo xtask update-disk\nTEST\u003dcargo xtask qemu\nTEST\u003dcargo xtask qemu --ia32\n\nChange-Id: Ic63de75035ce9381c282230d87d69447c35163f6\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3899154\nCommit-Queue: Ted Brandston \u003ctbrandston@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nReviewed-by: Ted Brandston \u003ctbrandston@google.com\u003e\n" }, { "commit": "68027c6e6784eebedc2d95ce89ff1586d09fe929", "tree": "062d5bd934ac0d86da70102b48c5b4063c79d378", "parents": [ "332d56f4bd8e438afd3659ae51beb14c1452de51" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Tue Sep 13 19:05:02 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Sep 14 19:57:14 2022" }, "message": "Enable raw pointer checks in Miri\n\nThese checks are enabled by default in current Miri (see version\nhttps://github.com/rust-lang/miri/pull/2275), but that\u0027s not yet the\ncase in the somewhat older toolchain we have pinned.\n\nEnabling raw pointer checks revealed some issues in the stream\nimplementation. Fixed by making use of the fact that we only allow one\nstream per disk, so we can use the same pointer for both the disk handle\nand the stream handle.\n\nBUG\u003db:238316000\nTEST\u003dcargo xtask check \u0026\u0026 cargo xtask update-disk\nTEST\u003dcargo xtask qemu\nTEST\u003dcargo xtask qemu --ia32\n\nChange-Id: I0e3a3eae6d3d5a83f41fa1e4661815e3bd13164e\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3894035\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Jeffery Miller \u003cjefferymiller@google.com\u003e\nReviewed-by: Jeffery Miller \u003cjefferymiller@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "332d56f4bd8e438afd3659ae51beb14c1452de51", "tree": "6f519124059983efcbaa39cd9fe64f118282ade3", "parents": [ "cc32022f77040e23f0f27d328e98853cb509fe89" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Wed Sep 14 16:49:45 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Sep 14 17:59:05 2022" }, "message": "vboot: Move read/write code into the Disk impl\n\nChange VbExDiskRead and VbExDiskWrite so that most of the implementation\nis part of `Disk`. This is a precursor to some Miri cleanups in the next\ncommit.\n\nBUG\u003db:238316000\nTEST\u003dcargo xtask check \u0026\u0026 cargo xtask update-disk\nTEST\u003dcargo xtask qemu\nTEST\u003dcargo xtask qemu --ia32\n\nChange-Id: I2f85f7e67623efca6f2da8c3d3ea839696b46f5a\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3895362\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nReviewed-by: Jeffery Miller \u003cjefferymiller@google.com\u003e\nCommit-Queue: Jeffery Miller \u003cjefferymiller@google.com\u003e\n" }, { "commit": "cc32022f77040e23f0f27d328e98853cb509fe89", "tree": "61db396d91d6759a1babdc496b1153ffed65cc79", "parents": [ "1d80720a7a6c9e0518fb37258b8d4e35999a29d5" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Wed Sep 14 16:36:31 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Sep 14 17:48:24 2022" }, "message": "vboot: Add tests for VbExDiskRead/Write\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\n\nChange-Id: Id15c2cdc03e06dd22d67138ba7335495dff26c4a\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3895360\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nReviewed-by: Ted Brandston \u003ctbrandston@google.com\u003e\nCommit-Queue: Ted Brandston \u003ctbrandston@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "1d80720a7a6c9e0518fb37258b8d4e35999a29d5", "tree": "439e26af2608e5baba9ec47ae6e57bead5d38fec", "parents": [ "1524e8a66ef91195ec1ae755be62e6df393541de" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Wed Sep 14 16:08:02 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Sep 14 17:42:33 2022" }, "message": "vboot: Remove impl of DiskIo for Disk struct\n\nThis extra layer of indirection doesn\u0027t serve a purpose and arguably\nmakes the code more confusing, so drop it.\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\n\nChange-Id: I86ab5a09b1a2f300ea16a476fe218ade27e8dfa4\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3895359\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nReviewed-by: Ted Brandston \u003ctbrandston@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Ted Brandston \u003ctbrandston@google.com\u003e\n" }, { "commit": "1524e8a66ef91195ec1ae755be62e6df393541de", "tree": "97a0ee0071b15d6e9160155a33e0db315d1e4287", "parents": [ "f430471e39a3100aafb0f5af596ded8aba28d685" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Wed Sep 14 15:00:37 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Sep 14 16:00:01 2022" }, "message": "Use NonZeroU64 for disk block size\n\nRather than checking in various places if `bytes_per_lba` is non-zero,\nuse `NonZeroU64` to enforce it when the value is constructed.\n\nBUG\u003dNone\nTEST\u003dcargo xtask check \u0026\u0026 cargo xtask update-disk\nTEST\u003dcargo xtask qemu\nTEST\u003dcargo xtask qemu --ia32\n\nChange-Id: Iee20d0d58e3698207644f2ef3dc8fde2692dd5b1\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3895357\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Ted Brandston \u003ctbrandston@google.com\u003e\nReviewed-by: Ted Brandston \u003ctbrandston@google.com\u003e\n" }, { "commit": "f430471e39a3100aafb0f5af596ded8aba28d685", "tree": "312ca2cfbdd6b082faee97f341ee6e731a80de02", "parents": [ "223cec9355eaf2f38d3a152b7831de7896bf077c" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Tue Sep 13 14:44:59 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Sep 13 17:13:42 2022" }, "message": "libcrdy: Add load_and_execute_kernel function\n\nMove a bit more logic from crdyboot to libcrdy. This is a precursor to\nsome memory allocation improvements.\n\nBUG\u003db:246550243\nTEST\u003dcargo xtask check \u0026\u0026 cargo xtask update-disk\nTEST\u003dcargo xtask qemu\nTEST\u003dcargo xtask qemu --ia32\n\nChange-Id: I13fc96497283a164d2a3d60da1851c7771b2e8a6\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3894031\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Ted Brandston \u003ctbrandston@google.com\u003e\nReviewed-by: Ted Brandston \u003ctbrandston@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "223cec9355eaf2f38d3a152b7831de7896bf077c", "tree": "479b8951c299668a8ffeafb161a69610f9fc34af", "parents": [ "c70617d06de0f52c5a58a60737569d8112b8e39d" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Mon Sep 12 18:33:18 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Sep 13 13:09:00 2022" }, "message": "Use BootServices::image_handle\n\nStarting in the uefi-0.17.0, the handle of the currently-running image\ncan be access with `BootServices::image_handle` rather than passing\naround an extra argument all over the place. This is particularly nice\nfor functions that previously took two `Handle` arguments; now we don\u0027t\nhave to worry about passing arguments in the wrong order.\n\nBUG\u003dNone\nTEST\u003dcargo xtask check \u0026\u0026 cargo xtask update-disk\nTEST\u003dcargo xtask qemu\nTEST\u003dcargo xtask qemu --ia32\n\nChange-Id: I84b83cadbab96cd98a2fbe55fa34dd57bea1e60a\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3891873\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Ted Brandston \u003ctbrandston@google.com\u003e\nReviewed-by: Ted Brandston \u003ctbrandston@google.com\u003e\n" }, { "commit": "c70617d06de0f52c5a58a60737569d8112b8e39d", "tree": "1161d98f9f051b62183cc6f22ff8567bd3d7b20e", "parents": [ "d7c2ef4ada4b8b004afa73c664e783b96e8daa14" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Mon Sep 12 16:25:11 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Sep 12 17:18:22 2022" }, "message": "vboot: Improve vboot fwlib logging\n\nThe log format we\u0027re using (from uefi-rs) prints the file, but vboot\njust tells us the function name. The function name is more useful than\noutputing \"printf.rs\", so place the function name into the file path for\nfwlib logs.\n\nBUG\u003db:238315229\nTEST\u003dcargo xtask check \u0026\u0026 cargo xtask update-disk \u0026\u0026 cargo xtask qemu\n\nChange-Id: Idc56d8627a4d705ba10e27614dfdec1003dacc83\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3891871\nReviewed-by: Ted Brandston \u003ctbrandston@google.com\u003e\nCommit-Queue: Ted Brandston \u003ctbrandston@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "d7c2ef4ada4b8b004afa73c664e783b96e8daa14", "tree": "fe7ed357c9cda9a290384dc5e6ac388be54da414", "parents": [ "83f2dbdda071011a78b6c105715df37c20526980" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Mon Sep 12 14:13:12 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Sep 12 17:13:22 2022" }, "message": "vboot: Update comment for choosing C target\n\nThe comment was slightly out of date, change it to point to the `cc`\ncrate\u0027s code as the canonical source for what this mapping should be:\nhttps://github.com/rust-lang/cc-rs/pull/623/files\n\nBUG\u003dNone\nTEST\u003dNone\n\nChange-Id: Ia6062dfb8ff9466feb20ed4361caf6df9a6b833d\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3891869\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nReviewed-by: Ted Brandston \u003ctbrandston@google.com\u003e\nCommit-Queue: Ted Brandston \u003ctbrandston@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "83f2dbdda071011a78b6c105715df37c20526980", "tree": "01e0028ab03e3f37ac5c850f62050ad4f54f2377", "parents": [ "03779d6209267ed6219fc88a3411c2086ed276d5" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Fri Sep 09 18:08:40 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Sep 09 19:49:24 2022" }, "message": "Upgrade to latest uefi-rs releases\n\n* Upgrade uefi from 0.16 to 0.17. The `ignore-logger-errors` feature has\n been renamed to `panic-on-logger-errors` and enabled by default, so\n turn off `default-features`.\n* Upgrade uefi-services from 0.13 to 0.14.\n* Where possible, switch from `open_protocol` to the simpler and safer\n `open_protocol_exclusive`.\n* Drop use of the deprecated `interface` field on `ScopedProtocol`.\n* Slightly clean up `device_paths_for_handle` (better return type,\n resolved a TODO)\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\nTEST\u003dcargo xtask update-disk\nTEST\u003dcargo xtask qemu\nTEST\u003dcargo xtask qemu --ia32\n\nChange-Id: I5de9d8ece7c1e2d4a4493e0254de729dd829a982\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3887659\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nReviewed-by: Steve Kendall \u003cskend@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Steve Kendall \u003cskend@google.com\u003e\n" }, { "commit": "03779d6209267ed6219fc88a3411c2086ed276d5", "tree": "bcefb4a1b9f0364217ce897581db0eddd6f6159d", "parents": [ "016479b3e1ec2e16d3872f4719790e00f9cfb14c" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Fri Sep 09 17:47:48 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Sep 09 19:05:06 2022" }, "message": "xtask: Run clippy using a uefi target\n\nChange the clippy check to use `x86_64-unknown-uefi` and\n`-Zbuild-std`. This slightly increases our coverage, and will also be\nnecessary to upgrade to the latest `uefi-rs` release due to this change:\ngithub.com/rust-osdev/uefi-rs/commit/5e0fc293832e4cbfb19555d1effae4fe56\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\n\nChange-Id: I0d8cac801c09b37d599d8f93e07df304ea6167d3\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3887280\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Steve Kendall \u003cskend@google.com\u003e\nReviewed-by: Steve Kendall \u003cskend@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "016479b3e1ec2e16d3872f4719790e00f9cfb14c", "tree": "b0d7f26b77c016b3cb179c41e2aaafcc362e2e72", "parents": [ "98258909845004106cd552fdda2efdee5a11513d" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Thu Sep 08 22:37:58 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Sep 08 23:15:13 2022" }, "message": "Upgrade to a newer nightly version\n\nSomewhat arbitrarily chosen, with the only constraint that it has miri\navailable, and is old enough to report as 1.62 which matches the current\nchroot version.\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\nTEST\u003dcargo xtask update-disk\nTEST\u003dcargo xtask qemu\nTEST\u003dcargo xtask qemu --ia32\n\nChange-Id: I6ae24430329bc9c46becdc7f5d146cbaae3a837e\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3883869\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Jeffery Miller \u003cjefferymiller@google.com\u003e\nReviewed-by: Jeffery Miller \u003cjefferymiller@google.com\u003e\n" }, { "commit": "98258909845004106cd552fdda2efdee5a11513d", "tree": "23f86b30a2ae9a61208bd708400f9fc14ea5a3a5", "parents": [ "39e94c77905ed3e3fedfa9eb2c2a36965943af03" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Thu Sep 08 22:30:51 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Sep 08 23:15:12 2022" }, "message": "Use rust-toolchain.toml to set up the toolchain\n\nI just recently learned about `rust-toolchain.conf`, which provides a\nbuilt-in way to automatically download a particular toolchain and set of\ncomponents. Replace a bunch of xtask code with this.\n\nBUG\u003dNone\nTEST\u003dRemove the toolchain first to test that it gets reinstalled:\nTEST\u003drustup toolchain uninstall nightly-2022-02-06-x86_64-unknown-linux-gnu\nTEST\u003dcargo xtask check\n\nChange-Id: I7618ee2e42271472b3ea2873b09f7705110b89e7\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3883867\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Jeffery Miller \u003cjefferymiller@google.com\u003e\nReviewed-by: Jeffery Miller \u003cjefferymiller@google.com\u003e\n" }, { "commit": "39e94c77905ed3e3fedfa9eb2c2a36965943af03", "tree": "64ee6de728d65c16baf6f43935ac6a827d433ca3", "parents": [ "1ccefb732b75f12c0321d8c65541dfed16feed47" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Wed Sep 07 21:39:59 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Sep 08 21:34:12 2022" }, "message": "vboot: Implement the stream read API\n\nDrop use of `vboot_api_stub_stream.c` and directly implement the\n`VbExStream*` functions. This is to avoid depending on anything outside\nthe public vboot API.\n\nBUG\u003db:None\nTEST\u003dcargo xtask check\nTEST\u003dcargo xtask update-disk\nTEST\u003dcargo xtask qemu\nTEST\u003dcargo xtask qemu --ia32\n\nChange-Id: Ie2ba24eadd8997841f9e92ccc2eab37487e58b20\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3879984\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nReviewed-by: Jeffery Miller \u003cjefferymiller@google.com\u003e\nCommit-Queue: Jeffery Miller \u003cjefferymiller@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "1ccefb732b75f12c0321d8c65541dfed16feed47", "tree": "970261712420a1e5cbd3b42590e84901913c4c8e", "parents": [ "ad6feb0733142c22999967f2e14d09c1a7335a7b" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Thu Sep 08 17:08:50 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Sep 08 20:05:01 2022" }, "message": "Move vboot-return-code-string generation to xtask\n\nBackground: the vboot C library uses a return code enum to represent\nsuccess and errors. Numeric return codes can be a bit tricky to manually\nmatch back to the symbol. The values in the C header are constructed\nwith addition and autoincrement, so you can\u0027t just grep. To work around\nthis, we generate a conversion function `vboot::return_code_to_str` that\ntakes a `ReturnCode` and returns the associated symbol name as a string.\n\nPrior to this commit, that code generation was done at build time in the\nvboot package\u0027s build script. In the interest of avoiding build breakage\nif internal details in vboot_reference change, move the code generation\ninto xtask. `cargo xtask gen-vboot-return-code-strings` will generate\nthe `vboot/src/return_codes.rs` file. That file is checked into git, so\nin general devs don\u0027t need to worry about generating it. The list of\ncodes isn\u0027t expected to change often, and it\u0027s not critical that the\nconversion function be entirely up to date, as it\u0027s just used to improve\nlog output.\n\nBUG\u003dNone\nTEST\u003dcargo xtask gen-vboot-return-code-strings\nTEST\u003dcargo xtask check\n\nChange-Id: If87f83083d501a92663d1ab0d1aa498d6d08d974\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3883859\nReviewed-by: Ted Brandston \u003ctbrandston@google.com\u003e\nCommit-Queue: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "ad6feb0733142c22999967f2e14d09c1a7335a7b", "tree": "80f5bb6551131edf6251ee4353b55405998fea39", "parents": [ "3c3fe0419f40c985295cc147ff440934a8490532" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Thu Sep 08 16:30:32 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Sep 08 19:08:48 2022" }, "message": "Drop libflashrom-dev from readme\n\nWe build futility with `USE_FLASHROM\u003d0` now, so this dep isn\u0027t needed\nanymore.\n\nBUG\u003dNone\nTEST\u003dNone\n\nChange-Id: I596d33de3585301a95fe546c3d013a09d58457ef\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3883855\nReviewed-by: Jeffery Miller \u003cjefferymiller@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Jeffery Miller \u003cjefferymiller@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "3c3fe0419f40c985295cc147ff440934a8490532", "tree": "c14e0f8e382fe88108448c5ef12da7c394968a7b", "parents": [ "37a582650bd37b7f8f4b2424612ec2c240968746" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Thu Sep 08 16:06:05 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Sep 08 16:30:38 2022" }, "message": "xtask: Build futility without flashrom\n\nThe flashrom headers have changed and started causing errors, fix by\nbuilding without flashrom support.\n\nBUG\u003dNone\nTEST\u003dcargo xtask check, verify futility is rebuilt\n\nChange-Id: Ic90c02b8e81af884ad2764b270d15e7f0fb35d0d\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3883477\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nReviewed-by: Jeffery Miller \u003cjefferymiller@google.com\u003e\nCommit-Queue: Jeffery Miller \u003cjefferymiller@google.com\u003e\n" }, { "commit": "37a582650bd37b7f8f4b2424612ec2c240968746", "tree": "1c89b1bcde0e1dc069e32c404e0ba83917db8076", "parents": [ "e46db2917fdc0d5090fdb476d0e6f14042550e4b" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Wed Sep 07 19:41:29 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Sep 07 21:56:14 2022" }, "message": "vboot: Cleanups in bindgen and build.rs\n\n* bindgen: remove some unnecessary functions and types.\n* bindgen header: drop the `vb2api_inject_kernel_subkey` declaration,\n this is part of vboot_reference now. Also drop an unnecessary unused\n include.\n* bridge library: re-enable some warnings that are no longer triggered.\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\n\nChange-Id: I42b15de9705256bdc30f107e7cd8fc92a752d0d3\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3879686\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Jeffery Miller \u003cjefferymiller@google.com\u003e\nReviewed-by: Jeffery Miller \u003cjefferymiller@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "e46db2917fdc0d5090fdb476d0e6f14042550e4b", "tree": "277c2bbd7a26410d88861baffc71ba6231c688a2", "parents": [ "268056d7b637255c4aea8a3af00bdcf681522dca" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Wed Sep 07 17:08:05 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Sep 07 19:48:16 2022" }, "message": "Update copyright headers to match the latest preferred style\n\nRemove \"All rights reserved\" from a few files that still had it, and\ndrop the period on the first line.\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\n\nChange-Id: I2cae46e96c6e6b19603c6f45478788bc0873d769\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3879822\nReviewed-by: Jeffery Miller \u003cjefferymiller@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Jeffery Miller \u003cjefferymiller@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "268056d7b637255c4aea8a3af00bdcf681522dca", "tree": "d78a524883f8c910a833b81b59052f866a65ecb7", "parents": [ "e7aed1c4b74b1265f6158174b9b7f32a8b7189e8" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Wed Sep 07 18:43:30 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Sep 07 19:35:15 2022" }, "message": "Update readme\n\nVarious updates and cleanups, more links, better description of the\nvarious packages.\n\nBUG\u003dNone\nTEST\u003dNone\n\nChange-Id: I31138fce07c970e637267300a7ee8338f6ed68d7\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3879823\nReviewed-by: Ted Brandston \u003ctbrandston@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "e7aed1c4b74b1265f6158174b9b7f32a8b7189e8", "tree": "e31258a08f0ddfb86ff228117d89d14608479663", "parents": [ "7080f094dab5d5e8c8370ce55b81af8d1fec2e14" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Wed Sep 07 15:07:18 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Sep 07 16:06:58 2022" }, "message": "vboot: Use upstream vb2api_inject_kernel_subkey\n\nNow that https://crrev.com/c/3732807 has been merged, update the\nvboot_reference submodule and drop vboot/src/bridge.c.\n\nBUG\u003db:237093169\nTEST\u003dcargo xtask check\nTEST\u003dcargo xtask update-disk\nTEST\u003dcargo xtask qemu\nTEST\u003dcargo xtask qemu --ia32\n\nChange-Id: I8f4ab562e42860c0b905ddab5d5f230a7ba35332\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3879130\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Jeffery Miller \u003cjefferymiller@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nReviewed-by: Jeffery Miller \u003cjefferymiller@google.com\u003e\n" }, { "commit": "7080f094dab5d5e8c8370ce55b81af8d1fec2e14", "tree": "20427cd7dbb379bfe38535a8cb3854fb403bc6c6", "parents": [ "62e9a788160e6ef6365f4cfccccac2f5f7ed9136" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Wed Sep 07 14:56:00 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Sep 07 15:36:09 2022" }, "message": "vboot: Rerun build.rs if the vboot submodule changes\n\nEmit a `cargo:rerun-if-changed\u003d\u003cpath\u003e` for the vboot_reference submodule\nso that build.rs will be automatically rerun for any change in that\ndirectory. (That directive is recursive if `\u003cpath\u003e` is a directory:\nhttps://doc.rust-lang.org/cargo/reference/build-scripts.html#rerun-if-changed).\n\nBUG\u003db:237093169\nTEST\u003dcargo xtask build, rebuilds occurs\nTEST\u003dcargo xtask build, no rebuild occurs\nTEST\u003dCreate a new file under third_party/vboot_reference\nTEST\u003dcargo xtask build, rebuilds occurs again\n\nChange-Id: I13ff3160185e15e30920f720b91ea23489fc8fa1\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3879129\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Jeffery Miller \u003cjefferymiller@google.com\u003e\nReviewed-by: Jeffery Miller \u003cjefferymiller@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "62e9a788160e6ef6365f4cfccccac2f5f7ed9136", "tree": "ecb8e5eb554c244f342c4732b44ae5a1065f4f3c", "parents": [ "8116e0e008a20f60fdcccaed8f8c648ad109708b" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Thu Sep 01 21:20:12 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Sep 01 21:41:54 2022" }, "message": "xtask: Update gpt_disk_types dependency\n\nLatest version allows the implicit dependency on bytemuck to be removed.\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\n\nChange-Id: If1396708a3b4114ec44cf56a07e0582fd3320e5c\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3869428\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nReviewed-by: Jeffery Miller \u003cjefferymiller@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Jeffery Miller \u003cjefferymiller@google.com\u003e\n" }, { "commit": "8116e0e008a20f60fdcccaed8f8c648ad109708b", "tree": "3df1e9815ffa26a4896c792b607823f12982cdcf", "parents": [ "29692a506ff2c9791c9956d20d17ced00cb9fb57" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Thu Sep 01 20:37:38 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Sep 01 21:33:45 2022" }, "message": "vboot: Clean up bridge library\n\n* Drop 2stub_hwcrypto.c, this file is already part of the firmware\n library.\n* Drop a couple `-Wno-` flags that aren\u0027t needed anymore.\n\nTEST\u003drm -r target\nTEST\u003dcargo xtask check\nTEST\u003dcargo xtask update-disk \u0026\u0026 cargo xtask qemu\n\nChange-Id: Ie2501fe0b2b08b05efcc73b91453a07ed38d0e24\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3869424\nReviewed-by: Jeffery Miller \u003cjefferymiller@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Jeffery Miller \u003cjefferymiller@google.com\u003e\n" }, { "commit": "29692a506ff2c9791c9956d20d17ced00cb9fb57", "tree": "cf612f28b2b1d5711008a713bd6f991394054b51", "parents": [ "b26a16d25cc7fe41ea14e12aee12e90d3308253a" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Thu Sep 01 20:44:55 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Sep 01 21:27:02 2022" }, "message": "xtask: Remove unused base64 dependency\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\n\nChange-Id: I36fdb52da37e8b51e43a2f01ce044e3141ae1ad6\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3869425\nReviewed-by: Jeffery Miller \u003cjefferymiller@google.com\u003e\nCommit-Queue: Jeffery Miller \u003cjefferymiller@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "b26a16d25cc7fe41ea14e12aee12e90d3308253a", "tree": "ce95e2bd355ca9e9348ea06800e57b5c1cd82cb9", "parents": [ "83bfa9ba2661a0a60ef84be0e2c5ffa909f6d516" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Thu Sep 01 21:04:39 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Sep 01 21:25:43 2022" }, "message": "xtask: Drop fehler dependency\n\nThis package didn\u0027t end up becoming a defacto standard the way anyhow\nand thiserror are, so drop it to make the code more idiomatic.\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\n\nChange-Id: I0777e1cf8760a42cc7b3f9482690c1bc1b01883c\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3869426\nCommit-Queue: Jeffery Miller \u003cjefferymiller@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nReviewed-by: Jeffery Miller \u003cjefferymiller@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "83bfa9ba2661a0a60ef84be0e2c5ffa909f6d516", "tree": "72ee78c334604774d5fee36fcdd24accc8ee410c", "parents": [ "a0d66a387530abfb132749f2906255f94b451722" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Thu Sep 01 13:27:39 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Sep 01 17:08:20 2022" }, "message": "Update vboot_reference submodule to latest main\n\nTEST\u003dcargo xtask check\nTEST\u003dcargo xtask update-disk\nTEST\u003dcargo xtask qemu\nTEST\u003dcargo xtask qemu --ia32\n\nChange-Id: Ic53e15b9d519a7042d3065cc49136616030fb767\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3867044\nReviewed-by: Ted Brandston \u003ctbrandston@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Ted Brandston \u003ctbrandston@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "a0d66a387530abfb132749f2906255f94b451722", "tree": "c277aec80912792cd1a1b3b26ed3733d1df5127b", "parents": [ "b702b9dfd665ad48e8a504ef76da6a5447812395" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Thu Aug 25 17:04:26 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Aug 25 17:20:38 2022" }, "message": "vboot: Simplify vboot_fw linking\n\nRan into some errors while trying to get the i686 version building in\nthe chroot that were resolved by changing the details of these cargo\nlines. Since this version is compatible with the host build as well, the\ntarget conditional can be dropped.\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\n\nChange-Id: I21f99513a6472bd5b7d1f96e54492e7a117adae5\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3856728\nCommit-Queue: Ted Brandston \u003ctbrandston@google.com\u003e\nReviewed-by: Ted Brandston \u003ctbrandston@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "b702b9dfd665ad48e8a504ef76da6a5447812395", "tree": "62fa10ebe42d4eded7ab2d3955fd62097e3f1db7", "parents": [ "159a52cd5d8efd7bb6bbf2ad3a791cc89762fe88" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Mon Aug 22 20:09:31 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Aug 22 20:37:25 2022" }, "message": "Add tbrandston to OWNERS\n\nBUG\u003dNone\nTEST\u003dNone\n\nChange-Id: Ie8719c5ec864b34734965ceaa3a70cffaa76cf6e\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3846901\nReviewed-by: Ted Brandston \u003ctbrandston@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Ted Brandston \u003ctbrandston@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "159a52cd5d8efd7bb6bbf2ad3a791cc89762fe88", "tree": "e19fd47543b3be42dd62d378200c0f9f663af882", "parents": [ "1ad963d7d688deede370b9d699fc0d9d6208bb9c" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Mon Aug 22 19:19:08 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Aug 22 20:08:51 2022" }, "message": "vboot: Relax some more dependency version requirements\n\nThe version specifications are now compatible with existing packages in\nthe CrOS SDK. There should be no change in the versions that get used\noutside the chroot since higher versions are allowed.\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\n\nChange-Id: I4674765b764c1972b86e335e8a8273e57cc304c4\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3846893\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nReviewed-by: Steve Kendall \u003cskend@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Steve Kendall \u003cskend@google.com\u003e\n" }, { "commit": "1ad963d7d688deede370b9d699fc0d9d6208bb9c", "tree": "9bfb17ea7b53c7f4a9b1f7dfd7d248ecf33a2233", "parents": [ "a2a3486b7810c1dc3c224dc63f9ec9f17794c7d3" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Mon Aug 22 19:12:06 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Aug 22 20:08:49 2022" }, "message": "vboot: Avoid pulling in clap as a build-dependency\n\nThe default `bindgen` features include clap due to\nhttps://github.com/rust-lang/cargo/issues/1982. This is unnecessary for\nour use case, and pulls in a number of other unnecessary deps. Turn off\ndefault features on the `bindgen` dep and re-enable everything other\nthan `clap`.\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\n\nChange-Id: Ibdf9ea58f26f0638d97cbcfec34182ad587c93bd\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3846892\nCommit-Queue: Steve Kendall \u003cskend@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nReviewed-by: Steve Kendall \u003cskend@google.com\u003e\n" }, { "commit": "a2a3486b7810c1dc3c224dc63f9ec9f17794c7d3", "tree": "713e887e8ae65c99eda80aab0987255ad80172c2", "parents": [ "14ad615287052a7fd11f576e2efbd92bff9f123c" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Fri Aug 19 19:54:12 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Sat Aug 20 01:28:03 2022" }, "message": "Use vboot dev keys for testing\n\nThe vboot repo has devkeys in it, use those instead of generating test\nkeys in xtask. The setup version in xtask has been bumped so that the\ntest data gets resigned with the new keys.\n\nBUG\u003db:243164545\nTEST\u003dcargo xtask check\nTEST\u003dcargo xtask update-disk\nTEST\u003dcargo xtask qemu\nTEST\u003dcargo xtask qemu --ia32\n\nChange-Id: I1888df01a8305d9aaf606a0304a3f00a1fb19c52\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3840883\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Jeffery Miller \u003cjefferymiller@google.com\u003e\nReviewed-by: Jeffery Miller \u003cjefferymiller@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "14ad615287052a7fd11f576e2efbd92bff9f123c", "tree": "cc208fcf275a65ddf4b9603224d67de11a3feb19", "parents": [ "f1ca17e43f6cf60713266c81f2da8737f8c32e70" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Fri Aug 19 19:23:36 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Sat Aug 20 01:28:02 2022" }, "message": "xtask: Improve separation between vboot and secure boot keys\n\nThe `gen_keys` and `sign` module names were confusing, since both\nmodules dealt with with keys and signing. Renamed `gen_keys` -\u003e `vboot`\nand `sign` -\u003e `secure_boot`, and moved VbootKeyPaths to `vboot.rs`.\n\nBUG\u003db:243164545\nTEST\u003dcargo xtask check\n\nChange-Id: I4cb415cd3b7503fe8f85e01babcd251218a6fa35\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3840882\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nReviewed-by: Jeffery Miller \u003cjefferymiller@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Jeffery Miller \u003cjefferymiller@google.com\u003e\n" }, { "commit": "f1ca17e43f6cf60713266c81f2da8737f8c32e70", "tree": "ba353fe34833899a0640cf0cdd1ab8b5940872f8", "parents": [ "6e65c95e285b61b53a6806000144878d5badc75a" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Fri Aug 19 19:17:17 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Sat Aug 20 01:28:01 2022" }, "message": "vboot: Split up vboot and secure boot key paths\n\nSplit the KeyPaths struct into VbootKeyPaths and SecureBootKeyPaths. The\nfiles needed for each are somewhat different.\n\nBUG\u003db:243164545\nTEST\u003dcargo xtask check\n\nChange-Id: Ia42ced43452f4c9e38743d9591cd96dadab8cea1\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3840881\nReviewed-by: Jeffery Miller \u003cjefferymiller@google.com\u003e\nCommit-Queue: Jeffery Miller \u003cjefferymiller@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "6e65c95e285b61b53a6806000144878d5badc75a", "tree": "bc30b726b1f6d91ac697b1047086f8b5feb8e8b0", "parents": [ "d9ca6c015c3c31de15005f31ce00f144eb3ff120" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Fri Aug 19 18:40:08 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Sat Aug 20 01:28:00 2022" }, "message": "vboot: Respect the compiler set in CC\n\nRather than always using `clang` as the C compiler, check if something\nis set in `CC` and use that if so. If not set, the default is still clang.\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\n\nChange-Id: Ie3580b18bb1b0669367131e1cd0ee3724a8388df\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3840873\nReviewed-by: Jeffery Miller \u003cjefferymiller@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Jeffery Miller \u003cjefferymiller@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "d9ca6c015c3c31de15005f31ce00f144eb3ff120", "tree": "1f5665826dd7ac393564aca81e30d993d0022506", "parents": [ "7de77482e20a67dc8515ca18b2ad73ba8447bf82" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Thu Aug 18 20:38:15 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Aug 18 20:50:03 2022" }, "message": "vboot: Drop build dependency on camino\n\nThis dependency isn\u0027t currently packaged in CrOS. It can be easily\nreplaced here, so drop it.\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\n\nChange-Id: Id0df0d91720ce8ed28595e2dab764beec9edb4f0\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3838683\nCommit-Queue: Steve Kendall \u003cskend@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nReviewed-by: Steve Kendall \u003cskend@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "7de77482e20a67dc8515ca18b2ad73ba8447bf82", "tree": "685d4ee34be4c7c105669fe4c37070807314a9d1", "parents": [ "346fe1f3ce6bcbc47c4809b6dbe44e5c056523d0" ], "author": { "name": "Patrick Thompson", "email": "ptf@google.com", "time": "Mon Aug 15 18:09:06 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Aug 18 19:53:24 2022" }, "message": "xtask: Run tests with miri\n\nRuns the tests with miri in addition to the normal way. Some tests need\nto be excluded as miri does not support them. The no-miri switch will\ndisable miri testing.\n\nBUG\u003db/238316000\nTEST\u003dcargo xtask install-toolchain\nTEST\u003dcargo xtask check\nTEST\u003dcargo xtask test --no-miri\n\nChange-Id: I2f216c95d3c58be42fb2a482594069fb8b465c7b\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3828437\nTested-by: Patrick Thompson \u003cptf@google.com\u003e\nReviewed-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nAuto-Submit: Patrick Thompson \u003cptf@google.com\u003e\nCommit-Queue: Patrick Thompson \u003cptf@google.com\u003e\n" }, { "commit": "346fe1f3ce6bcbc47c4809b6dbe44e5c056523d0", "tree": "085d52fc8a4a20dc37af08681d6d67ad9e2ecf1b", "parents": [ "03c3a10d92bd642c49b1ae37ee2c63c7043a66c6" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Thu Aug 18 19:18:17 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Aug 18 19:26:37 2022" }, "message": "vboot: Upgrade to uguid 1.0\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\n\nChange-Id: Iefaf0c22ee1994b4560a769adf49bc9a30b96c57\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3838827\nReviewed-by: Steve Kendall \u003cskend@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Steve Kendall \u003cskend@google.com\u003e\n" }, { "commit": "03c3a10d92bd642c49b1ae37ee2c63c7043a66c6", "tree": "0786c22036f3af250b52a2c3ba8a89fb3f2ae7d9", "parents": [ "22e983c952c50a55b0a61721e4d9eafdfe18e1bf" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Thu Aug 18 19:15:29 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Aug 18 19:26:36 2022" }, "message": "vboot: Fix snprintf tests\n\nThe input strings in these tests were missing the trailing null. This\nusually happened to work, but it\u0027s not correct for a C string.\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\n\nChange-Id: I757e8dd214f4ff5f25e8358c11ae5a304fb7d599\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3838826\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Steve Kendall \u003cskend@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nReviewed-by: Steve Kendall \u003cskend@google.com\u003e\n" }, { "commit": "22e983c952c50a55b0a61721e4d9eafdfe18e1bf", "tree": "198d22bfe4fe239af00b0bd71c5a7bb859483680", "parents": [ "90f6d9ab2bf0d44a274127bb841009663a17b423" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Thu Aug 18 14:50:37 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Aug 18 16:16:38 2022" }, "message": "libcrdy: Remove scroll dependency\n\nThis isn\u0027t currently packaged in CrOS, and can be easily replaced with a\nsmall amount of code in libcrdy.\n\nBUG\u003db:243006564\nTEST\u003dcargo xtask check\nTEST\u003dcargo xtask update-disk\nTEST\u003dcargo xtask qemu\nTEST\u003dcargo xtask qemu --ia32\n\nChange-Id: Id4c8b7b5376eb467e05cefd59333f73dcfe9184b\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3838813\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nReviewed-by: Jeffery Miller \u003cjefferymiller@google.com\u003e\nCommit-Queue: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "90f6d9ab2bf0d44a274127bb841009663a17b423", "tree": "9108382a823e1d042f42f6e55c979f857ef325f7", "parents": [ "2ea7d08b074834eabdbf5c3734a4ebb2242318b2" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Mon Aug 15 19:10:37 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Aug 18 15:55:54 2022" }, "message": "libcrdy: Replace goblin with object\n\nThe object library is already packaged in CrOS, so use it instead of\ngoblin. Not using the latest version yet since that\u0027s not what\u0027s in CrOS\ncurrently.\n\nBUG\u003db:242723216\nTEST\u003dcargo xtask check\nTEST\u003dcargo xtask update-disk\nTEST\u003dcargo xtask qemu\nTEST\u003dcargo xtask qemu --ia32\n\nChange-Id: I9927c165edea091ea87939a1b737c473aaab0bfa\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3829195\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nReviewed-by: Jeffery Miller \u003cjefferymiller@google.com\u003e\n" }, { "commit": "2ea7d08b074834eabdbf5c3734a4ebb2242318b2", "tree": "8f7d6f75955426541b4fba043feea7fa659cdb66", "parents": [ "6f88a2116cae9ceb389984308a14e70fcfe16195" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Tue Aug 16 17:25:02 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Aug 18 15:55:52 2022" }, "message": "libcrdy: Simplify the PE code\n\nChange the PE code to always get both entry points (the regular entry\npoint used when booting with 64-bit firmware, and the compat entry point\nused when booting from 32-bit firmware). This will make it simpler to\nconvert the code from using `goblin` to `object`.\n\nBUG\u003db:242723216\nTEST\u003dcargo xtask check\n\nChange-Id: I8cf0d613ea9f8ebaecb804c741f3c39f6f4bd297\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3829194\nReviewed-by: Jeffery Miller \u003cjefferymiller@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "6f88a2116cae9ceb389984308a14e70fcfe16195", "tree": "127bb2bd06043762a5a192ee5f0f57be90e66cfb", "parents": [ "f58eabea65a3c1c6d1b4ea5e65aa48dbcb796e83" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Tue Aug 16 17:30:15 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Aug 18 15:39:12 2022" }, "message": "libcrdy: Rename Error::KernelTooOld\n\nGive the error a more specific name: Error::MissingIa32CompatEntryPoint\n\nBUG\u003db:242723216\nTEST\u003dcargo xtask check\n\nChange-Id: I000ae200843c0eb5f05cd507840284f80e8a8753\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3829193\nCommit-Queue: Jeffery Miller \u003cjefferymiller@google.com\u003e\nReviewed-by: Jeffery Miller \u003cjefferymiller@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "f58eabea65a3c1c6d1b4ea5e65aa48dbcb796e83", "tree": "7a74b2974090db587e5cc79e829ae43ee5411944", "parents": [ "ffddfb4b21411e1dab2b9469e551563f27c20139" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Mon Aug 15 17:42:52 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Aug 17 17:16:27 2022" }, "message": "libcrdy: Improve safety of entry_point_from_offset\n\nCheck that the entry point is within the kernel data allocation before\nusing it. Also avoid an conversion from pointer to usize to function\npointer by using pointer::add.\n\nAlso renamed Error::KernelTooSmall to Error::OutOfBounds to make it more\ngeneral.\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\nTEST\u003dcargo xtask update-disk \u0026\u0026 cargo xtask qemu\n\nChange-Id: Iec7790f3b25ee2011c6c6fbfa854d05b8578a113\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3828435\nReviewed-by: Steve Kendall \u003cskend@google.com\u003e\nCommit-Queue: Steve Kendall \u003cskend@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "ffddfb4b21411e1dab2b9469e551563f27c20139", "tree": "1033758b3b86ea16013f8393c0da2203fca2e271", "parents": [ "80ecb2f0347c2082dce3c79db326ef2730322d9d" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Mon Aug 15 17:12:54 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Aug 17 17:16:26 2022" }, "message": "libcrdy: Check for overflow in more places\n\nRenamed Error::BadNumericConversion to Error::Overflow to make it more\ngeneral, and use checked operations in get_u32_field and\nentry_point_from_offset.\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\n\nChange-Id: Ifb21eac4b073f47d2df605acd9552aa6b3bf36cf\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3828433\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Steve Kendall \u003cskend@google.com\u003e\nReviewed-by: Steve Kendall \u003cskend@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "80ecb2f0347c2082dce3c79db326ef2730322d9d", "tree": "7daa0751c8830afc1776965c1bd8b964ee91a196", "parents": [ "ce261f6b93d366a30987e1a9cd4dcdb510fb6228" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Fri Aug 12 19:32:10 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Aug 12 20:12:46 2022" }, "message": "Relax log dependency to any 0.4 version\n\nAny version of 0.4 should be compatible, no need to restrict to\n0.4.17+. The CrOS version of log is currently 0.4.14, so this change\nmakes the crate compatible with that.\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\n\nChange-Id: I8d64b9903e1092343f9b9015a1b130c0409b24f4\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3826184\nCommit-Queue: Jeffery Miller \u003cjefferymiller@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nReviewed-by: Jeffery Miller \u003cjefferymiller@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "ce261f6b93d366a30987e1a9cd4dcdb510fb6228", "tree": "52a6467abbc80894f6277ba406cd07eb9b79bed9", "parents": [ "6746393902982e2dd1119f7cd79569c5b7eaebda" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Tue Aug 09 16:37:08 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Aug 10 15:05:32 2022" }, "message": "Update vboot bridge to latest\n\nThe new vboot API (vb2api_inject_kernel_subkey) is still in progress in\na separate CL; update the copy here to verify it still works as expected.\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\nTEST\u003dcargo xtask update-disk\nTEST\u003dcargo xtask qemu --secure-boot\nTEST\u003dcargo xtask qemu --secure-boot --ia32\n\nChange-Id: Idf256047b14375f4aaf702c60b3e48c551d3093c\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3820802\nReviewed-by: Jeffery Miller \u003cjefferymiller@google.com\u003e\nCommit-Queue: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "6746393902982e2dd1119f7cd79569c5b7eaebda", "tree": "590ff5790334064e16c7b994b6558fdcd8cefc10", "parents": [ "2ef5df32d2ae63c8728f0a8c8da78dac4584f9b2" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Fri Aug 05 16:00:32 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Aug 10 15:05:30 2022" }, "message": "Update vboot_reference submodule to latest\n\nSome vboot functions and types have been renamed:\nhttps://chromium.googlesource.com/chromiumos/platform/vboot_reference/+/18cb85b52d689b4cfbd49c6384ae2088b78af1e0\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\nTEST\u003dcargo xtask update-disk\nTEST\u003dcargo xtask qemu --secure-boot\nTEST\u003dcargo xtask qemu --secure-boot --ia32\n\nChange-Id: Iad60c657cb6a23f308fc86bc99fddcc8d349adb5\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3820801\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nReviewed-by: Jeffery Miller \u003cjefferymiller@google.com\u003e\n" }, { "commit": "2ef5df32d2ae63c8728f0a8c8da78dac4584f9b2", "tree": "28d641b65ed211f92f10888bcebf115c6ddc287a", "parents": [ "4697242b0123dbeec5db88ffb673672747addd85" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Fri Aug 05 15:41:12 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Aug 05 21:44:25 2022" }, "message": "xtask: Fix vboot compilation with openssl3\n\nVboot uses functions that have been deprecated in openssl3. Set\n\"CFLAGS\u003d-Wno-deprecated-declarations\" when compiling futility to avoid\nerrors.\n\nBUG\u003dNone\nTEST\u003drm -r third_party/vboot_reference/build\nTEST\u003dcargo xtask setup\nTEST\u003dcargo xtask check\n\nChange-Id: If85842d0265aa24256098526558e94a1a408c257\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3813693\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nReviewed-by: Joseph Sussman \u003cjosephsussman@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nReviewed-by: Patrick Thompson \u003cptf@google.com\u003e\nCommit-Queue: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "4697242b0123dbeec5db88ffb673672747addd85", "tree": "64948c72b27c47a677b876ab1f92d331fb6b626d", "parents": [ "4785304742a68e9067cb25fe656feaa98b3a9493" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Fri Aug 05 16:37:15 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Aug 05 16:50:54 2022" }, "message": "readme: Describe image requirements for setup command\n\nBUG\u003db:241557362\nTEST\u003dNone\n\nChange-Id: I084cc9282a6fa18cc79165bf6a9889462278ae10\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3813694\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nReviewed-by: Joseph Sussman \u003cjosephsussman@google.com\u003e\nCommit-Queue: Joseph Sussman \u003cjosephsussman@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "4785304742a68e9067cb25fe656feaa98b3a9493", "tree": "c297a6802caad1f6e95df3c06251b16b5c784840", "parents": [ "ef5169f3221e536d1012782758797fceeaf140ac" ], "author": { "name": "Patrick Thompson", "email": "ptf@google.com", "time": "Wed Jul 27 20:34:57 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Jul 27 21:13:00 2022" }, "message": "xtask: Don\u0027t rerun setup when installing toolchain\n\nA correct toolchain is required to run setup. If the user is\ninstalling the toolchain don\u0027t run setup.\n\nBUG\u003dNone\nTEST\u003dcargo xtask install-toolchain\nTEST\u003dcargo xtask setup\n\nChange-Id: I1cfb95cc1bb92bc334abfa59692afd87f62aafd3\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3789415\nTested-by: Patrick Thompson \u003cptf@google.com\u003e\nCommit-Queue: Patrick Thompson \u003cptf@google.com\u003e\nReviewed-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "ef5169f3221e536d1012782758797fceeaf140ac", "tree": "b20b1a71cb85af43a0f60c5a495de2089f665585", "parents": [ "4a1aefa1a3e1eff46a83b761e4c201385c9b237b" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Mon Jun 27 21:21:24 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Jun 27 21:41:05 2022" }, "message": "vboot: Update vboot_reference submodule to latest\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\nTEST\u003dcargo xtask update-disk\nTEST\u003dcargo xtask qemu --secure-boot\nTEST\u003dcargo xtask qemu --secure-boot --ia32\n\nChange-Id: Ice3e3577d363e783c9d5acd53238f77933ce2fa1\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3727237\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Steve Kendall \u003cskend@google.com\u003e\nReviewed-by: Steve Kendall \u003cskend@google.com\u003e\n" }, { "commit": "4a1aefa1a3e1eff46a83b761e4c201385c9b237b", "tree": "68c7995f20c86db66ffbc2ad766c42d546fd7a2e", "parents": [ "b3241b07de507a374e13c96e36036f89b5c2fbce" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Mon Jun 27 19:00:55 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Jun 27 19:47:40 2022" }, "message": "vboot: Build fwlib using vboot_reference\u0027s Makefile\n\nInstead of manually building vboot_reference\u0027s fwlib with the `cc`\ncrate, use `make` to build it with vboot_reference\u0027s build system. This\nis better because we don\u0027t depend as much on implementation details of\nvboot_reference.\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\nTEST\u003dcargo xtask update-disk\nTEST\u003dcargo xtask qemu --secure-boot\nTEST\u003dcargo xtask qemu --secure-boot --ia32\n\nChange-Id: Ice955c96766f67292c2713c8b41a31940ba1f061\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3727232\nReviewed-by: Steve Kendall \u003cskend@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Steve Kendall \u003cskend@google.com\u003e\n" }, { "commit": "b3241b07de507a374e13c96e36036f89b5c2fbce", "tree": "18dcf4d62f96ae5817fe337822946f8ae1e077f5", "parents": [ "73126b5b898f8292be02c95a59799285021ac18a" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Mon Jun 27 18:21:53 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Jun 27 19:47:38 2022" }, "message": "vboot: Refactor target code in build script\n\nAdd a new Target enum that describes what we\u0027re building vboot for: host\ncode, such as \"cargo test\", or one of the UEFI targets. This doesn\u0027t\nchange the functionality of the build script, just a clearer way to\nexpress what was already there.\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\n\nChange-Id: Ib9eb6b6d8f8f38d1abe6e473121e5052554853c6\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3727231\nReviewed-by: Steve Kendall \u003cskend@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Steve Kendall \u003cskend@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "73126b5b898f8292be02c95a59799285021ac18a", "tree": "db4dbb0c018057910dd3fe7e4dea764e0ce5b5e4", "parents": [ "7032a13a0686e5e6442e0df73b8631b414a9360c" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Mon Jun 27 18:19:04 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Jun 27 19:37:43 2022" }, "message": "vboot: Add stub for strcpy\n\nThis function is called yet, but it will allow more of vboot\u0027s fwlib to\nbe compiled. No need to implement the stub as it\u0027s just needed for\nlinking, the only actual call site is in debug code that isn\u0027t used by\nus.\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\n\nChange-Id: I047783cb4719ff52daaf3632f2ee997c97d98e5b\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3727230\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nReviewed-by: Steve Kendall \u003cskend@google.com\u003e\nCommit-Queue: Steve Kendall \u003cskend@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "7032a13a0686e5e6442e0df73b8631b414a9360c", "tree": "b0a7bbb326b145aaa570cdbd6fe14e446a2e6c73", "parents": [ "5f62b1e677ff72de9b9d1c8a690c31967b5be86b" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Fri Jun 24 21:05:54 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Jun 24 21:57:24 2022" }, "message": "vboot: Add new entry point\n\nThe new vb2api_init_ctx_for_kernel_verification_only function is a\nprototype for adding a new entry point to vboot_reference. The goal is\nto upstream this entry point into vboot_reference so that we can be sure\nour use case is tested as part of vboot_reference and continues to\nfunction as that repo changes.\n\nThe new code is pretty much the C version of some existing Rust code in\nthe `vboot` package. `validate_packed_pubkey_size` is no longer needed\nsince that validation is now done in the entry point.\n\nBUG\u003db:237093169\nTEST\u003dcargo xtask check\nTEST\u003dcargo xtask update-disk\nTEST\u003dcargo xtask qemu --secure-boot\nTEST\u003dcargo xtask qemu --secure-boot --ia32\n\nChange-Id: I2913c8fbecc0480c3b269db6a85557b4104f3ad4\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3721285\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nReviewed-by: Steve Kendall \u003cskend@google.com\u003e\nCommit-Queue: Steve Kendall \u003cskend@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "5f62b1e677ff72de9b9d1c8a690c31967b5be86b", "tree": "b1d41282bae74a010840185fbcd9a578f30d0859", "parents": [ "bfd79f0f712fee39605ab0fb3cf73ae416855a9c" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Fri Jun 24 20:47:01 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Jun 24 21:08:46 2022" }, "message": "vboot: Reduce dependence on vboot_reference internals\n\nLink in more vboot_reference source files. This allows all the remaining\nstub functions (in stubs.rs) to be for vb2ex_* functions, which are\nintended to be implemented by users of the library.\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\nTEST\u003dcargo xtask update-disk\nTEST\u003dcargo xtask qemu --secure-boot\nTEST\u003dcargo xtask qemu --secure-boot --ia32\n\nChange-Id: Id98401b81de52737fb4519df1420990d4c71a491\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3721284\nReviewed-by: Steve Kendall \u003cskend@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Steve Kendall \u003cskend@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "bfd79f0f712fee39605ab0fb3cf73ae416855a9c", "tree": "8d921887b2a821615f1df2bbf5d13876b7068408", "parents": [ "256c8903e8dfaa622813cdc514320830fbe6f119" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Fri Jun 24 20:42:46 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Jun 24 21:08:45 2022" }, "message": "vboot: Implement snprintf\n\nThis isn\u0027t used yet, but will allow more of vboot_reference to be built\nand linked under the UEFI targets.\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\n\nChange-Id: I30dfa11e4bb7bc3e46a8c319428dd2ef3e1e7f33\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3721283\nReviewed-by: Steve Kendall \u003cskend@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Steve Kendall \u003cskend@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "256c8903e8dfaa622813cdc514320830fbe6f119", "tree": "95af4c28dc5ab47c11f3c179029a01746df383ec", "parents": [ "bbc26a106dc326d5b06d669d2ec8b3e761fab494" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Fri Jun 24 20:05:05 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Jun 24 21:08:43 2022" }, "message": "vboot: Add cty dependency to provide C type aliases\n\ncty is the standard crate for this purpose for targets that don\u0027t\nsupport std.\n\nConvert the code in printf.rs to use the cty types as well.\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\n\nChange-Id: I6ef50b250a6d24f9f16be687dde05b8a8321952d\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3721282\nReviewed-by: Steve Kendall \u003cskend@google.com\u003e\nCommit-Queue: Steve Kendall \u003cskend@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "bbc26a106dc326d5b06d669d2ec8b3e761fab494", "tree": "ccb623774546ca568d807e9ab819ff18d432c9a5", "parents": [ "4c34df6ce229d824c8c3c025749b96ef0be8ae21" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Thu Jun 23 20:33:50 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Jun 23 21:29:34 2022" }, "message": "libcrdy/crdyboot: Update clippy lints\n\nAs with vboot, enable clippy::pedantic and disable a few unwanted lints.\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\nTEST\u003dcargo xtask update-disk\nTEST\u003dcargo xtask qemu --secure-boot\nTEST\u003dcargo xtask qemu --secure-boot --ia32\n\nChange-Id: I7805ec3c4467748050bb5f8d2a59aac61d7f0fa8\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3721766\nReviewed-by: Steve Kendall \u003cskend@google.com\u003e\nCommit-Queue: Steve Kendall \u003cskend@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "4c34df6ce229d824c8c3c025749b96ef0be8ae21", "tree": "37b0a464c3386ef5b687297407638711755a811b", "parents": [ "e4419cbea2dfd6c6cd64c495cbcd25cea0d878f2" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Thu Jun 23 20:20:45 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Jun 23 21:23:52 2022" }, "message": "vboot: Update clippy lints\n\nRather than turning on a few pedantic lints, enable clippy::pedantic and\nthen turn off a few lints that we don\u0027t want.\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\nTEST\u003dcargo xtask update-disk\nTEST\u003dcargo xtask qemu --secure-boot\nTEST\u003dcargo xtask qemu --secure-boot --ia32\n\nChange-Id: If519441207e787eaf0a19e755f5e2b42f9813f51\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3721765\nReviewed-by: Steve Kendall \u003cskend@google.com\u003e\nCommit-Queue: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "e4419cbea2dfd6c6cd64c495cbcd25cea0d878f2", "tree": "54293b352a9eea6a6e98d9715e0457ea3940a4df", "parents": [ "98c443375e8469cc53e29042d76e527080a6dec0" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Thu Jun 23 19:05:49 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Jun 23 19:58:16 2022" }, "message": "vboot: Use VB2_KERNEL_WORKBUF_RECOMMENDED_SIZE for workbuf size\n\nThis trims the required size down a bit.\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\nTEST\u003dcargo xtask update-disk\nTEST\u003dcargo xtask qemu --secure-boot\nTEST\u003dcargo xtask qemu --secure-boot --ia32\n\nChange-Id: I7926a5d7e05399e4a277e8326e9a85ccf38a337f\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3721764\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nReviewed-by: Steve Kendall \u003cskend@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Steve Kendall \u003cskend@google.com\u003e\n" }, { "commit": "98c443375e8469cc53e29042d76e527080a6dec0", "tree": "590ed499b6acf08682cf25b0c583d99a1348dbeb", "parents": [ "675e92db190f5f3ddd48d810522722c574a47696" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Wed Jun 22 23:02:29 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Jun 22 23:46:04 2022" }, "message": "vboot: Add dependency on uguid\n\nThis allows some manual GUID parsing code to be removed.\n\nBUG\u003dNone\nTEST\u003dcargo xtask test\n\nChange-Id: I764fdf47aeb798c99b82178d56ab8894b07e188b\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3719102\nReviewed-by: Steve Kendall \u003cskend@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Steve Kendall \u003cskend@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "675e92db190f5f3ddd48d810522722c574a47696", "tree": "e63d49420a834cd8970affafdec7277ca4690c1f", "parents": [ "7777a0842ddd62ff3f7c742de6b3bd1ba63d3a99" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Wed Jun 22 20:46:07 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Jun 22 22:05:08 2022" }, "message": "vboot: Move linux module to libcrdy\n\nThis code is used to ensure the kernel buffer is large enough. It is not\ndirectly related to vboot.\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\nTEST\u003dcargo xtask update-disk\nTEST\u003dcargo xtask qemu --secure-boot\nTEST\u003dcargo xtask qemu --secure-boot --ia32\n\nChange-Id: I2378f07e7f5fab21164b3d6eb33b083d784cf2d1\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3716739\nCommit-Queue: Steve Kendall \u003cskend@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nReviewed-by: Steve Kendall \u003cskend@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "7777a0842ddd62ff3f7c742de6b3bd1ba63d3a99", "tree": "2650aed0f10f44f70420c23d936623f24e063004", "parents": [ "1cfc8b909a4db7965dc1d8867bcc4023443c37bf" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Wed Jun 22 20:36:59 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Jun 22 22:05:07 2022" }, "message": "vboot: Move PE code to libcrdy\n\nThis code isn\u0027t directly related to vboot.\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\nTEST\u003dcargo xtask update-disk\nTEST\u003dcargo xtask qemu --secure-boot\nTEST\u003dcargo xtask qemu --secure-boot --ia32\n\nChange-Id: Ie059435a365ef447d606473b614e8040a0ab7cff\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3716738\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Steve Kendall \u003cskend@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nReviewed-by: Steve Kendall \u003cskend@google.com\u003e\n" }, { "commit": "1cfc8b909a4db7965dc1d8867bcc4023443c37bf", "tree": "140cacf253cb7d70845f3af04136051213112f9f", "parents": [ "07c4016c544c7f4880e88df3fab975222a51db8a" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Wed Jun 22 20:21:43 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Jun 22 22:05:05 2022" }, "message": "crdyboot: Move most code to a new libcrdy package\n\nThe separate package is useful because it can be compiled for the host\ntarget, which makes it much easier to run unit tests on the code (and\npotentially Miri). This is hard to do directly in crdyboot because of\nthe uefi-services dependency, which is not compatible with non-uefi\ntargets (unlike the uefi library itself).\n\nCurrently there\u0027s also a fair amount of code in the vboot package that\nisn\u0027t actually related to vboot, but is there because it\u0027s easier to\ntest. That code will be moved to libcrdy in a later commit, for now just\nmove most of the crdyboot code to libcrdy.\n\n\"xtask cargo test\" now runs tests in libcrdy, although there aren\u0027t any\nthere yet.\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\nTEST\u003dcargo xtask update-disk\nTEST\u003dcargo xtask qemu --secure-boot\nTEST\u003dcargo xtask qemu --secure-boot --ia32\n\nChange-Id: I1cebb9dc836ed2a7f597cc6104cc4fb23a54e65d\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3716737\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nReviewed-by: Steve Kendall \u003cskend@google.com\u003e\nCommit-Queue: Steve Kendall \u003cskend@google.com\u003e\n" }, { "commit": "07c4016c544c7f4880e88df3fab975222a51db8a", "tree": "4aa9f75766d415c6e73a568703bf294497556b49", "parents": [ "0ff98e9d5aa08981dc8332f4a482b1e197f6484e" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Wed Jun 22 19:05:23 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Jun 22 19:19:03 2022" }, "message": "xtask: Rename crdyboot_tools package to xtask\n\nThis is just for consistency, it\u0027s confusing that the directory name\ndoesn\u0027t match the package name. This also matches the xtask doc:\nhttps://github.com/matklad/cargo-xtask\n\nAlso mark the xtask package with `publish \u003d false`, this is purely an\ninternal package.\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\n\nChange-Id: Iba8727e2d131a3f841f80d539d62b2e70f45d7a3\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3716736\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nReviewed-by: Steve Kendall \u003cskend@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Steve Kendall \u003cskend@google.com\u003e\n" }, { "commit": "0ff98e9d5aa08981dc8332f4a482b1e197f6484e", "tree": "4033715af15a99b8b348b164181a3f251a5b804c", "parents": [ "c46ddb4fa38a495da8bc0c62d7455fd77512fcdc" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Wed Jun 22 14:56:56 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Jun 22 19:04:05 2022" }, "message": "crdyboot: Fix scope of BootIO protocol\n\nfind_disk_block_io was incorrectly returning a reference to a BootIO\nprotocol that would be closed at the end of the function. Fix by storing\na ScopedProtocol in GptDisk.\n\nRequired some slight refactoring in main to satisfy the updated\nlifetimes.\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\nTEST\u003dcargo xtask update-disk\nTEST\u003dcargo xtask qemu\n\nChange-Id: Ic43c099f19dff61b4867b73adf724f9c8ca47e95\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3714940\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nReviewed-by: Steve Kendall \u003cskend@google.com\u003e\nCommit-Queue: Steve Kendall \u003cskend@google.com\u003e\n" }, { "commit": "c46ddb4fa38a495da8bc0c62d7455fd77512fcdc", "tree": "98f56e45a1c03bd9ddca4133b8a78a96eb04f49e", "parents": [ "944971145674dd6dadbf8f4e1a85016dbadc9bc0" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Tue Jun 21 21:12:19 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Jun 22 19:02:19 2022" }, "message": "Drop sbat and sbat_gen crates\n\nThese aren\u0027t currently used. Eventually it would be good to put this\ncode in a separate repo, but for now it\u0027s safe and sound in git history\nso just delete the files.\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\n\nChange-Id: If0315f4e4f72e3837150aa7fc67c99ad41c78154\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3715542\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Steve Kendall \u003cskend@google.com\u003e\nReviewed-by: Steve Kendall \u003cskend@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "944971145674dd6dadbf8f4e1a85016dbadc9bc0", "tree": "87f56df613244e65343cdf7ba277059deee45d2c", "parents": [ "cf0c95288fd61fe1c8a994d736a7f3628aab2a4d" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Tue Jun 21 21:05:18 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Jun 22 19:02:18 2022" }, "message": "crdyboot: Revert to a hardcoded sbat file\n\nSince we don\u0027t currently need to do SBAT verification the sbat and\nsbat_gen crates aren\u0027t really adding much right now. Add back in a\nhardcoded CSV file.\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\nTEST\u003dDump the sbat section with `objdump -j .sbat -s target/x86_64-unknown-uefi/release/crdyboot.efi`, verify it is unchanged\n\nChange-Id: I8f08d55c33734dfa5a6c7bc752473db8d76ee9d2\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3715541\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nReviewed-by: Steve Kendall \u003cskend@google.com\u003e\nCommit-Queue: Steve Kendall \u003cskend@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "cf0c95288fd61fe1c8a994d736a7f3628aab2a4d", "tree": "235a71a40229e6548ff2d82a08b4d0470eff7a89", "parents": [ "51c7b91a600c9caeb2f2e7026d528a563ee459aa" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Wed Jun 22 17:18:38 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Jun 22 18:51:55 2022" }, "message": "vboot: Simplify kernel buffer size checks\n\nUse direct offsets rather than big opaque structures to get the two\nfields we care about (header magic and init_size). The kernel boot\nheader layout is nicely described here:\nhttps://docs.kernel.org/x86/boot.html\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\nTEST\u003dcargo xtask update-disk\nTEST\u003dcargo xtask qemu\nTEST\u003dcargo xtask qemu --ia32\n\nChange-Id: I0a69c6d6b067c125134525f5420a8773cbb28342\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3716731\nReviewed-by: Steve Kendall \u003cskend@google.com\u003e\nCommit-Queue: Steve Kendall \u003cskend@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "51c7b91a600c9caeb2f2e7026d528a563ee459aa", "tree": "8031e867e4edd0c5178293a8e44fbd3b100793b5", "parents": [ "fed7f37dca0772f33af0daeefcd48c3a7d877e4e" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Fri Jun 17 19:46:29 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Jun 17 20:31:18 2022" }, "message": "vboot: Fix return code parsing with clang 14\n\nClang 14 produces empty `{}` nodes in the JSON output. Fix parsing of\nthese nodes by reading them as default `AstNode`s.\n\nBUG\u003db:202164480\nTEST\u003dcargo xtask check\nTEST\u003dManually verified with `diff` that the resulting header is unchanged\n\nChange-Id: Ifce9903a1ab3d07fec6b6fb2f5d7f7eb11bd5d68\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3711174\nReviewed-by: Steve Kendall \u003cskend@google.com\u003e\nCommit-Queue: Steve Kendall \u003cskend@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "fed7f37dca0772f33af0daeefcd48c3a7d877e4e", "tree": "b973cc807dc117baca1f5d66b732f72f8542d48f", "parents": [ "50e4cc0c8c37f8ab10d8c9e46433c0be16077737" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Fri Jun 17 18:45:19 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Jun 17 20:31:16 2022" }, "message": "vboot: Add stub libc headers\n\nThe new headers provide a small subset of the C standard headers. This\nallows vboot_reference to compile with clang and the\n`i686-unknown-windows-gnu` and `x86_64-unknown-windows-gnu` targets.\n\nThis replaces the `mingw-w64-i686-dev` and `mingw-w64-x86-64-dev` apt\npackages, so drop those from the readme. (Developers can now remove\nthose packages from their dev systems, but it\u0027s not required to do so.)\n\nBUG\u003db:202164480\nTEST\u003dcargo xtask check\nTEST\u003dcargo xtask update-disk\nTEST\u003dcargo xtask qemu --secure-boot\nTEST\u003dcargo xtask qemu --secure-boot --ia32\n\nChange-Id: Ib8bed62d6db0c102f343e50dd76185ed95e0b410\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3711173\nReviewed-by: Steve Kendall \u003cskend@google.com\u003e\nCommit-Queue: Steve Kendall \u003cskend@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "50e4cc0c8c37f8ab10d8c9e46433c0be16077737", "tree": "8315c3d14365612d71d9807deaab2a173e397de6", "parents": [ "c3a2cfee2c5cfaf7d95c84b3d2e3a72991cf5cc7" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Fri Jun 10 20:40:31 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Jun 10 20:58:34 2022" }, "message": "xtask: Update to shim 15.6\n\nAlso moved the `checkout -f` command to before the call to update the\nshim repo so that existing modifications don\u0027t interfere.\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\nTEST\u003dcargo xtask setup\nTEST\u003dcargo xtask update-disk\nTEST\u003dcargo xtask qemu --secure-boot\n\nChange-Id: I446af696f5037641e0b5dcfc681b6130c9055b88\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3700120\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Steve Kendall \u003cskend@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nReviewed-by: Steve Kendall \u003cskend@google.com\u003e\n" }, { "commit": "c3a2cfee2c5cfaf7d95c84b3d2e3a72991cf5cc7", "tree": "7c0c225f77f8e52c9e7d4227de5099ca0db51b16", "parents": [ "f8c10c18ff1584287afbc1417ba0b469ffadfa5a" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Fri Jun 10 18:46:45 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Jun 10 19:48:20 2022" }, "message": "xtask: Simplify more code with gpt_disk_types\n\nUse the LbaRangeInclusive type.\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\nTEST\u003dcargo xtask setup\n\nChange-Id: Ia1018aef8893cf4002e0394fc2e45fed0b40d7fd\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3700118\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Steve Kendall \u003cskend@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nReviewed-by: Steve Kendall \u003cskend@google.com\u003e\n" }, { "commit": "f8c10c18ff1584287afbc1417ba0b469ffadfa5a", "tree": "790092c42e126fd312f593b8ebcb725e184571e6", "parents": [ "a21d92758e4358fb5e74eba56e6413badd6b0f44" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Fri Jun 10 17:42:22 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Jun 10 19:48:19 2022" }, "message": "xtask: Use gpt_disk_types to simplify gen_disk\n\nReplace the manual GUID parsing and use the GptPartitionType constants.\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\nTEST\u003dcargo xtask setup\n\nChange-Id: I89648cdbb96eecf2f536ceec56cdf98fb34b9db9\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3700117\nCommit-Queue: Steve Kendall \u003cskend@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nReviewed-by: Steve Kendall \u003cskend@google.com\u003e\n" }, { "commit": "a21d92758e4358fb5e74eba56e6413badd6b0f44", "tree": "ba6c622cb4e6c294bcca3fafdd7ad90d91359b29", "parents": [ "b411fe655286b2bb25c698c821103b9cf063a8ee" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Fri Jun 10 17:28:33 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Jun 10 18:16:55 2022" }, "message": "Upgrade all deps\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\n\nChange-Id: I1bf495053341d708ca638fa6f694b862b9014a1e\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3700115\nCommit-Queue: Steve Kendall \u003cskend@google.com\u003e\nReviewed-by: Steve Kendall \u003cskend@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "b411fe655286b2bb25c698c821103b9cf063a8ee", "tree": "9aea742181b40a6e9d64e4f56965baa29e45ed8e", "parents": [ "9c5f2c005cf727eef9d59c202a9efb34e2cb02c0" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Fri Jun 10 17:20:53 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Jun 10 18:16:54 2022" }, "message": "xtask: Switch fatfs to using latest git revision\n\nThis resolves a cargo-deny error due to time v0.1 getting pulled\nin. That version has an active security advisory.\n\nThe fatfs crate hasn\u0027t seen a release in a while, and although the\nmaintainer is still active there are no current plans for a 0.4 release,\nso for now just use latest git.\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\n\nChange-Id: I233caa81b3d83967080845ffd5d2ba86b8ccd6bb\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3700114\nReviewed-by: Steve Kendall \u003cskend@google.com\u003e\nCommit-Queue: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Steve Kendall \u003cskend@google.com\u003e\n" }, { "commit": "9c5f2c005cf727eef9d59c202a9efb34e2cb02c0", "tree": "4c682b3fea515f251e37c56ac0554f9ece82d17b", "parents": [ "f5586098c9bdc783b422c8703c107947fc0bb429" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Thu May 05 14:55:42 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue May 24 22:26:24 2022" }, "message": "Update vboot_reference to a more recent commit\n\nSome minor adjustments required:\n* A new system build dep is needed: libflashrom-dev\n* A new stub function is needed to fix a link error: vb2ex_tpm_set_mode\n* A new minios keyblock flag is needed\n* Minor include path change\n* Something in the futility build has changed that requires a `make\n clean` for existing builds\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\nTEST\u003dcargo xtask prep-disk\nTEST\u003dcargo xtask update-disk\nTEST\u003dcargo xtask qemu --secure-boot\n\nChange-Id: I16e809375c47673e6beba5c07bad3cddcfd1d2b4\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3651068\nCommit-Queue: Esther Shimanovich \u003ceshimanovich@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nReviewed-by: Esther Shimanovich \u003ceshimanovich@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "f5586098c9bdc783b422c8703c107947fc0bb429", "tree": "16f5189c831cf1f0699379f610d85c34c85111d0", "parents": [ "1edf386ac38608967ca46e05c42faed6814a0fad" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Wed May 18 20:00:35 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue May 24 21:55:40 2022" }, "message": "xtask: Port gen.py to Rust\n\nThe gen.py script was used to generate most of the data in\nvboot/test_data. That test_data was then committed to the repo. In the\ninterest of making sure the code to generate test data stays up to date,\nport it to Rust and run it as part of `cargo xtask setup`. Most of the\nnew code is in gen_keys.rs, which uses openssl and futility to generate\nthe necessary files in the workspace directory.\n\nThe old test data has been deleted, and in the process it turns out that\nthe non-key files (e.g. fake_bootloader, kernel_commandline.txt, etc)\naren\u0027t even used anymore. The gen_kernel function from gen.py didn\u0027t\nneed to be ported over since its output isn\u0027t used.\n\nThe setup version has been bumped so everything should automatically\nupdate in existing checkouts.\n\nBUG\u003dNone\nTEST\u003dcargo xtask test\n\nChange-Id: I04d267222817f21533fa16560241f5c655414139\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3651067\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nReviewed-by: Esther Shimanovich \u003ceshimanovich@google.com\u003e\n" }, { "commit": "1edf386ac38608967ca46e05c42faed6814a0fad", "tree": "42b24c72932b92373fc4a83c2eae68615082b839", "parents": [ "3de3faf29a0870ff774428ba63aac7d16189428e" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Wed May 18 19:47:37 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue May 24 18:42:16 2022" }, "message": "xtask: Add KeyPaths::create_dir\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\n\nChange-Id: If92d72c69a9ae57e3ff17f7120b36edc4fb23b17\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3651066\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nReviewed-by: Esther Shimanovich \u003ceshimanovich@google.com\u003e\nCommit-Queue: Esther Shimanovich \u003ceshimanovich@google.com\u003e\n" }, { "commit": "3de3faf29a0870ff774428ba63aac7d16189428e", "tree": "d2b94fd86c911da331ef9a793c8ae6ed8b25621f", "parents": [ "b50aab77494f94b5be3cba8e75adc5e69e2a691d" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Wed May 18 18:29:46 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu May 19 15:32:50 2022" }, "message": "xtask: Add automatic setup re-run\n\nAdd a new mechanism to automatically re-run setup when needed. There\u0027s a\nnew file in the workspace called `setup_version` that contains a single\nnumber. If that version is out of date compared to the current version\nin the xtask source, setup is automatically re-run.\n\nBUG\u003dNone\nTEST\u003dcargo xtask check, verify setup isn\u0027t run\nTEST\u003dManually change current version to 1, cargo xtask check, verify setup is run\n\nChange-Id: I1f0fb3eac4d7ea701284bd980eab8531c046c61e\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3651065\nReviewed-by: Esther Shimanovich \u003ceshimanovich@google.com\u003e\nCommit-Queue: Esther Shimanovich \u003ceshimanovich@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "b50aab77494f94b5be3cba8e75adc5e69e2a691d", "tree": "d80cb7f360ac8931629adb6c3fa57ed971a5766f", "parents": [ "211f1c721b1175a3f300fbeb3cb7ecc88ea5a6f8" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Wed May 18 16:48:55 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu May 19 15:32:50 2022" }, "message": "xtask: Check dependencies with cargo deny\n\nSee https://github.com/EmbarkStudios/cargo-deny for more info about\ncargo-deny.\n\nAdd a cargo-deny config, mostly for checking dependency licenses but\nalso covers some other interesting things like checking a security\nadvisory database.\n\nUpdate `cargo xtask check` to run `cargo deny check`. It will also\ninstall cargo-deny if not already installed.\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\n\nChange-Id: I4dc260709f3226ae2f956376406df3500e60bd49\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3651062\nCommit-Queue: Esther Shimanovich \u003ceshimanovich@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nReviewed-by: Esther Shimanovich \u003ceshimanovich@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "211f1c721b1175a3f300fbeb3cb7ecc88ea5a6f8", "tree": "fba12cb35b08f51a5de640b2ccef59ef19259f4d", "parents": [ "4e6adc6a780d299165af08dd8e96c2b9046e5fac" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Wed May 18 16:13:01 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed May 18 17:32:50 2022" }, "message": "Upgrade uefi dependencies\n\nMade minor changes to crdyboot for `DevicePath` API changes.\n\nBUG\u003dNone\nTEST\u003dcargo xtask check \u0026\u0026 cargo xtask update-disk \u0026\u0026 cargo xtask qemu --secure-boot\n\nChange-Id: Ic8346457452b38021b46d6f65064ac128dd1b81c\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3651061\nReviewed-by: Esther Shimanovich \u003ceshimanovich@google.com\u003e\nCommit-Queue: Esther Shimanovich \u003ceshimanovich@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "4e6adc6a780d299165af08dd8e96c2b9046e5fac", "tree": "f0ef332065e02a9f5ce5ab7f853fefd780cb37b1", "parents": [ "2ba4ab4482fa6ef49b84dc5a731d61ea6051b739" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Wed May 18 16:05:20 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed May 18 16:20:49 2022" }, "message": "Upgrade dependencies\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\n\nChange-Id: I96db5b973367e462a61b67b1ca97114e6ad5f736\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3651060\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nReviewed-by: Esther Shimanovich \u003ceshimanovich@google.com\u003e\nCommit-Queue: Esther Shimanovich \u003ceshimanovich@google.com\u003e\n" }, { "commit": "2ba4ab4482fa6ef49b84dc5a731d61ea6051b739", "tree": "d7ef0ec1cbc5ae19e0f8468938b787d368721f23", "parents": [ "c90d4322f6287c3433708eabb715580a4693498d" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Tue May 17 21:18:14 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed May 18 15:51:47 2022" }, "message": "Add license header to all source files\n\nFor the source of the header see:\nhttps://groups.google.com/a/chromium.org/g/chromium-os-dev/c/gZBw_GxEeng/m/oH5BONcECwAJ\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\n\nChange-Id: I9262cdcb9125a81ef05b69cac6412d999639920e\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3644745\nReviewed-by: Esther Shimanovich \u003ceshimanovich@google.com\u003e\nCommit-Queue: Esther Shimanovich \u003ceshimanovich@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "c90d4322f6287c3433708eabb715580a4693498d", "tree": "2cc2184b037def29c158798b0e2fe18053631fcf", "parents": [ "1e74c06f1f14c4776973ddb9569aa2786e01ac12" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Fri May 06 21:49:43 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue May 17 20:42:41 2022" }, "message": "xtask: Remove remaining uses of loopback\n\nWhen signing kernel partitions, use `gptman` to directly read and write\nthe partition data rather than using `losetup`. This allows all\nremaining uses of `sudo` to be removed, everything can now be done\nwithout elevated permissions.\n\nDelete the `loopback` module since it is no longer used.\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\nTEST\u003dcargo xtask setup path/to/reven.bin\nTEST\u003dcargo xtask update-disk\nTEST\u003dcargo xtask qemu --secure-boot\nTEST\u003dcargo xtask qemu --secure-boot --ia32\n\nChange-Id: If14c658ea4207e5cf09812e02d17ddf3b9351487\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3630013\nReviewed-by: Jeffery Miller \u003cjefferymiller@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Jeffery Miller \u003cjefferymiller@google.com\u003e\n" }, { "commit": "1e74c06f1f14c4776973ddb9569aa2786e01ac12", "tree": "c22a1a8e935018d040dd07c61cf3d01faa748920", "parents": [ "a8fab19df4bd6998be25199329cc657af29d54a4" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Fri May 06 20:18:01 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue May 17 20:20:49 2022" }, "message": "xtask: Remove some uses of loopback\n\nWhen updating bootloaders on the image (both shim and crdyboot), use\n`gptman` and `fatfs` to directly update the disk image rather than\ncalling out to losetup and mount. This avoids some more uses of `sudo`.\n\nDelete the `mount` module entirely since it is no longer used.\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\nTEST\u003dcargo xtask setup path/to/reven.bin\nTEST\u003dcargo xtask update-disk\nTEST\u003dcargo xtask qemu --secure-boot\nTEST\u003dcargo xtask qemu --secure-boot --ia32\n\nChange-Id: Ic0e53da4c433217d668f035d742cc8ecdca46026\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3630012\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nReviewed-by: Jeffery Miller \u003cjefferymiller@google.com\u003e\nCommit-Queue: Jeffery Miller \u003cjefferymiller@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "a8fab19df4bd6998be25199329cc657af29d54a4", "tree": "b974376b9fdc4e3e7b602ea7964565d09227c755", "parents": [ "82edb97d6d4a7cbbc9803cd41159c6a86f9902b2" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Fri May 06 16:06:43 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue May 17 19:40:09 2022" }, "message": "xtask/vboot: Update test_load_kernel for reven\n\nThe test_load_kernel vboot test asserts that the kernel command line on\nthe test disk matches exactly. The command-line has changed a bit since\ncloudready and early reven builds; update it to work with a recent reven\nimage. The verity args are now partially overridden to avoid matching\nagainst a particular root partition\u0027s data.\n\nAlso change the test disk to be generated during `cargo xtask setup`\nrather than committed to the repo. This avoids updating an 18MiB binary\nfile which would unnecessarily increase the repo\u0027s size.\n\nBUG\u003dNone\nTEST\u003dcargo xtask setup\nTEST\u003dcargo xtask check\n\nChange-Id: Ib6de04f2697cbfff64c1ec8468a46d9dd998e623\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3631241\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nReviewed-by: Jeffery Miller \u003cjefferymiller@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Jeffery Miller \u003cjefferymiller@google.com\u003e\n" }, { "commit": "82edb97d6d4a7cbbc9803cd41159c6a86f9902b2", "tree": "5735603afda64c215a29c35bebad2435a3970ce4", "parents": [ "dc6c73fdcc71a9a7fbd862ec75797d7176f0a7f5" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Tue May 17 13:48:02 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue May 17 16:30:07 2022" }, "message": "Set license field in each package\n\nThe license is BSD-3-Clause (see the LICENSE file in the root, which is\nthe standard ChromiumOS license).\n\nChange-Id: I1ad33fa3305620cfe87ca895b89a174c0fc48d05\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3648783\nReviewed-by: Jeffery Miller \u003cjefferymiller@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Jeffery Miller \u003cjefferymiller@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "dc6c73fdcc71a9a7fbd862ec75797d7176f0a7f5", "tree": "e5ae4db8821ee281f28e23ed8f56f3faed431d94", "parents": [ "a34fa33e58947cf48d2302850bf1c5043abc232b" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Fri May 06 15:46:16 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue May 17 16:00:20 2022" }, "message": "xtask: Add setup action\n\nThe new setup action should be run before running other xtask\ncommands. It combines various setup operations into a single command,\nwhich simplifies the steps a human has to manually run from the README.\n\nThere are additional actions that can be moved into run_setup, but for\nnow it covers submodule initialization, copying in a reven disk image,\nenrolling secure boot keys, and the disk-prep operations.\n\nBUG\u003dNone\nTEST\u003dgit clean -dxf workspace # Start with a fresh workspace\nTEST\u003dcargo xtask setup # Fails due to missing disk image\nTEST\u003dcargo xtask setup path/to/reven/image\nTEST\u003dcargo xtask check\nTEST\u003dcargo xtask update-disk\nTEST\u003dcargo xtask qemu --secure-boot\n\nChange-Id: Ib83d8b4b59063546d634733e1b1d37b0ede30ff6\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3631240\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nReviewed-by: Jeffery Miller \u003cjefferymiller@google.com\u003e\nCommit-Queue: Jeffery Miller \u003cjefferymiller@google.com\u003e\n" }, { "commit": "a34fa33e58947cf48d2302850bf1c5043abc232b", "tree": "204a2379f7397c60282439c3b5450adcb695bfac", "parents": [ "fb9cf53382983bae148571d5997c323d8b4c048c" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Fri May 06 00:07:23 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue May 17 13:57:00 2022" }, "message": "xtask: Generate disks with gptman and fatfs\n\nThere are a couple disks that we generate: a test disk for vboot, and\nthe enroller disk. These are both GPT disks with a single\npartition. Change the implementation from calling out to command-line\ntools (like `sgdisk`, `losetep`, and `mkfs`) to using Rust libraries\nthat can directly generate the data: gptman and fatfs.\n\nThere are a couple advantages to this: it reduces the need for `sudo`\noperations, and it runs much faster (sgdisk in particular is slow)\n\nNote that this commit does not update the test disk data; some\nadditional updates are needed to make the test compatible with reven\nkernel parameters.\n\nBUG\u003dNone\nTEST\u003dcargo xtask build-vboot-test-disk\nTEST\u003dcargo xtask secure-boot-setup\nTEST\u003dcargo xtask check; test_load_kernel loads the kernel but fails the cmdline assert\n\nChange-Id: I98c24a8a96330d214bbf8e18d44098b9d41b7f18\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3631239\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nReviewed-by: Jeffery Miller \u003cjefferymiller@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "fb9cf53382983bae148571d5997c323d8b4c048c", "tree": "df85792020aed83b9f5c737c19928b7da2f9ab15", "parents": [ "3d211dadf8e1f9e9891a3492689f7d3087223224" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Thu May 05 19:04:17 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu May 05 21:28:59 2022" }, "message": "vboot: Fix vb2ex_printf host output\n\nvb2ex_printf is a variadic function used by the vboot_reference C code\nto log. We provide an implementation on the Rust side using the unstable\n`c_variadic` feature. This worked correctly when run in the uefi\nenvironment, but would print incorrect values when run on the host\ntarget (i.e. when running the vboot unit tests).\n\nI\u0027m not clear on exactly why the previous code didn\u0027t work; something\nabout how the variadic args got passed to `printf_wrapper` was\nincorrect. This might be a Rust bug, or a bug in my code. At any rate,\nusing a single function does work correctly.\n\nUnfortunately the printf test had to be removed since there\u0027s no easy\nway to programatically read the output now, but manual testing shows it\nis functioning correctly.\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\nTEST\u003dTemporarily add `panic!()` at the bottom of `test_load_kernel` to make it fail.\nTEST\u003dRun `cargo xtask check` again, observe logs contain sensible numbers.\n\nChange-Id: I8220ffbc0c15fce929f8784f5d633282c8f75761\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3629371\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Jeffery Miller \u003cjefferymiller@google.com\u003e\nTested-by: Jeffery Miller \u003cjefferymiller@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nReviewed-by: Jeffery Miller \u003cjefferymiller@google.com\u003e\n" }, { "commit": "3d211dadf8e1f9e9891a3492689f7d3087223224", "tree": "572db1bf917aa27fd5665f613f2291daac0544d6", "parents": [ "4b521d4d569ce682e03cd61520cab762a1207571" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Thu May 05 20:31:02 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu May 05 20:59:27 2022" }, "message": "xtask: Assign fixed GUID to vboot test partition\n\nEach GPT partition gets a unique GUID. By default sgdisk generates a\nrandom one, but we need a consistent value because it\u0027s checked in the\nvboot test `test_load_kernel`.\n\nThis issue is only apparent when the test disk gets regenerated, which\ndoesn\u0027t happen automatically (the file is committed to the repo\ncurrently), so it wasn\u0027t noticed before.\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\nTEST\u003dcargo xtask build-vboot-test-disk\n\nChange-Id: Ie88dee2e6dc78c3a76f95874ceaa3c8d0d727867\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3631238\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nReviewed-by: Esther Shimanovich \u003ceshimanovich@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Esther Shimanovich \u003ceshimanovich@google.com\u003e\n" }, { "commit": "4b521d4d569ce682e03cd61520cab762a1207571", "tree": "588cbc0f1a42651317a1243f0f1993a932829d22", "parents": [ "cfac96a4b5e7709d3732396a854289c1e0861b04" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Thu May 05 18:58:36 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu May 05 20:45:38 2022" }, "message": "vboot: Enable logging in test_load_kernel\n\nAdd a dev-only dep on `simple_logger` and initialize it in\n`test_load_kernel`. Logging and tests don\u0027t actually play all that well\ntogether in Rust, since loggers can only be initialized once. So, only\nenable logging in this one test. This is OK since this is the only test\nin vboot that directly uses the vboot_reference C code; having logging\nis helpful when debugging a test failure since vboot_reference has a\nbunch of internal logging calls.\n\nBUG\u003dNone\nTEST\u003dcargo xtask check\nTEST\u003dTemporarily add `panic!()` at the bottom of `test_load_kernel` to make it fail.\nTEST\u003dRun `cargo xtask check` again, observe logs are printed before the error.\n\nChange-Id: Iac85f313d4ad1e6afe0937f319a329fb8d40d5a2\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3629370\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Jeffery Miller \u003cjefferymiller@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nReviewed-by: Jeffery Miller \u003cjefferymiller@google.com\u003e\n" }, { "commit": "cfac96a4b5e7709d3732396a854289c1e0861b04", "tree": "b8ae08bb81ee6433203e1bfd89418c6cf0976f9a", "parents": [ "17b385cae4736e0a296ee30fcb1b5244e02d1e55" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Tue May 03 22:00:24 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed May 04 15:30:36 2022" }, "message": "vboot: Add comment about the origin of test_data/disk.bin\n\nBUG\u003dNone\nTEST\u003dNone\n\nChange-Id: Ie529c76b42e4a8cf11768344a63bb5a5fd263553\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3625511\nReviewed-by: Esther Shimanovich \u003ceshimanovich@google.com\u003e\nCommit-Queue: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "17b385cae4736e0a296ee30fcb1b5244e02d1e55", "tree": "8ec67d498f1963635f508d9b751c979b4fae0b40", "parents": [ "d5c36f26714e286465b4ba7f9b3de12026df7040" ], "author": { "name": "Nicholas Bishop", "email": "nicholasbishop@google.com", "time": "Tue May 03 20:09:46 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed May 04 15:30:35 2022" }, "message": "xtask: Add display option for qemu\n\nWhen running the enroller under qemu, always use headless (the logs will\nbe on stdout anyway). When running the OS under qemu, it will default to\nSDL but can be changed with `--display none` or `--display gtk`.\n\nTEST\u003dcargo xtask check\nTEST\u003dcargo xtask qemu\nTEST\u003dcargo xtask qemu --display none\nTEST\u003dcargo xtask qemu --display gtk\nTEST\u003dcargo xtask qemu --display sdl\n\nChange-Id: Iec9febd1da7d64a1a41ba413ab87f18cdeeb5296\nReviewed-on: https://chromium-review.googlesource.com/c/crdyboot/+/3625510\nCommit-Queue: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nAuto-Submit: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nReviewed-by: Jeffery Miller \u003cjefferymiller@google.com\u003e\nTested-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" } ], "next": "d5c36f26714e286465b4ba7f9b3de12026df7040" }