Add a tag for created jobs from Pinpoint CLI This CL adds an "origin":"pinpoint_cli" tag for jobs created from Pinpoint CLI. This allows to distinguish jobs created from Pinpoint CLI between jobs created from other clients. This is needed for statistics and further analysis. Example of a created job with tags: https://pinpoint-dot-chromeperf.appspot.com/job/155fb742710000 Change-Id: I5473bd7f6d20abc12ff6c24467ed45192a3a6a4f Reviewed-on: https://chromium-review.googlesource.com/c/crossbench/+/7534216 Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Maxim Sheshukov <maximsheshukov@google.com>
diff --git a/crossbench/pinpoint/config.py b/crossbench/pinpoint/config.py index 6a6262b..86e3674 100644 --- a/crossbench/pinpoint/config.py +++ b/crossbench/pinpoint/config.py
@@ -306,6 +306,8 @@ self.base.extra_browser_flags(is_crossbench), "experiment_extra_args": self.experiment.extra_browser_flags(is_crossbench), + "tags": + '{"origin": "pinpoint_cli"}', } @classmethod
diff --git a/tests/crossbench/pinpoint/test_config.py b/tests/crossbench/pinpoint/test_config.py index 1380993..f751cb7 100644 --- a/tests/crossbench/pinpoint/test_config.py +++ b/tests/crossbench/pinpoint/test_config.py
@@ -344,6 +344,7 @@ '--extra-browser-args="--js-flags=--exp-js-flag ' '--enable-features=enable3,enable4 ' '--disable-features=disable3,disable4"', + "tags": '{"origin": "pinpoint_cli"}', }) def test_to_request_dict_no_flags(self): @@ -367,6 +368,7 @@ "experiment_patch": None, "base_extra_args": None, "experiment_extra_args": None, + "tags": '{"origin": "pinpoint_cli"}', }) def test_parse_and_override_recent_commit(self): @@ -518,6 +520,7 @@ "--js-flags=--exp-js-flag " "--enable-features=--exp-enabled-feature " "--disable-features=--exp-disabled-feature", + "tags": '{"origin": "pinpoint_cli"}' })
diff --git a/tests/crossbench/pinpoint/test_start_job.py b/tests/crossbench/pinpoint/test_start_job.py index bf6fd97..8ad6516 100644 --- a/tests/crossbench/pinpoint/test_start_job.py +++ b/tests/crossbench/pinpoint/test_start_job.py
@@ -83,6 +83,8 @@ '--extra-browser-args="--test-flag --js-flags=--base-js-flag"', "experiment_extra_args": '--extra-browser-args="--js-flags=--exp-js-flag"', + "tags": + '{"origin": "pinpoint_cli"}', } self.mock_post.assert_called_with( PINPOINT_START_JOB_API_URL, data=expected_payload)