commit | bb9603b19f0b7cbae6ad59fd2aa69534596967de | [log] [tgz] |
---|---|---|
author | Mike Gerow <gerow@google.com> | Fri Sep 23 19:05:24 2022 |
committer | crosvm LUCI <crosvm-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Sep 27 19:14:59 2022 |
tree | 005d89c273ac15c76e1115555b524b36ebba46fb | |
parent | 31a517d5e2e48bb66335f0074dd1a18c114e68ec [diff] |
Revert "x86: cpuid: clear FSRM bit" This reverts commit fa1e6e32494328aacbe007d961652c1040b52e68. Reason for revert: This turns out to have been a bug in the kernel that can be addressed with the following patch: ``` diff --git a/arch/x86/kernel/cpu/intel.c b/arch/x86/kernel/cpu/intel.c index 2d7ea5480ec3..71b412f820c7 100644 --- a/arch/x86/kernel/cpu/intel.c +++ b/arch/x86/kernel/cpu/intel.c @@ -328,6 +328,7 @@ static void early_init_intel(struct cpuinfo_x86 *c) pr_info("Disabled fast string operations\n"); setup_clear_cpu_cap(X86_FEATURE_REP_GOOD); setup_clear_cpu_cap(X86_FEATURE_ERMS); + setup_clear_cpu_cap(X86_FEATURE_FSRM); } } ``` Original change's description: > x86: cpuid: clear FSRM bit > > This seems to cause an unexpected fault under Bruschetta, and possibly > any other software using Ice Lake's Fast Short REP MOVs. > > This is a port of a patch from AOSP[1]. > > [1]: https://android-review.googlesource.com/c/platform/external/crosvm/+/2138413 > > BUG=b:228795137 > TEST=deployed to brya board, bruschetta bootup no longer hangs after > entering smpboot > > Change-Id: Ifb4e8af104ee8e2945598ea4c06001cbd98c40e9 > Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/3913990 > Auto-Submit: Mike Gerow <gerow@google.com> > Reviewed-by: Daniel Verkamp <dverkamp@chromium.org> > Commit-Queue: Daniel Verkamp <dverkamp@chromium.org> Bug: b:228795137 Change-Id: I7bd8be1b33315dddb5b73df62303bd967ac0573e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/3916337 Reviewed-by: Daniel Verkamp <dverkamp@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Daniel Verkamp <dverkamp@chromium.org> Auto-Submit: Mike Gerow <gerow@google.com>
crosvm is a virtual machine monitor (VMM) based on Linux’s KVM hypervisor, with a focus on simplicity, security, and speed. crosvm is intended to run Linux guests, originally as a security boundary for running native applications on the Chrome OS platform. Compared to QEMU, crosvm doesn’t emulate architectures or real hardware, instead concentrating on paravirtualized devices, such as the virtio standard.
crosvm is currently used to run Linux/Android guests on Chrome OS devices.