Google GitGoogle Git
Sign in
chromium/devtools/devtools-frontend/08eb38a20b5c15fd5241c84b2174dd29e244cae0
commit
08eb38a20b5c15fd5241c84b2174dd29e244cae0
[log]
author
Simon Zünd <szuend@chromium.org>
Wed Apr 30 06:53:56 2025
committer
Devtools-frontend LUCI CQ <devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com>
Wed Apr 30 07:37:11 2025
tree
273b23c8bb59697b90838c82558b4b2c1104d55f
parent
40d7f461106088b30906ba39ca439e1d343e2caa [diff]
[breakpoint] Don't spam the backend when enabling Debugger takes a while

There are sites where the 'Debugger.enable' CDP call can take a couple
of seconds. During this time, the BreakpointManager currently tries to
repeatedly set the breakpoint even though the call is guaranteed to
fail.

This CL changes to logic to wait for the 'Debugger' domain to enable
after the first attempt fails.

We don't want to generally wait for the enable result as that could
cause us to miss breakpoints. In most cases sending off the
'Debugger.enable' call and already send 'Debugger.setBreakpointByUrl'
while the enable is still in-flight, is fine.

R=kimanh@chromium.org

Bug: 391200159
Change-Id: Ib7f40aa85d5fdcb31d45898d4e070478b79fa890
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6468180
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
3 files changed
tree: 273b23c8bb59697b90838c82558b4b2c1104d55f
  1. .vscode/
  2. build_overrides/
  3. config/
  4. docs/
  5. extension-api/
  6. extensions/
  7. front_end/
  8. inspector_overlay/
  9. node_modules/
  10. scripts/
  11. test/
  12. third_party/
  13. v8/
  14. build
  15. buildtools
  16. .clang-format
  17. .clang-format-ignore
  18. .editorconfig
  19. .git-blame-ignore-revs
  20. .gitallowed
  21. .gitattributes
  22. .gitignore
  23. .gitmodules
  24. .gn
  25. .mailmap
  26. .npmignore
  27. .npmrc
  28. .style.yapf
  29. .stylelintignore
  30. .stylelintrc.json
  31. AUTHORS
  32. BUILD.gn
  33. codereview.settings
  34. CONTRIBUTING.md
  35. DEPS
  36. eslint.config.mjs
  37. favicon.ico
  38. LICENSE
  39. OWNERS
  40. package-lock.json
  41. package.json
  42. PRESUBMIT.py
  43. README.md
  44. tsconfig.json
  45. WATCHLISTS
README.md

Chrome DevTools frontend

npm package

The client-side of the Chrome DevTools, including all TypeScript & CSS to run the DevTools webapp.

Source code and documentation

The frontend is available on chromium.googlesource.com. Check out the Chromium DevTools documentation for instructions to set up, use, and maintain a DevTools front-end checkout, as well as design guidelines, and architectural documentation.

Source mirrors

DevTools frontend repository is mirrored on GitHub.

DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.

The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.

Getting in touch

There are a few options to keep an eye on the latest and greatest of DevTools development: